hi. this patch seems to be a great ideea, but when trying to apply the patch to kernel 2.6.33.1 it gives the following output: linux-2.6.33.1 # cat ../rps_patch1.diff | patch -p1 patching file include/linux/netdevice.h Hunk #1 succeeded at 844 (offset 86 lines). Hunk #2 succeeded at 1281 (offset 108 lines). Hunk #3 succeeded at 1323 with fuzz 2 (offset 134 lines). Hunk #4 succeeded at 1590 with fuzz 2 (offset 136 lines). patching file net/Kconfig Hunk #1 succeeded at 45 (offset 20 ...

This is a patch to the ath/regd.c file that fixes up three warnings about macros found by the checkpatch.pl tool, these said that complex values should be enclosed in parenthesis. Signed-off-by: Luis de Bethencourt <luisbg@ubuntu.com> --- drivers/net/wireless/ath/regd.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c index 04abd1f..971edc4 100644 --- a/drivers/net/wireless/ath/regd.c +++ ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> Add include files for the CAIF Core protocol stack. caif_layer.h - Defines the structure of the CAIF protocol layers cfcnfg.h - CAIF Configuration Module for services and link layers cfctrl.h - CAIF Control Protocol Layer cffrml.h - CAIF Framing Layer cfmuxl.h - CAIF Muxing Layer cfpkt.h - CAIF Packet layer (skb helper functions) cfserl.h - CAIF Serial Layer cfsrvl.h - CAIF Service Layer Signed-off-by: ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> Support functions for the caif protocol stack: cfcnfg.c - CAIF Configuration Module used for adding and removing drivers and connection cfpkt_skbuff.c - CAIF Packet layer (SKB helper functions) Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> --- net/caif/cfcnfg.c | 529 ++++++++++++++++++++++++++++++++++++++++++ net/caif/cfpkt_skbuff.c | 593 ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> Documentation of the CAIF Protocol. Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> --- Documentation/networking/caif/Linux-CAIF.txt | 212 ++++++++++++++++++++++++++ Documentation/networking/caif/README | 110 +++++++++++++ 2 files changed, 322 insertions(+), 0 deletions(-) diff --git a/Documentation/networking/caif/Linux-CAIF.txt b/Documentation/networking/caif/Linux-CAIF.txt new file mode 100644 index ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> Add CAIF Serial driver. This driver is implemented as a line discipline. caif_serial uses the following module parameters: ser_use_stx - specifies if STart of frame eXtension is in use. ser_loop - sets the interface in loopback mode. Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> --- drivers/net/Kconfig | 2 + drivers/net/Makefile | 1 + drivers/net/caif/Kconfig | 15 ++ ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> CAIF generic protocol implementation. This layer is somewhat generic in order to be able to use and test it outside the Linux Kernel. cfctrl.c - CAIF control protocol layer cfdbgl.c - CAIF debug protocol layer cfdgml.c - CAIF datagram protocol layer cffrml.c - CAIF framing protocol layer cfmuxl.c - CAIF mux protocol layer cfrfml.c - CAIF remote file manager protocol layer cfserl.c - CAIF serial ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> Add CAIF types for Socket Address, Socket Options, and configuration parameters for the GPRS IP network interface. Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> --- include/linux/caif/caif_socket.h | 164 ++++++++++++++++++++++++++++++++++++++ include/linux/caif/if_caif.h | 34 ++++++++ 2 files changed, 198 insertions(+), 0 deletions(-) diff --git a/include/linux/caif/caif_socket.h ...

From: Sjur Braendeland <sjur.brandeland@stericsson.com> Add CAIF definitions to existing header files. Files: if_arp.h, if_ether.h, socket.h. Types: ARPHRD_CAIF, ETH_P_CAIF, AF_CAIF, PF_CAIF, SOL_CAIF, N_CAIF Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com> --- include/linux/if_arp.h | 1 + include/linux/if_ether.h | 1 + include/linux/socket.h | 5 ++++- 3 files changed, 6 insertions(+), 1 deletions(-) diff --git a/include/linux/if_arp.h ...

1) Intel drivers change tx_queue_len on link speed change and this can very seriously screw configs up on people, particularly wrt. packet scheduler setups. From Emil Tantilov. 2) In IXGBE, if FIP negotatiation frames don't get steered to the FCoE queues, drops can happen because FCoE frames going through the switches can send packets larger than the standard MTU and we must accept them. Fix from Chris Leech. 3) The long overdue fix for the r8169 CVE length check issue. ...

Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com> Luis --

From: "John W. Linville" <linville@tuxdriver.com> Pulled, thanks John! --

Subject: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver From: Elina Pasheva <epasheva@sierrawireless.com> re-submit2: Consolidated diffstat output. Re-submitting based on comments from netdev community. Summary of the changes: 1. Replaced flag FLAG_ETHER with FLAG_WWAN. 2. Fixed the e-mail address for Rory Filer. The following is a new Linux driver which exposes certain models of Sierra Wireless modems to the operating system as Network Interface Cards (NICs). This driver ...

Hi Dominik, The plan here is for you to put this in your tree now. It is safe to do so and Tejun can't carry it because this does not apply to mainline. Thanks. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

Subject: re-submit [ANNOUNCEMENT] NET: usb: sierra_net.c driver From: Elina Pasheva <epasheva@sierrawireless.com> Re-submitting based on comments from netdev community. Summary of the changes: 1. Replaced flag FLAG_ETHER with FLAG_WWAN. 2. Fixed the e-mail address for Rory Filer. The following is a new Linux driver which exposes certain models of Sierra Wireless modems to the operating system as Network Interface Cards (NICs). This driver requires a version of the sierra.c driver which ...

Add missing sg_init_table for sg_set_buf in virtio_net. Reported-by: Thomas Müller <thomas@mathtm.de> Signed-off-by: Shirley Ma <xma@us.ibm.com> --- drivers/net/virtio_net.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 25dc77c..3f5be35 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -326,6 +326,7 @@ static int add_recvbuf_small(struct virtnet_info *vi, gfp_t gfp) struct ...

Hello, I needed to program a mac address to the companion eeprom of our ks8851, and wrote the following patches, which use debug-fs as interface. I then realized that this seemed not the usual way to access net controller eeproms (ethtool seems the more standard way). I am very interesed in getting your feedbacks on the following: 1) Does it make any sense to you to use this debug-fs interface to read/write the mac address (advantage: no need for user to know how ks8851 manages the eeprom ...

The ks8851_write_mac_addr() function upates the MAC address stored in the ks8851 controler and used for ethernet traffic, but does not store the MAC address to the companion EEPROM. This patch implements a debugfs entry for writing the MAC address to the ks8851 companion EEPROM (if there is any): ks8851/mac_eeprom echo "01:23:45:67:89:AB" > <debugfs path>/ks8851/mac_eeprom => writes the MAC address. The companion EEPROM size can be configured through another debug-fs entry: ...

Need to change logic to support later versions of Yukon 2 EC_U chip. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/drivers/net/sky2.c 2010-03-29 08:48:16.490429444 -0700 +++ b/drivers/net/sky2.c 2010-03-29 09:27:36.485594685 -0700 @@ -876,6 +876,10 @@ static void sky2_mac_init(struct sky2_hw if (hw->dev[port]->mtu > ETH_DATA_LEN) reg |= GM_SMOD_JUMBO_ENA; + + if (hw->chip_id == CHIP_ID_YUKON_EC_U && + hw->chip_rev == CHIP_REV_YU_EC_U_B1) + reg |= ...

The Optima version has feature to detect link quickly without PHY interrupt, but it causes duplicate link up events. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/drivers/net/sky2.c 2010-03-29 10:29:17.530956219 -0700 +++ b/drivers/net/sky2.c 2010-03-29 10:29:18.261894374 -0700 @@ -2146,7 +2146,8 @@ static void sky2_phy_intr(struct sky2_hw istatus, phystat); if (istatus & PHY_M_IS_AN_COMPL) { - if (sky2_autoneg_done(sky2, phystat) == 0) + if ...

The Janz VMOD-TTL is a MODULbus daughterboard which fits onto any MODULbus carrier board. It essentially consists of some various logic and a Zilog Z8536 CIO Counter/Timer and Parallel IO Unit. The board must be physically configured with jumpers to enable a user to drive output signals. I am only interested in outputs, so I have made this driver as simple as possible. It only supports a very minimal subset of the features provided by the Z8536 chip. Signed-off-by: Ira W. Snyder ...

This patch series adds support for the Janz CMOD-IO carrier board, as well as the Janz VMOD-ICAN3 Intelligent CAN controller and the Janz VMOD-TTL Digital IO controller. The CMOD-IO carrier board is a PCI to MODULbus bridge, into which plug MODULbus daughterboards. I only have access to two types of daughtercards, the VMOD-ICAN3 and VMOD-TTL boards mentioned above. The CAN driver has been tested under high loads. I am able to generate ~60% bus utilization. With two VMOD-ICAN3 boards looped back ...

[...] I have to say that this compromise behaviour is highly non-obvious. Further, there is now no way to set a non-standard MTU without enabling the insecure behaviour. (This is in part a flaw in the driver interface, of course. We should have an interface to get and set MRU rather than making drivers decide an MRU based on the MTU, inconsistently and without any visibility to the administrator.) It also sucks that the secure but low-performance behaviour is enabled for all variants, ...

Official patch to fix the r8169 frame length check error. Based on this initial thread: http://marc.info/?l=linux-netdev&m=126202972828626&w=1 This is the official patch to fix the frame length problems in the r8169 driver. As noted in the previous thread, while this patch incurs a performance hit on the driver, its possible to improve performance dynamically by updating the mtu and rx_copybreak values at runtime to return performance to what it was for those NICS which are unaffected by the ...

As dave mentioned, we have no conclusive evidence that only certain chip variants show the behavior. realtek hasn't said anything about it one way or the other. AFAIK, all you need to do to test given chip is try to receive a frame thats longer than configured receive filter. I only had one NIC variant I only had the one variant that failed. My hope was to make them all safe, and, should any variants be found in the field that didn't exhibit the behavior, we could whitelist them as they got ...

After update to kernel from 2.6.29.1 to 2.6.33.1 i have this info in dmesg: 0000:05:00.0: eth1: Detected Hardware Unit Hang: TDH <1e> TDT <a> next_to_use <a> next_to_clean <1d> buffer_info[next_to_clean]: time_stamp <33bae15> next_to_watch <20> jiffies <33bafaf> next_to_watch.status <0> MAC Status <80080783> PHY Status <796d> PHY 1000BASE-T Status <3800> PHY Extended Status <3000> PCI Status <10> 0000:05:00.0: eth1: Detected Hardware Unit Hang: TDH <1e> ...

lspci -vvv + ethtool -S in attached files. Network traffic when i get this info: eth1: RX: 157.22 Mb/s TX: 379.27 Mb/s ethtool -i eth1 driver: e1000e version: 1.0.2-k2 firmware-version: 0.5-7 bus-info: 0000:05:00.0 This is: Intel Corporation 82573L Gigabit Ethernet Controller But in this server i have another gigabit interface: Intel Corporation 82573E Gigabit Ethernet Controller this interface has two times more traffic than eth0 (82573L) ethtool -i eth0 driver: ...

The libertas driver calls wiphy_unregister() without a prior wiphy_register() when a devices fails initialization. Fix this by introducing a private flag. [ 9.310000] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [...] [ 9.330000] [<c0311310>] (wiphy_unregister+0xfc/0x19c) from [<bf00c9ec>] (lbs_cfg_free+0x70/0x9c [libertas]) [ 9.330000] [<bf00c9ec>] (lbs_cfg_free+0x70/0x9c [libertas]) from [<bf014fdc>] (lbs_remove_card+0x180/0x210 [libertas]) [ ...

UBS International Holdings BV Herengracht 600 NL-1017 CJ Amsterdam, Netherlands. www.ubs.com/investmentbank Greetings, I am an investment consultant working with UBS International Holdings BV in the Netherlands. I will be happy to work a transaction of $8.5million out with you if you have a corporate or personal bank Account. If you are interested, get back to me via my private email for further informations; hhbeuker@live.nl I look forward to hearing from you as soon as possible and ...

Instead of unconditionally allocating hash table for all possible cpu's, allocate it only for online cpu's and release related memory if cpu goes down. Signed-off-by: Timo Teras <timo.teras@iki.fi> --- net/core/flow.c | 43 ++++++++++++++++++++++++++++++------------- 1 files changed, 30 insertions(+), 13 deletions(-) diff --git a/net/core/flow.c b/net/core/flow.c index 1d27ca6..104078d 100644 --- a/net/core/flow.c +++ b/net/core/flow.c @@ -309,36 +309,49 @@ void ...

Policies are now properly reference counted and destroyed from all code paths. The delayed gc is just an overhead now and can be removed. Signed-off-by: Timo Teras <timo.teras@iki.fi> --- net/xfrm/xfrm_policy.c | 39 +++++---------------------------------- 1 files changed, 5 insertions(+), 34 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 11fb48d..0ae5768 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c @@ -44,9 +44,6 @@ static struct ...

This allows to validate the cached object before returning it. It also allows to destruct object properly, if the last reference was held in flow cache. This is also a prepartion for caching bundles in the flow cache. In return for virtualizing the methods, we save on: - not having to regenerate the whole flow cache on policy removal: each flow matching a killed policy gets refreshed as the getter function notices it smartly. - we do not have to call flow_cache_flush from policy gc, since ...

All of the code considers ->dead as a hint that the cached policy needs to get refreshed. The read side can just drop the read lock without any side effects. The write side needs to make sure that it's written only exactly once. Only possible race is at xfrm_policy_kill(). This is fixed by checking result of __xfrm_policy_unlink() when needed. It will always succeed if the policy object is looked up from the hash list (so some checks are removed), but it needs to be checked if we are trying to ...

Hi All, i am searching for a stable PCI DSL Modem card for Linux (Debian Lenny). It should be exist a driver in the Kernel not extra software driver. I have a 6000MBit/s DSL wire. Does anybody know some interesting device for me? Any further information? Regards Markus --

Rarely: Fw file size can be unaligned to 8. Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com> --- drivers/net/netxen/netxen_nic_init.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c index 141bc43..439f3e8 100644 --- a/drivers/net/netxen/netxen_nic_init.c +++ b/drivers/net/netxen/netxen_nic_init.c @@ -1019,6 +1019,16 @@ netxen_load_firmware(struct netxen_adapter ...

From: Rajesh K Borundia <rajesh.borundia@qlogic.com> Signed-off-by: Rajesh K Borundia <rajesh.borundia@qlogic.com> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com> Validate all sections of unified romimage, before accessing them, to avoid seg fault. Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com> --- drivers/net/netxen/netxen_nic.h | 1 - drivers/net/netxen/netxen_nic_init.c | 154 ++++++++++++++++++++++++++++++--- 2 files changed, 140 insertions(+), 15 ...

From: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com> Kernel default tx csum function (ethtool_op_get_tx_csum) doesn't show correct csum status. It takes various FLAGS (NETIF_F_ALL_CSUM) in account to show tx csum status, which driver doesn't set while disabling tx csum. Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com> --- drivers/net/netxen/netxen_nic_ethtool.c | 6 ++++++ 1 files changed, 6 ...

Hi All, I am doing several network benchmarks on Microblaze cpu with MMU. I am seeing one issue which is weird and I would like know where the problem is. I am using the same hw design and the same Linux kernel. I have done only change in memory size (in DTS). 32MB: 18.3Mb/s 64MB: 15.2Mb/s 128MB: 10.6Mb/s 256MB: 3.8Mb/s There is huge difference between systems with 32MB and 256MB ram. I am running iperf TCP tests with these commands. On x86: iperf -c 192.168.0.105 -i 5 -t 50 On ...

I am not sure if is helpful but look below. Thanks, Michal ~ # ./netstat -s Ip: 0 total packets received 0 forwarded 0 incoming packets discarded 0 incoming packets delivered 0 requests sent out Icmp: 0 ICMP messages received 0 input ICMP message failed. ICMP input histogram: 0 ICMP messages sent 0 ICMP messages failed ICMP output histogram: Tcp: 0 active connections openings 0 passive connection openings 0 ...

I don't know how to set fixed socket buffer sizes in iperf, if you were running netperf though I would suggest fixing the socket buffer sizes with the test-specific -s (affects local) and -S (affects remote) options: netperf -t TCP_STREAM -H <remote> -l 30 -- -s 32K -S 32K -m 32K to test the hypothesis that the autotuning of the socket buffers/window size is allowing the windows to grow in the larger memory cases beyond what the TLB in your processor is comfortable with. Particularly if ...

Sorry, your netstat is not up2date. If you cannot correct it to last version [ net-tools 1.60 , netstat 1.42 ], please send cat /proc/net/snmp cat /proc/net/netstat --

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> --- net/bridge/Kconfig | 6 +- net/bridge/br_multicast.c | 401 +++++++++++++++++++++++++++++++++++++++++++++ net/bridge/br_private.h | 3 + 3 files changed, 407 insertions(+), 3 deletions(-) diff --git a/net/bridge/Kconfig b/net/bridge/Kconfig index d115d5c..9190ae4 100644 --- a/net/bridge/Kconfig +++ b/net/bridge/Kconfig @@ -33,14 +33,14 @@ config BRIDGE If unsure, say N. config ...

On Mon, 29 Mar 2010 20:01:27 +0900 Too messy with macros, I will fix. -- --

This patch series adds L2TPv3 support. It splits the existing pppol2tp driver to separate its L2TP and PPP parts, then adds new L2TPv3 functionality. The patches implement a new socket family for L2TPv3 IP encapsulation, expose virtual netdevices for each L2TPv3 ethernet pseudowire and add a netlink interface. The following drivers are provided:- l2tp_core - L2TP driver core. Always required. l2tp_ppp - L2TP PPP (PPPoL2TP). L2TPv2 and L2TPv3. l2tp_eth - L2TPv3 ethernet ...

This patch moves the existing pppol2tp driver from drivers/net into a new net/l2tp directory, which is where the upcoming L2TPv3 code will live. The existing CONFIG_PPPOL2TP config option is left in its current place to avoid "make oldconfig" issues when an existing pppol2tp user takes this change. (This is the same approach used for the pppoatm driver, which moved to net/atm.) There are no code changes. The existing drivers/net/pppol2tp.c is simply moved to net/l2tp. Signed-off-by: James ...

When dumping L2TP PPP sessions using /proc/net/l2tp, get the assigned PPP device name from PPP using ppp_dev_name(). Signed-off-by: James Chapman <jchapman@katalix.com> Reviewed-by: Randy Dunlap <randy.dunlap@oracle.com> --- net/l2tp/l2tp_ppp.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index 03195ab..8f78c27 100644 --- a/net/l2tp/l2tp_ppp.c +++ b/net/l2tp/l2tp_ppp.c @@ -608,6 +608,20 @@ out: ...

This patch makes changes to the L2TP PPP code for L2TPv3. The existing code has some assumptions about the L2TP header which are broken by L2TPv3. Also the sockaddr_pppol2tp structure of the original code is too small to support the increased size of the L2TPv3 tunnel and session id, so a new sockaddr_pppol2tpv3 structure is needed. In the socket calls, the size of this structure is used to tell if the operation is for L2TPv2 or L2TPv3. Signed-off-by: James Chapman ...

This patch adds a new L2TPIP socket family and modifies the core to handle the case where there is no UDP header in the L2TP packet. L2TP/IP uses IP protocol 115. Since L2TP/UDP and L2TP/IP packets differ in layout, the datapath packet handling code needs changes too. Userspace uses an L2TPIP socket instead of a UDP socket when IP encapsulation is required. We can't use raw sockets for this because the semantics of raw sockets don't lend themselves to the socket-per-tunnel model - we need ...

In L2TPv3, we need to create/delete/modify/query L2TP tunnel and session contexts. The number of parameters is significant. So let's use netlink. Userspace uses this API to control L2TP tunnel/session contexts in the kernel. The previous pppol2tp driver was managed using [gs]etsockopt(). This API is retained for backwards compatibility. Unlike L2TPv2 which carries only PPP frames, L2TPv3 can carry raw ethernet frames or other frame types and these do not always have an associated ...

This patch adds documentation about the L2TPv3 functionality. Signed-off-by: James Chapman <jchapman@katalix.com> Reviewed-by: Randy Dunlap <randy.dunlap@oracle.com> --- Documentation/networking/l2tp.txt | 233 ++++++++++++++++++++++++++++++++----- 1 files changed, 199 insertions(+), 34 deletions(-) diff --git a/Documentation/networking/l2tp.txt b/Documentation/networking/l2tp.txt index 63214b2..8b5a7b7 100644 --- a/Documentation/networking/l2tp.txt +++ ...

I cant see how you use cfg->use_udp_checksums, something like : ? if (!cfg->use_udp_checksums) --

Not clear to me if caller of l2tp_eth_session_find_by_ifname() is able to do dev_put(dev); --

Your Email has won the South Africa 2010 W/Cup BONUS Promo held This Week, With a prize Amount of (US$1,Million) Send Your Name:Add: Tel: Age & Occp to Congratulation.ADV GEORGE NEGOTA --

From: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com> Applied. --

From: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com> Applied. --

From: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com> Applied, but this vxge_os_dma_malloc code is completely unnecessary. If you want to allocate 4K chunks and make sure they are at least 128 byte aligned, you can allocated pages (which are always PAGE_SIZE aligned) and chop them up into the appropriate block size as needed. This is exactly how drivers/net/niu.c handles this situation. See drivers/net/niu.c:niu_rbr_add_page() --

- Fixed "ethtool -d" prints - reg_space pointer was getting over written, updating it correctly. Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com> --- diff -urpN patch3/drivers/net/vxge/vxge-ethtool.c patch4/drivers/net/vxge/vxge-ethtool.c --- patch3/drivers/net/vxge/vxge-ethtool.c 2010-03-19 16:17:46.000000000 +0530 +++ patch4/drivers/net/vxge/vxge-ethtool.c 2010-03-19 16:22:15.000000000 +0530 @@ -108,7 +108,7 @@ static ...

- Fixed MSIX interrupt configuration to support non contiguous vpaths in functions. Four msi-x vectors are reserved per vpath internal to the chip. In all, there are 68 msi-x vectors for the 17 vpaths in the chip. In the multi function configurations, non-contiguous vpaths are configured to represent a function. For instance vpaths 0 and 8 can be configured to represent function zero. - If pci_enable_msix fails for the requested vectors, try with a lesser number vectors by reducing ...

- updating Maintainer list of S2IO 10GbE drivers (xframe / vxge). Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com> --- diff -urpN orig/MAINTAINERS patch1/MAINTAINERS --- orig/MAINTAINERS 2010-03-22 15:03:44.000000000 +0530 +++ patch1/MAINTAINERS 2010-03-22 15:04:35.000000000 +0530 @@ -3767,7 +3767,6 @@ M: Ramkrishna Vepa <ram.vepa@neterion.co M: Rastapur Santosh <santosh.rastapur@neterion.com> M: Sivakumar Subramani ...

Hi Dave, After merging the final tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this: net/core/net-sysfs.c:476: warning: 'struct netdev_rx_queue' declared inside parameter list net/core/net-sysfs.c:476: warning: its scope is only this definition or declaration, which is probably not what you want net/core/net-sysfs.c:478: warning: 'struct netdev_rx_queue' declared inside parameter list net/core/net-sysfs.c: In function 'rx_queue_attr_show': net/core/net-sysfs.c:489: ...

From: Stephen Rothwell <sfr@canb.auug.org.au> Oops, a cleaner patch would be : [PATCH] rps: fix net-sysfs build for !CONFIG_RPS Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index f6b6bfe..2144a7f 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -466,6 +466,7 @@ static struct attribute_group wireless_group = { }; #endif +#ifdef CONFIG_RPS ...

From: Eric Dumazet <eric.dumazet@gmail.com> Applied, thanks guys! --

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/core/dev.c b/net/core/dev.c index bcb3ed2..887aa84 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2621,7 +2621,7 @@ void netif_nit_deliver(struct sk_buff *skb) rcu_read_unlock(); } -int __netif_receive_skb(struct sk_buff *skb) +static int __netif_receive_skb(struct sk_buff *skb) { struct packet_type *ptype, *pt_prev; struct net_device *orig_dev; --

Oops, very sorry, I replied to an existing message but forgot to edit the subject line to start a new thread. Try again: Hi netdev, We're working on some TCP networking stuff where the key is low latency -- in other words, we don't really care about data throughput, but rather getting the end-to-end TCP packet transfer time down. I know there's quite a few networking folks and kernel hackers on this list, so I thought I'd see if anyone was interested (or knows someone who might be ...

> I'm happy to receive some pointers via this list [...] Sorry, I should also have posted more about what I've done in terms of reducing latency so far: * We've already got TCP_NODELAY activated. * We've also turned off interrupt coalescing on the network card (for example, see http://www.29west.com/docs/THPM/latency-interrupt-coalescing.html). * We've modified our process's CPU affinity so it runs on a core by itself, reducing interrupt-handling latency slightly further. * Our code is ...

Careful, this might wind up hurting you. It decreases latency from the card, but might result in flooding one or more cores with additional interrupts that --

I have alot of good quality American Databases at decent prices. Contact me here: Jerome.Moore@discountdatamarket.tk for a complete catalog of what we have. to terminate please send a blank message to rembox@discountdatamarket.tk --

From: Stephen Rothwell <sfr@canb.auug.org.au> Strange, it didn't warn here. I just committed the following, let me know if it fixes this. Thanks! tulip: Add missing parens. As reported by Stephen Rothwell. drivers/net/tulip/uli526x.c: In function 'uli526x_rx_packet': drivers/net/tulip/uli526x.c:861: warning: assignment makes pointer from integer without a cast Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/tulip/uli526x.c | 2 +- 1 files changed, 1 ...

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Applied, thanks a lot! --

From: Herbert Xu <herbert@gondor.apana.org.au> Interesting idea, but there is the issue of how to fill in new metrics cache entries when these requests come in later. We'd have to retain a pointer to the routing table fib entry. This is because the fib entry states what the initial metric values need to be for cached routes. So we'd need a pointer to the fib_info in the routing cache entry, and this pointer would need to grab a reference to the fib_info. And this subsequently leads to the ...

Absolutley, I'll review the CVE text and my origional patch tomorrow morning, and submit the official patch tomorrow afternoon. Thanks! Neil --

First, please don't hijack an unrelated thread to start talking about something different. Second, the mailing lists at vger.kernel.org are not for making employment of consultancy offers. Thanks. --

As the matter of fact, ifconfig eth0 hw ether .... ends up zeroing upper 32 bits on old kernels once in a while. What orders accesses as seen by PCI bus in RTL_W8(Cfg9346, Cfg9346_Unlock); RTL_W32(MAC0, low); RTL_W32(MAC4, high); RTL_W8(Cfg9346, Cfg9346_Lock); anyway, and don't we need mmiowb() or two in there? --

Al Viro <viro@ZenIV.linux.org.uk> : Remove rtl8169scd_hw_phy_config ? No, keep it. At first sight it looks like rtl8169_open::rtl8169_check_link_status and a LinkChg interrupt (order eventually reversed) while 2.6.26 did not notice the interrupt. -- Ueimor --

You sound like a windows guy! Whats with everything having to use NetworkManager!? Are people so dumb they can't figure things out from the command line. If it acts like a NIC it should be a NIC. I am so tired of eveyone trying to make Linux look and act like WINBLOWS. -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas ...

because they are not NIC cards. They just use Ethernet emulation. And they also require a management interface to setup APN and activate them first. It is important that we tell userspace about the type of a network interface. We do the same for WiMAX and WiFi btw. Regards Marcel --

Thank you all for reviewing the sierra_net driver and for your comments. We fixed the device type, re-tested and re-submitted the driver patch. Regards, Elina --

Sorry, I withdraw this because this is incorrect; __fls() returns fls() - 1. --yoshfuji --

But which of the last N datagrams sent by the application should be retained for retransmission? It could be scores if not hundreds of datagrams depending on the behaviour of the application and the latency to the narrow part of the network. That the IPv6 specification was heavily "influenced" by "the router guys" seems increasingly clear... rick jones --

I don't think there are any good solutions that do not require either application involvement, or a modification to IPv6. How about allowing an application to request that (copies of) ICMP(v6) messages be made available through the socket? In that way, the application, which ostensibly already has to be keeping track of its sends for its own nefarious retransmission porpoises can receive the "signal" just like TCP does and perhaps there will be enough in the ICMPv6 message for the ...

I would get the alphabet soup completely garbled, but the DNS folks are talking about EDNS (?) message sizes upwards of 4096 bytes - encryption/authentication and other angels being asked to dance on the head of the DNS pin are asking for more and more space in the messages. So, someone will have to blink somewhere - either DNS will have to go TCP and *possibly* take RTT hits there depending on various patch streams, or the IEEE will have to sanction jumbo frames and people deploy them ...

IPv4 gets by this by setting DF=0 in the IP header, and lets the network fragment the packet if necessary. IPv6 can similarly get by this by having the sending host fragment the large UDP packet into IPv6 fragments no longer than 1280 bytes each. But wait! IPv4 hosts are only required to reassemble 576 bytes at a minimum, and IPv6 hosts are only required to reassemble 1500 bytes at a minimum. Indeed, RFC2460 says: "An upper-layer protocol or application that depends on IPv6 ...

As Eric pointed out in response to the message above, I believe the solution is to simply remove the rcu_dereference() call in the netlbl_unlhsh_hash() function. -- paul moore linux @ hp --

Okay, is there a recommended approach towards accessing RCU-protected pointers both under a RCU read lock and under only a spinlock (or similar lock construct)? I know I could do something based on querying the state of the RCU/etc. locks but that seems like a hack and could interfere with some of the logic used to detect coding problems. -- paul moore linux @ hp --

In fact, now that I read this again, we don't even need to grab the lock to perform the deadness check. This is because the existing never did it anyway. The liveliness is guaranteed by the policy destruction code doing a synchronous cache flush. Timo, what was the reason for getting rid of the synchronous flush again? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP ...

No that's not the point. The lock is not there to protect reading ->dead, which is atomic anyway. It's there to guarantee that you don't increment the ref count on a dead policy. For the flow cache we didn't need this because the policy code would flush the cache synchronously so we can always grab a ref count safely as long as BH is still off. So if you leave the flow cache flushing as is, then we should still be able to do the it without holding the lock, or checking I wouldn't ...

Which is fine. I'd rather have that than this new behaviour which adds a lock. We don't delete policies all the time, so Let's step back one second. It's best to not accumulate unrelated changes in one patch. So is there a reason why you must remove the synchronous flow cache flushing from the policy destruction I really see no point to optimising for such an unlikely case Please do one change at a time. Let's just focus on the original issue of the bundle linked list for ...

I don't see the point. As long as the data paths do not take the lock changing this doesn't buy us much. You're still making that cacheline exclusive. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

I was talking about the lock vs. atomic_xchg in xfrm_policy_kill. There is practically no difference for that case. Yes, on the read side the lock is a completely different beast compared to atomic_read, but I don't see how you can safely replace lock if (!dead) take ref unlock See above. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: ...

I'm not talking about the flow cache. The current flow cache code doesn't even take the lock. I'm talking about the other places that you have to convert in order to make this into an atomic_t. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

Well then converting it to an atomic_t is completely pointless. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

No you can't make it a plain write in xfrm_policy_kill. The same policy may be killed simultaneously, by the timer and user action. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

Actually you're right. This should be the case as otherwise we'd be triggering that WARN_ON. Since it hasn't triggered in the five years that it's been around, I suppose we can now remove it along with the lock. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

With a blocking socket, you'd also need to set SO_RCVTIMEO on the underlying socket to some value that makes sense and is below your max latency, because recvmmsg()'s timeout argument only applies in-between underlying recvmsg() calls, not during them. You're going to spend a lot of time spinning if max_latency is low and there are any gaps in the input stream though. I guess for some uses this must makes sense. The other potential usage is with non-blocking sockets, in which case the ...

Markus, As it happens there is a lot of discussion about stability issues with this NIC in recent[1] kernel versions right here on this list at the moment. Participants in those discussions include Francois Romieu, Timo Teräs and others. See threads "r8169 mac reading/writing broken", "r8169: fix broken register writes", "r8169: enable 64-bit DMA by default for PCI Express devices". [1]: more recent than I am using on that machine, which is 2.6.27 (Ubuntu 9.04). Jan --

Interesting. Which files in that directory contain the most current code? Looks like the tcpdump patch has been merged. Here is another tcpdump patch that implements decoding PGM via UDP. Anyone know how to submit something like that? (Need to specify -Tpgm option to use pgm decoder on UDP traffic) Index: tcpdump/interface.h =================================================================== --- tcpdump.orig/interface.h 2010-02-26 18:50:39.411609391 -0600 +++ ...

I don't know, it was just a general consideration. -Andi -- ak@linux.intel.com -- Speaking for myself only. --