Le lundi 29 mars 2010 à 10:56 +0100, James Chapman a écrit :

quoted text
> +
> +/* Session hash list.
> + * The session_id SHOULD be random according to RFC2661, but several
> + * L2TP implementations (Cisco and Microsoft) use incrementing
> + * session_ids.  So we do a real hash on the session_id, rather than a
> + * simple bitmask.
> + */
> +static inline struct hlist_head *
> +l2tp_session_id_hash(struct l2tp_tunnel *tunnel, u32 session_id)
> +{
> +	unsigned long hash_val = (unsigned long) session_id;
> +	return &tunnel->session_hlist[hash_long(hash_val, L2TP_HASH_BITS)];
> +}

Please use hash_32() here, its better in this case on 64 bit arches (32
bits in session_id)

return &tunnel->session_hlist[hash_32(session_id, L2TP_HASH_BITS)];



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html