Re: [PATCH] dst: call cond_resched() in dst_gc_task()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric Dumazet
Date: Monday, February 8, 2010 - 11:06 pm

Le lundi 08 février 2010 à 15:50 -0800, Stephen Hemminger a écrit :


Who knows, it probably depends on many factors. I always run with cache
enabled, because it saves cycles on moderate load.

FIB_TRIE is unrelated here, if routing table is very small, it fits HASH
or TRIE.

Pawel hit the bug with tunables that basically enabled the cache but in
a non helpful way (filling the list of busy dst). User error combined
with a lazy kernel function :)

Please note that conversion from softirq to workqueue, without
scheduling point, might/probably use same cpu for handling network irqs
and running dst_gc_task() :

On big routers, admins usually use irq affinities, so we can have very
litle cpu time available to run other tasks on those cpus.

After this patch, I believe that scheduler is allowed to migrate
dst_gc_task() to an idle cpu.

Another point (for 2.6.34) to address is the dst_gc_mutex that can delay
NETDEV_UNREGISTER/NETDEV_DOWN events for a long period.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Problem wit route cache, =?UTF-8?B?UGF3ZcWCIF ..., (Mon Feb 8, 6:16 am)
Re: Problem wit route cache, Eric Dumazet, (Mon Feb 8, 6:28 am)
Re: Problem wit route cache, =?UTF-8?B?UGF3ZcWCIF ..., (Mon Feb 8, 6:33 am)
Re: Problem wit route cache, Eric Dumazet, (Mon Feb 8, 6:51 am)
Re: Problem wit route cache, =?UTF-8?B?UGF3ZcWCIF ..., (Mon Feb 8, 6:59 am)
Re: Problem wit route cache, Eric Dumazet, (Mon Feb 8, 7:06 am)
Re: Problem wit route cache, =?UTF-8?B?UGF3ZcWCIF ..., (Mon Feb 8, 7:16 am)
Re: Problem wit route cache, Eric Dumazet, (Mon Feb 8, 7:32 am)
Re: Problem wit route cache, =?UTF-8?B?UGF3ZcWCIF ..., (Mon Feb 8, 7:32 am)
Re: Problem wit route cache, =?UTF-8?B?UGF3ZcWCIF ..., (Mon Feb 8, 7:45 am)
[PATCH] dst: call cond_resched() in dst_gc_task(), Eric Dumazet, (Mon Feb 8, 12:32 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), David Miller, (Mon Feb 8, 4:01 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Andrew Morton, (Mon Feb 8, 4:26 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), David Miller, (Mon Feb 8, 4:34 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Andrew Morton, (Mon Feb 8, 4:37 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), David Miller, (Mon Feb 8, 4:50 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Stephen Hemminger, (Mon Feb 8, 4:50 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Eric Dumazet, (Mon Feb 8, 11:06 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Eric Dumazet, (Mon Feb 8, 11:07 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Andrew Morton, (Mon Feb 8, 11:35 pm)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Eric Dumazet, (Tue Feb 9, 12:20 am)
Re: [PATCH] dst: call cond_resched() in dst_gc_task(), Andrew Morton, (Tue Feb 9, 12:31 am)