Re: [PATCH 2/5] C/R: Basic support for network namespaces and devices (v4)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dan Smith
Date: Tuesday, February 23, 2010 - 10:27 am

SH> But there is no guarantee that the checkpointer is in the netns
SH> which we would call the 'top level' netns.  Which means that, at
SH> restart, whether or not the devices which are in what we call the
SH> top level netns are in fact inherited or not, will depend on
SH> conditions of the checkpointer.  Do we care?  (I thought we did,
SH> but maybe we don't... it's unlikely to happen anyway)

Well, when we discussed this on IRC with Oren, I think we came to the
conclusion that since network namespaces aren't hierarchical, that we
would restore things from the "viewpoint" of the process that
checkpointed them.  It gives us a sane way to ensure that the peer
devices residing in the init netns can be put back there, even though we
don't checkpoint everything in the init netns (like eth0).

If you checkpoint a veth from within the container and you have a peer
device that is outside the container (but not in a netns that is
checkpointed as part of a task), it's going to fail and tell you that
one of your peers leaked to the outside.  I think that's sane and
preferred behavior, no?  If you're using macvlan and you checkpoint
from within the container, I think you should be okay, as long as
there is a appropriately named device to base the restored devices on
in whatever netns your restore process is in.

-- 
Dan Smith
IBM Linux Technology Center
email: danms@us.ibm.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 4/5] Add loopback checkpoint support, Dan Smith, (Tue Feb 16, 9:03 am)
Re: [PATCH 4/5] Add loopback checkpoint support, Eric Dumazet, (Tue Feb 16, 9:09 am)
Re: [PATCH 4/5] Add loopback checkpoint support, Dan Smith, (Tue Feb 16, 9:13 am)
Re: [PATCH 2/5] C/R: Basic support for network namespaces ..., Serge E. Hallyn, (Mon Feb 22, 12:45 pm)
Re: [PATCH 3/5] Add checkpoint support for veth devices (v2), Serge E. Hallyn, (Mon Feb 22, 12:56 pm)
Re: [PATCH 3/5] Add checkpoint support for veth devices (v2), Serge E. Hallyn, (Mon Feb 22, 1:57 pm)
Re: [PATCH 2/5] C/R: Basic support for network namespaces ..., Dan Smith, (Tue Feb 23, 10:27 am)
Re: [PATCH 2/5] C/R: Basic support for network namespaces ..., Serge E. Hallyn, (Tue Feb 23, 11:49 am)