Home » Mailing list archives » linux-netdev » 2010 » February » 16

[PATCH -next 1/6] bnx2: Check BNX2_FLAG_USING_MSIX flag when setting up MSIX.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Michael Chan
Subject: [PATCH -next 1/6] bnx2: Check BNX2_FLAG_USING_MSIX flag when setting up MSIX.
Date: Monday, February 15, 2010 - 10:42 pm

Checking the flag is more correct than checking bp->irq_nvecs. By
accident it is not a problem because we always have more than 1
vectors when using MSIX mode.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Benjamin Li <benli@broadcom.com>
---
 drivers/net/bnx2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index c7f5515..48bc578 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4940,7 +4940,7 @@ bnx2_init_chip(struct bnx2 *bp)
 		      BNX2_HC_CONFIG_COLLECT_STATS;
 	}
 
-	if (bp->irq_nvecs > 1) {
+	if (bp->flags & BNX2_FLAG_USING_MSIX) {
 		REG_WR(bp, BNX2_HC_MSIX_BIT_VECTOR,
 		       BNX2_HC_MSIX_BIT_VECTOR_VAL);
 
-- 
1.6.4.GIT


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH -next 1/6] bnx2: Check BNX2_FLAG_USING_MSIX flag wh ..., Michael Chan, (Mon Feb 15, 10:42 pm)
Re: [PATCH -next 1/6] bnx2: Check BNX2_FLAG_USING_MSIX fla ..., David Miller, (Tue Feb 16, 4:20 pm)