Home » Mailing list archives » linux-netdev » 2010 » December » 25

[patch] USB: cdc_ether: remove unneeded check

Previous thread: [PATCH] CAN: Use inode instead of kernel address for /proc file by Dan Rosenberg on Saturday, December 25, 2010 - 3:16 pm. (6 messages)

Next thread: [PATCH] tg3: Do not use legacy PCI power management by Rafael J. Wysocki on Saturday, December 25, 2010 - 3:56 pm. (4 messages)
[view original message]
From: Dan Carpenter
Subject: [patch] USB: cdc_ether: remove unneeded check
Date: Saturday, December 25, 2010 - 3:23 pm

We already verified that "dev->udev->actconfig->extralen" was non-zero
so "len" is non-zero here as well.

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested.

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index b3fe0de..9a60e41 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -99,9 +99,7 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf)
 		 */
 		buf = dev->udev->actconfig->extra;
 		len = dev->udev->actconfig->extralen;
-		if (len)
-			dev_dbg(&intf->dev,
-				"CDC descriptors on config\n");
+		dev_dbg(&intf->dev, "CDC descriptors on config\n");
 	}
 
 	/* Maybe CDC descriptors are after the endpoint?  This bug has
--


[ message continues ]
[view original message]
From: Oliver Neukum
Subject: Re: [patch] USB: cdc_ether: remove unneeded check
Date: Sunday, December 26, 2010 - 5:06 am

Acked-by: Oliver Neukum <oneukum@suse.de>


--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [patch] USB: cdc_ether: remove unneeded check
Date: Friday, December 31, 2010 - 12:11 pm

From: Dan Carpenter <error27@gmail.com>

Applied, thanks.
--


[ message continues ]
Previous thread: [PATCH] CAN: Use inode instead of kernel address for /proc file by Dan Rosenberg on Saturday, December 25, 2010 - 3:16 pm. (6 messages)

Next thread: [PATCH] tg3: Do not use legacy PCI power management by Rafael J. Wysocki on Saturday, December 25, 2010 - 3:56 pm. (4 messages)