Re: [PATCH] Fix CAN info leak/minor heap overflow

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Tuesday, November 9, 2010 - 10:05 am

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Tue, 09 Nov 2010 08:52:21 +0100


I find this kind of discussion extremely disappointing.

All of this stuff you CAN guys do with procfs files and version
strings is completely wrong and bogus.

Once you create a procfs file layout, you're basically stuck and you
can at best only reasonably add new fields at the end, you can't
really change existing fields.

And sysfs would have been a lot more appropriate, you could use
attributes for each value you want to export and then just add new
sysfs attributes when you want to export new values which has very
clear semantics and backwards compatability implications.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[SECURITY] CAN info leak/minor heap overflow, Dan Rosenberg, (Tue Nov 2, 11:28 am)
Re: [SECURITY] CAN info leak/minor heap overflow, Oliver Hartkopp, (Tue Nov 2, 12:43 pm)
Re: [SECURITY] CAN info leak/minor heap overflow, Dan Rosenberg, (Tue Nov 2, 12:53 pm)
Re: [SECURITY] CAN info leak/minor heap overflow, Oliver Hartkopp, (Tue Nov 2, 1:16 pm)
[PATCH] Fix CAN info leak/minor heap overflow, Urs Thuermann, (Fri Nov 5, 11:33 am)
Re: [PATCH] Fix CAN info leak/minor heap overflow, Oliver Hartkopp, (Tue Nov 9, 12:52 am)
Re: [PATCH] Fix CAN info leak/minor heap overflow, David Miller, (Tue Nov 9, 10:05 am)
Re: [PATCH] Fix CAN info leak/minor heap overflow, Oliver Hartkopp, (Tue Nov 9, 11:52 pm)
Re: [PATCH] Fix CAN info leak/minor heap overflow, David Miller, (Wed Nov 10, 10:51 am)
Re: [PATCH] Fix CAN info leak/minor heap overflow, Oliver Hartkopp, (Wed Nov 10, 3:10 pm)