Re: [PATCH] macvlan: lockless tx path

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ben Greear
Date: Thursday, November 11, 2010 - 11:13 am

On 11/11/2010 10:02 AM, Eric Dumazet wrote:

Ok, so then you have to sample soon enough that a 32-bit counter
can't wrap twice..otherwise you couldn't tell a 32 bit from a
33 bit counter, and you basically gain nothing from having "64-bit"
stats.

And that still assumes at least 32-bit stats..not 16 or whatever.
Thankfully, I doubt there are any drivers using < 32 bit stats.

I'll work on a patch for my idea when I get a chance..we'll see if
anyone likes it.

If you are aware of any drivers that return counters of other than 32 or
64bit widths, please let us know and perhaps we can fix them as well.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 8:41 am)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Wed Nov 10, 10:39 am)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 10:43 am)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Wed Nov 10, 10:53 am)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 11:18 am)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Wed Nov 10, 11:40 am)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 1:33 pm)
Re: [PATCH] macvlan: lockless tx path, Ben Hutchings, (Wed Nov 10, 2:04 pm)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 2:12 pm)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Wed Nov 10, 2:35 pm)
Re: [PATCH] macvlan: lockless tx path, Ben Hutchings, (Wed Nov 10, 2:53 pm)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 3:21 pm)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Wed Nov 10, 3:53 pm)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 4:24 pm)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Wed Nov 10, 4:36 pm)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Wed Nov 10, 4:46 pm)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Thu Nov 11, 12:03 am)
[PATCH net-next-2.6 v2] macvlan: lockless tx path, Eric Dumazet, (Thu Nov 11, 12:14 am)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Thu Nov 11, 9:40 am)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Thu Nov 11, 9:56 am)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Thu Nov 11, 10:20 am)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Thu Nov 11, 11:02 am)
Re: [PATCH] macvlan: lockless tx path, Ben Greear, (Thu Nov 11, 11:13 am)
Re: [PATCH] macvlan: lockless tx path, Eric Dumazet, (Thu Nov 11, 11:46 am)
Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path, Patrick McHardy, (Fri Nov 12, 1:20 am)
Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path, David Miller, (Tue Nov 16, 11:59 am)