| Mr. Peter Lee | Hello Friend
Dear Friend,
I am Mr. Peter Lee a South Korean, happily married with children, and
i am a Director of Hang Seng Bank Ltd, in charge of the International
Remittance department. I have a confidential business suggestion for
you. I will need you to assist me in executing a business project from
Hong Kong to your country.
It involves the transfer of a large sum of money. Everything
concerning this transaction shall be legally done without hitch.
Please endeavour to reply me if ...
| Oct 1, 4:33 pm 2010 |
| Stephen Hemminger | [PATCH net-next] gre: protocol table can be static
This table is only used in gre.c
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/ipv4/gre.c 2010-09-29 10:41:46.895895032 +0900
+++ b/net/ipv4/gre.c 2010-09-29 10:41:56.265898132 +0900
@@ -22,7 +22,7 @@
#include <net/gre.h>
-const struct gre_protocol *gre_proto[GREPROTO_MAX] __read_mostly;
+static const struct gre_protocol *gre_proto[GREPROTO_MAX] __read_mostly;
static DEFINE_SPINLOCK(gre_proto_lock);
int gre_add_protocol(const struct gre_protocol *proto, u8 ...
| Oct 1, 4:58 pm 2010 |
| akpm | [patch 2/2] drivers/net/stmmac/: add HAS_IOMEM dependency
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
The stmmac driver does not compile on s390:
drivers/net/stmmac/stmmac_main.c: In function 'stmmac_adjust_link':
drivers/net/stmmac/stmmac_main.c:210: error: implicit declaration of function 'readl'
drivers/net/stmmac/stmmac_main.c:263: error: implicit declaration of function 'writel'
drivers/net/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
drivers/net/stmmac/stmmac_main.c:1674: error: implicit declaration of function ...
| Oct 1, 2:17 pm 2010 |
| akpm | [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in- ...
From: Andrew Morton <akpm@linux-foundation.org>
ERROR: trailing statements should be on next line
#23: FILE: drivers/net/tulip/de4x5.c:5477:
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
total: 1 errors, 0 warnings, 8 lines checked
./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch ...
| Oct 1, 2:17 pm 2010 |
| akpm | [patch 1/1] sctp: prevent reading out-of-bounds memory
From: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Two user-controlled allocations in SCTP are subsequently dereferenced as
sockaddr structs, without checking if the dereferenced struct members fall
beyond the end of the allocated chunk. There doesn't appear to be any
information leakage here based on how these members are used and
additional checking, but it's still worth fixing.
[akpm@linux-foundation.org: remove unfashionable newlines, fix gmail tab->space conversion]
Signed-off-by: Dan ...
| Oct 1, 2:16 pm 2010 |
| David Brownell | Re: [PATCH 0/2] qcusbnet: Cleanups
I've not noticed this driver before .. can its
name be changed soon? As it is, it's easily
confused with "usbnet", the driver framework.
Please give it a name that just reflects the
hardware it drives, eliminating that confusion.
--
| Oct 1, 11:29 am 2010 |
| John W. Linville | pull request: wireless-next-2.6 2010-10-01
Dave,
Here is the latest round of wireless LAN updates intended for 2.6.37.
Included are some ath5k bits from Bruno Randolf, some carl9170 updates
from Christian Lamparter, some mac80211 updates from Johannes Berg,
some work for supporting multiple VIFs on one device from Ben Greear,
and a smattering of other bits.
Please let me know if there are problems!
Thanks,
John
---
The following changes since commit 94d57c4cfaa43e29ca5fa5ff874048cfc67276f5:
enic: Update MAINTAINERS ...
| Oct 1, 9:18 am 2010 |
| Simon Horman | [patch v2 01/12] [PATCH 01/12] netfilter: nf_conntrack_s ...
Signed-off-by: Simon Horman <horms@verge.net.au>
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c
index 53d8922..2fd1ea2 100644
--- a/net/netfilter/nf_conntrack_sip.c
+++ b/net/netfilter/nf_conntrack_sip.c
@@ -152,6 +152,9 @@ static int parse_addr(const struct nf_conn *ct, const char *cp,
const char *end;
int ret = 0;
+ if (!ct)
+ return 0;
+
memset(addr, 0, sizeof(*addr));
switch (nf_ct_l3num(ct)) {
case AF_INET:
--
1.7.1
--
| Oct 1, 7:35 am 2010 |
| Julian Anastasov |
| Oct 1, 2:50 pm 2010 |
| Simon Horman | [patch v2 07/12] [PATCH 07/12] IPVS: Add struct ip_vs_pe
Signed-off-by: Simon Horman <horms@verge.net.au>
---
This the first of several patches that add persistence engines.
v2
* Don't leak pe_data
- It wasn't being freed anywhere, ever
* Trivial rediff
Index: lvs-test-2.6/include/linux/ip_vs.h
===================================================================
--- lvs-test-2.6.orig/include/linux/ip_vs.h 2010-10-01 22:47:39.000000000 +0900
+++ lvs-test-2.6/include/linux/ip_vs.h 2010-10-01 22:48:51.000000000 +0900
@@ -99,8 +99,10 @@
...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 10/12] [PATCH 10/12] IPVS: Allow configuration ...
Allow the persistence engine of a virtual service to be set, edited
and unset.
This feature only works with the netlink user-space interface.
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v2
* Dereference persistence engine when a service is deleted.
This allows persistence modules to be removed from the kernel
once they are no longer used.
* Update for the recent "ipvs: changes related to service usecnt" change
* Trivial rediff
Index: ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 02/12] [PATCH 02/12] netfilter: nf_conntrack_s ...
Signed-off-by: Simon Horman <horms@verge.net.au>
---
The motivation for this is for it to be used by LVS as per
subsequent patches.
* Patrick McHardy suggested changing word_len to check for the
next newline or whitespace. But I believe this is incorrect.
For example '#' would be permitted but it is invalid
in a word according to RFC3261.
diff --git a/include/linux/netfilter/nf_conntrack_sip.h b/include/linux/netfilter/nf_conntrack_sip.h
index ff8cfbc..0ce91d5 100644
--- ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 05/12] [PATCH 05/12] IPVS: Allow null argument ...
This simplifies caller logic sightly.
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v2
* Trivial rediff
Index: lvs-test-2.6/net/netfilter/ipvs/ip_vs_ctl.c
===================================================================
--- lvs-test-2.6.orig/net/netfilter/ipvs/ip_vs_ctl.c 2010-10-01 22:25:53.000000000 +0900
+++ lvs-test-2.6/net/netfilter/ipvs/ip_vs_ctl.c 2010-10-01 22:26:10.000000000 +0900
@@ -1144,7 +1144,7 @@ ip_vs_add_service(struct ip_vs_service_u
if (sched == NULL) {
...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 11/12] [PATCH 11/12] IPVS: Fallback if persist ...
Fall back to normal persistence handling if the persistence
engine fails to recognise a packet.
This way, at least the packet will go somewhere.
It is envisaged that iptables could be used to block packets
such if this is not desired although nf_conntrack_sip would
likely need to be enhanced first.
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v2
* Trivial rediff
Index: ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 04/12] [PATCH 04/12] IPVS: Add struct ip_vs_co ...
Signed-off-by: Simon Horman <horms@verge.net.au>
---
The motivation for this is to allow persistence engine modules to
fill in the parameters.
v0.3
* Add missing changes to ip_vs_ftp.c
v2
* make "union nf_inet_addr fwmark" const
* Update for the recent addition of ip_vs_nfct.c
Index: lvs-test-2.6/include/net/ip_vs.h
===================================================================
--- lvs-test-2.6.orig/include/net/ip_vs.h 2010-10-01 21:56:39.000000000 +0900
+++ ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 00/12] IPVS: SIP Persistence Engine
This patch series adds load-balancing of UDP SIP based on Call-ID to
IPVS as well as a frame-work for extending IPVS to handle alternate
persistence requirements.
REVISIONS
This v2 of this patch series which fixes several problems
including non-atomic allocations while running atomic, and a memory leak.
v1 of this series addressed a few minor problems.
Internally there were 4 rfc versions, 0.1, 0.2, 0.3 and 0.4.
All changes are noted on a per-patch basis.
OVERVIEW
The approach ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 12/12] [PATCH 12/12] IPVS: sip persistence engine
Add the SIP callid as a key for persistence.
This allows multiple connections from the same IP address to be
differentiated on the basis of the callid.
When used in conjunction with the persistence mask, it allows connections
from different IP addresses to be aggregated on the basis of the callid.
It is envisaged that a persistence mask of 0.0.0.0 will be a useful
setting. That is, ignore the source IP address when checking for
persistence.
It is envisaged that this option will be used ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 06/12] [PATCH 06/12] IPVS: ip_vs_{un,}bind_sch ...
In general NULL arguments aren't passed by the few callers that exist,
so don't test for them.
The exception is to make passing NULL to ip_vs_unbind_scheduler() a noop.
Signed-off-by: Simon Horman <horms@verge.net.au>
v2
* Trivial rediff
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index 84dae47..d57cc4a 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -1229,8 +1229,7 @@ ip_vs_add_service(struct ip_vs_service_user_kern ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 08/12] [PATCH 08/12] IPVS: Add persistence eng ...
This shouldn't break compatibility with userspace as the new data
is at the end of the line.
I have confirmed that this doesn't break ipvsadm, the main (only?)
user-space user of this data.
Signed-off-by: Simon Horman <horms@verge.net.au>
---
* Jan Engelhardt suggested using netlink to do this, but it seems like
overkill to me. I'm willing to be convinced otherwise.
v2
* Trivial rediff
Index: ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 09/12] [PATCH 09/12] IPVS: management of persi ...
This is based heavily on the scheduler management code
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v0.4
* Export register_ip_vs_pe and unregister_ip_vs_pe
* Use one line comment format for one line comments.
* Only use at most one blank line consecutively
v1
* As suggested by Stephen Hemminger
- Convert __ip_vs_pe_lock from a rwlock to a spinlock.
This code isn't performance-critical, so there is no need for RCU.
- Rename __ip_vs_pe_lock as ip_vs_pe_lock
* Stephen ...
| Oct 1, 7:35 am 2010 |
| Simon Horman | [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched ...
Compact ip_vs_sched_persist() by setting up parameters
and calling functions once.
Signed-off-by: Simon Horman <horms@verge.net.au>
---
v2
* Make "union nf_inet_addr fwmark" const
* Don't remove the comment next to the declaration of dport
* Add a comment to the declaration of vport
Index: lvs-test-2.6/net/netfilter/ipvs/ip_vs_core.c
===================================================================
--- lvs-test-2.6.orig/net/netfilter/ipvs/ip_vs_core.c 2010-10-01 21:56:39.000000000 ...
| Oct 1, 7:35 am 2010 |
| Julian Anastasov |
| Oct 1, 1:58 pm 2010 |
| Julian Anastasov |
| Oct 1, 3:35 pm 2010 |
| Simon Horman | Re: [patch v2 00/12] IPVS: SIP Persistence Engine
Patrick, I would like these patches considered for inclusion
in nf-next-2.6. There is some minor diffing noise between
this series and "ipvs: Keep track of backlog connections",
which I posted for inclusion in nf-next-2.6 recently. Let
me know if you want me to do something about the noise.
--
| Oct 1, 8:09 am 2010 |
| Julian Anastasov |
| Oct 1, 2:45 pm 2010 |
| Simon Horman |
| Oct 1, 7:40 am 2010 |
| Simon Horman | [patch v2 1/2] [PATCH 1/2] Slightly simplify options con ...
Signed-off-by: Simon Horman <horms@verge.net.au>
diff --git a/ipvsadm.c b/ipvsadm.c
index 76ec7c4..1ac6c7f 100644
--- a/ipvsadm.c
+++ b/ipvsadm.c
@@ -763,11 +763,9 @@ static int process_options(int argc, char **argv, int reading_stdin)
switch (ce.cmd) {
case CMD_LIST:
- if ((options & OPT_CONNECTION ||
- options & OPT_TIMEOUT || options & OPT_DAEMON) &&
- (options & OPT_STATS ||
- options & OPT_PERSISTENTCONN ||
- options & OPT_RATE || options & ...
| Oct 1, 7:40 am 2010 |
| Simon Horman | [patch v2 2/2] [PATCH 2/2] Add support for persistence e ...
This adds the --pe [engine] option to the -A and -E commands
which allows a persistence engine to be associated with a virtual service.
The absence of --pe sets no persistence engine.
The --pe option only works when ipvsadm is compiled to use netlink
for user-space/kernel communication.
This patch also allows the --persistent-conn option to be given to the -L
command, which will list persistence engine data, if any is present, when
listing connections (and persistence templates).
At this ...
| Oct 1, 7:40 am 2010 |
| frank.blaschka |
| Oct 1, 5:51 am 2010 |
| frank.blaschka | [patch 1/1] [PATCH] qeth: tagging with VLAN-ID 0
From: Ursula Braun <ursula.braun@de.ibm.com>
This patch adapts qeth to handle tagged frames with VLAN-ID 0 and
with or without priority information in the tag. It enables qeth to
receive priority-tagged frames on a base interface, for example from
z/OS, without configuring an additional VLAN interface.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---
drivers/s390/net/qeth_l2_main.c | 2 ++
drivers/s390/net/qeth_l3_main.c ...
| Oct 1, 5:51 am 2010 |
| Sathya Perla | [PATCH net-next-2.6] be2net: add multiple RX queue support
Dave, incorporated your comment to discover the num of supported MSIx vectors
dynamically; thanks.
This patch adds multiple RX queue support to be2net. There are
upto 4 extra rx-queues per port into which TCP/UDP traffic can be hashed into.
Some of the ethtool stats are now displayed on a per queue basis.
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
---
drivers/net/benet/be.h | 82 +++---
drivers/net/benet/be_cmds.c | 40 +++-
drivers/net/benet/be_cmds.h | 32 ...
| Oct 1, 3:41 am 2010 |
| David L Stevens | [PATCH] correct IGMP behavior on v3 query during v2-comp ...
A recent patch to allow IGMPv2 responses to IGMPv3 queries
bypasses length checks for valid query lengths, incorrectly
resets the v2_seen timer, and does not support IGMPv1.
The following patch responds with a v2 report as required
by IGMPv2 while correcting the other problems introduced
by the patch.
Signed-Off-By: David L Stevens <dlstevens@us.ibm.com>
--- linux-2.6.36-rc5/net/ipv4/igmp.c 2010-09-20 16:56:53.000000000 -0700
+++ linux-2.6.36-rc5-dls/net/ipv4/igmp.c 2010-09-28 ...
| Sep 30, 5:29 pm 2010 |
| David Miller |
| Oct 1, 12:37 am 2010 |
| David Miller |
| Oct 1, 12:37 am 2010 |
| David Miller |
| Oct 1, 12:37 am 2010 |
| David Miller | Re: [PATCH net-next 0/8] tg3: Bugfixes and updates
From: "Matt Carlson" <mcarlson@broadcom.com>
All applied....
But really, I want to hear some real justification for a 2048 entry RX
ring at gigabit speeds. I even think 512 is way too large for gigabit
parts.
Any machine that gets one of these newer 5717 parts does not need that
much queueing, and too deep queues tend to hurt locality and thus
performance.
--
| Oct 1, 12:26 am 2010 |
| Matt Carlson | Re: [PATCH net-next 0/8] tg3: Bugfixes and updates
I don't have any personal experience where a larger ring size could
benefit. However, I have heard of situations in the past where people
have said increasing the amount of rx buffers available has smoothed
over some bursty traffic / cpu usage patterns. These people really did
Good point. I'll see if we can scale the BD ring size based on the
number of rx buffers the administrator has configured.
--
| Oct 1, 10:25 am 2010 |
| Johannes Berg | Re: wireless-testing (2.6.36-rc6): inconsistent {IN-SOF ...
I think this is due to
commit 5ed3bc7288487bd4f891f420a07319e0b538b4fe
Author: John W. Linville <linville@tuxdriver.com>
Date: Thu Jun 24 14:38:30 2010 -0400
mac80211: use netif_receive_skb in ieee80211_tx_status callpath
since
/**
* netif_receive_skb - process receive buffer from network
* @skb: buffer to process
*
* netif_receive_skb() is the main receive data processing function.
* It always succeeds. The buffer may be dropped during processing ...
| Oct 1, 4:49 am 2010 |
| David Miller |
| Oct 1, 12:37 am 2010 |
| David Miller |
| Sep 30, 9:17 pm 2010 |
| David Miller |
| Sep 30, 9:17 pm 2010 |
| David Miller |
| Sep 30, 5:57 pm 2010 |
| David Miller |
| Sep 30, 9:16 pm 2010 |
| David Miller |
| Sep 30, 9:17 pm 2010 |
| David Miller |
| Sep 30, 9:16 pm 2010 |
| David Miller |
| Sep 30, 9:16 pm 2010 |
| Eric Dumazet |
| Sep 30, 10:10 pm 2010 |
| David Miller |
| Sep 30, 6:04 pm 2010 |
| Jesse Gross | Re: VLAN packets silently dropped in promiscuous mode
That's true. Dropping here seems roughly equivalent to the effects of
a hardware VLAN filter, which will also not be tracked by a counter,
so that seems not too bad to me.
The thing that concerns me though is why so many drivers seem to have
this problem with completely dropping the VLAN header. I know that
even several of the ones that work now were broken initially and had
to be fixed. Seeing as the driver drops the VLAN information before
it gets to the general networking code I don't ...
| Sep 30, 7:37 pm 2010 |
| Eric Dumazet | [PATCH net-next] net: add a core netdev->rx_dropped counter
In this patch I fold the additional dev->rx_dropped into get_stats()
structure. We might chose to not fold it, and provides this counter in a
new /proc/net/dev column, a new rtnetlink attribute (and appropriate
iproute2 change)
What do you think ?
[PATCH net-next] net: add a core netdev->rx_dropped counter
In various situations, a device provides a packet to our stack and we
drop it before it enters protocol stack :
- softnet backlog full (accounted in /proc/net/softnet_stat)
- bad vlan ...
| Oct 1, 12:06 am 2010 |
| Eric Dumazet |
| Oct 1, 1:41 am 2010 |
| David Miller | Re: [PATCH net-next-2.6] be2net: add multiple RX queue support
From: Sathya Perla <sathya.perla@emulex.com>
If the first hunk I see in a patch is something like this, it is
not a good sign.
This is something you need to discover dynamically, and the MSI-X
vector enable functions in the kernel allow you to do this just fine.
Look at what other drivers do, they have a specific number of vectora
they try to obtain using pci_enable_msix(), and if that fails they
decrease the vector count until they are able to succeed.
--
| Sep 30, 5:39 pm 2010 |
| David Miller |
| Sep 30, 5:35 pm 2010 |
| =?UTF-8?q?Diego=20El ... | [PATCH] sctp: implement SIOCINQ ioctl() (take 3 bis)
From: Diego Elio 'Flameeyes' Pettenò <flameeyes@gmail.com>
This simple patch copies the current approach for SIOCINQ ioctl() from DCCP
into SCTP so that the userland code working with SCTP can use a similar
interface across different protocols to know how much space to allocate for
a buffer.
Signed-off-by: Diego Elio Pettenò <flameeyes@gmail.com>
---
net/sctp/socket.c | 35 ++++++++++++++++++++++++++++++++++-
1 files changed, 34 insertions(+), 1 deletions(-)
diff --git ...
| Oct 1, 2:56 am 2010 |
| Diego Elio Pettenò |
| Oct 1, 2:35 am 2010 |
| David Miller | Re: [PATCH 1/2] net-next-2.6: SYN retransmits: Rename th ...
Damian please don't do things like this.
When we make a change in net-2.6, that change is going to propagate into
net-next-2.6 the next time I do a merge.
And in this case here, the addition of the "syn_set" boolean argument to
retransmits_timed_out() will happen at that point.
So if anything, you should build on top of the bug fix we put into
net-2.6 instead of duplicating the change.
Adding the same change in two different ways to net-2.6 and net-next-2.6
makes the merge a pain in ...
| Sep 30, 5:23 pm 2010 |
| Damian Lukowski |
| Sep 30, 10:22 pm 2010 |
| Joe Perches |
| Oct 1, 6:41 am 2010 |
| Paulius Zaleckas |
| Oct 1, 6:37 am 2010 |
| Joe Perches |
| Sep 30, 5:45 pm 2010 |
| David Miller | Re: [PATCH 0/2] qcusbnet: Cleanups
From: Joe Perches <joe@perches.com>
I don't see this driver in any of my trees, so someone else
should be taking this in it seems.
--
| Sep 30, 5:33 pm 2010 |
| Matthew Garrett | Re: [PATCH] Add Qualcomm Gobi 2000 driver.
Because chosing the correct firmware requires making a runtime policy
decision, the firmware is of variable size (anywhere from 12MB to 16MB)
and it needs to be reencoded with something resembling PPP framing
before it gets dumped to the device. It's certainly possible to do it
in-kernel, but it'd be rather a lot more code and allocating that much
unswappable space sounds like something that would make some usecases
impossible.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Oct 1, 6:50 am 2010 |
| Elly Jones |
| Oct 1, 7:42 am 2010 |
| Paulius Zaleckas |
| Oct 1, 6:54 am 2010 |
| Joe Perches | Re: [PATCH 0/2] qcusbnet: Cleanups
Hi Elly,
I wouldn't go overboard on checkpatch compliance.
I think you can ignore several messages. I did.
Braces around single line statements are ok by me.
80+ column lines don't bother me much.
Probably the extern qcusbnet_debug should go into
some .h file though.
cheers, Joe
--
| Oct 1, 8:56 am 2010 |
| Eric Dumazet | [PATCH net-next V2] net: dynamic ingress_queue allocation
I first thought of this, and found it would add a new dependence on
vmlinux :
If someone wants to add NET_SCH_INGRESS module, he would need to
recompile whole kernel and reboot.
This is probably why ing_filter() and handle_ing() are enclosed with
CONFIG_NET_CLS_ACT, not CONFIG_NET_SCH_INGRESS.
Since struct net_dev only holds one pointer (after this patch), I
ingress_queue is not defined in "struct net_device *dev" if
!CONFIG_NET_CLS_ACT
Returning NULL here permits dead code ...
| Oct 1, 6:56 am 2010 |
| jamal | Re: [PATCH net-next2.6] net: dynamic ingress_queue allocation
I agree with the principle that it is valuable in making it dynamic for
people who dont want it; but, but (like my kid would say, sniff, sniff)
you are making me sad saying it is not used very much ;-> It is used
I think appropriately this should be NET_SCH_INGRESS (everywhere else as
Above, if you just returned dev->ingress_queue wouldnt it always be
I stared at above a little longer since this is the only fast path
The above looks clever but worries me because it changes the old ...
| Oct 1, 4:45 am 2010 |
| David Miller | Re: [PATCH] net: pxa168_etc.c recognize additional contr ...
From: Philip Rakity <prakity@marvell.com>
Your patch is corrupted, did you try to edit it by hand
This hunk header says there are 8 lines in the hunk beforehand
But clearly there are 8 beforehand and 9 afterwards.
Anyways I fixed this up and added your change, but please be
more careful in the future.
--
| Sep 30, 5:33 pm 2010 |
| Gustavo F. Padovan | Re: pull-request: bluetooth-2.6 2010-09-27
Hi Dave,
I got your point. And what I tried to say in the last e-mail is that
ERTM doesn't have such volatile states that need to restore after get
the lock back. The others code path it affect are very simple and also
doesn't have such problem. So we are safe against asynchronous changes.
We obvious have volatiles states, but the code paths where
bt_skb_send_alloc() is used doesn't rely on that states. I'm seeing no
problem on release the lock, alloc memory, and lock it again.
-- ...
| Sep 30, 6:22 pm 2010 |
| David Miller | Re: pull-request: bluetooth-2.6 2010-09-27
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
Do you notice what TCP does when sk_stream_wait_memory() returns?
It reloads all volatile state that might have changed in the socket
while the lock was dropped.
For example, TCP will reload the current MSS that can change
asynchronously while we don't have the socket lock.
--
| Sep 30, 5:26 pm 2010 |
| =?iso-8859-1?q?R=E9m ... |
| Oct 1, 2:20 am 2010 |
| Kumar SANGHVI |
| Oct 1, 1:55 am 2010 |
| =?iso-8859-1?q?R=E9m ... | Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to ...
Hello,
Sure. What you did is basically worse than ioctl()'s. You've implemented them
as socket options. Socket options are meant to configure parameters with
setsockopt and read paramters with getsockopt. They are not meant for 'doing'
That makes absolutely no sense if you consider how setsockopt and getsockopt
connect() should replace listen(), PIPE_CREATE and accept().
--
Rémi Denis-Courmont
http://www.remlab.net/
--
| Oct 1, 1:42 am 2010 |
| Jan Engelhardt |
| Oct 1, 4:46 pm 2010 |
| Jan Engelhardt |
| Oct 1, 4:57 pm 2010 |
| Jiri Bohac | Re: [RFC] bonding: fix workqueue re-arming races
This should be the BUG_ON(cwq->nr_active) in
destroy_workqueue()
This is really strange. bondng_store_bonds() can do two things:
create or delete a bonding device.
I checked the delete path, where I would normally expect such a
problem, but I can't find a way it could fail in this way.
bondng_store_bonds() calls unregister_netdevice(), which
- calls rollback_registered() -> bond_close()
- puts the device on the net_todo_list.
On rtnl_unlock() netdev_run_todo() gets called and that calls ...
| Oct 1, 11:22 am 2010 |
