Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jarek Poplawski
Date: Tuesday, January 19, 2010 - 3:45 pm

On Tue, Jan 19, 2010 at 03:06:01PM -0500, Michael Breuer wrote:

Maybe one more idea to try (not compiled).

Jarek P.
---

 drivers/net/sky2.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 7650f73..cdebdd3 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -2252,12 +2252,14 @@ static struct sk_buff *receive_copy(struct sky2_port *sky2,
 	skb = netdev_alloc_skb_ip_align(sky2->netdev, length);
 	if (likely(skb)) {
 		pci_dma_sync_single_for_cpu(sky2->hw->pdev, re->data_addr,
-					    length, PCI_DMA_FROMDEVICE);
+					    pci_unmap_len(re, data_size),
+					    PCI_DMA_FROMDEVICE);
 		skb_copy_from_linear_data(re->skb, skb->data, length);
 		skb->ip_summed = re->skb->ip_summed;
 		skb->csum = re->skb->csum;
 		pci_dma_sync_single_for_device(sky2->hw->pdev, re->data_addr,
-					       length, PCI_DMA_FROMDEVICE);
+					       pci_unmap_len(re, data_size),
+					       PCI_DMA_FROMDEVICE);
 		re->skb->ip_summed = CHECKSUM_NONE;
 		skb_put(skb, length);
 	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 5, 4:07 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Wed Jan 6, 12:22 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Wed Jan 6, 2:10 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Wed Jan 6, 9:53 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 12:47 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 10:56 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:01 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:17 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:35 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 11:50 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Thu Jan 7, 12:36 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Fri Jan 8, 12:45 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Wed Jan 13, 2:09 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Wed Jan 13, 2:34 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Sun Jan 17, 3:17 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Sun Jan 17, 4:05 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 12:30 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 1:46 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Mon Jan 18, 2:00 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 2:06 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 2:25 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 2:50 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 3:08 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 3:17 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Mon Jan 18, 3:40 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Michael Breuer, (Mon Jan 18, 10:46 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 1:41 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 3:47 am)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 12:59 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 1:29 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Jarek Poplawski, (Tue Jan 19, 3:45 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Stephen Hemminger, (Tue Jan 19, 6:10 pm)
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit(), Michael Breuer, (Thu Jan 21, 12:48 pm)