linux-netdev mailing list

FromSubjectsort iconDate
Rafael J. Wysocki
[Bug #13328] b44: eth0: BUG! Timeout waiting for bit 000 ...
This message has been generated automatically as a part of a report of regressions introduced between 2.6.29 and 2.6.30. The following bug entry is on the current list of known regressions introduced between 2.6.29 and 2.6.30. Please verify if it still should be listed and let me know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=13328 Subject : b44: eth0: BUG! Timeout waiting for bit 00000002 of register 42c to clear. Submitter : Francis Moreau ...
Sep 6, 11:11 am 2009
David Miller
[GIT]: Networking
Please pull to get this build regression fix. Thanks! The following changes since commit e07cccf4046978df10f2e13fe2b99b2f9b3a65db: Linus Torvalds (1): Linux 2.6.31-rc9 are available in the git repository at: master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master David S. Miller (1): gianfar: Fix build. drivers/net/gianfar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --
Sep 6, 2:14 pm 2009
Jarek Poplawski
Re: net_sched 07/07: add classful multiqueue dummy scheduler
Probably it's a matter of taste, but I wonder why these two methods used only by one qdisc in max 2 places can't be functions instead (maybe even static in case of select_queue)? (And this mq sched could Actually, I wonder if it's not cleaner to let replace all qdiscs with noops below like in qdisc delete case, and do this attaching in one So, this if could be probably made shorter with a common function, but the main point is: this probably works only for qdiscs having mq as a I guess we ...
Sep 6, 1:04 pm 2009
Tilman Schmidt
[PATCH 0/4] ISDN patches for 2.6.32
Dave, following are four patches for the Kernel CAPI ISDN subsystem which arose as by-products of my work on the Gigaset driver: one documentation update, two bugfixes (acked by the ISDN maintainer), and a debugging aid. Would you please take them into your net tree for merging in kernel release 2.6.32. Thanks, Tilman --
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 1/4] Documentation: expand isdn/INTERFACE.CAPI document
Describe the storage of CAPI messages and payload data in SKBs, kernelcapi debugging output, and note that send_message() may in fact be called in interrupt context. Impact: documentation Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- Documentation/isdn/INTERFACE.CAPI | 68 ++++++++++++++++++++++++++++++++----- 1 files changed, 59 insertions(+), 9 deletions(-) diff --git a/Documentation/isdn/INTERFACE.CAPI b/Documentation/isdn/INTERFACE.CAPI index 686e107..e6bb1a7 100644 --- ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 2/4] isdn: accept CAPI Informational Info values ...
Info values in the 0x00xx range are defined in the CAPI standard as "Informational, message processed successfully". Therefore a CONNECT_B3_CONF message with an Info value in that range should open an NCCI just as with Info==0. Signed-off-by: Tilman Schmidt <tilman@imap.cc> Acked-by: Karsten Keil <keil@b1-systems.de> --- drivers/isdn/capi/capi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c index ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 3/4] isdn: avoid races in capidrv
In several places, capidrv sends a CAPI message to the ISDN device and then updates its internal state accordingly. If the response message from the device arrives before the state is updated, it may be rejected or processed incorrectly. Avoid these races by updating the state before emitting the message. Signed-off-by: Tilman Schmidt <tilman@imap.cc> Acked-by: Karsten Keil <keil@b1-systems.de> --- drivers/isdn/capi/capidrv.c | 24 ++++++++++++------------ 1 files changed, 12 ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 4/4] isdn: make capidrv module parameter "debugmo ...
Being able to change the debugmode module parameter of capidrv on the fly is quite useful for debugging and doesn't do any harm. Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/capi/capidrv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index c3f5472..75c691c 100644 --- a/drivers/isdn/capi/capidrv.c +++ b/drivers/isdn/capi/capidrv.c @@ -40,7 +40,7 @@ static int debugmode = 0; ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 05/12] gigaset: announce if built with debugging
Mention in the driver load announcement whether the driver was built with debugging messages enabled, to facilitate support. Impact: informational message Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/common.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index e4141bf..edbcaa3 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -22,6 ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 00/12] Gigaset driver patches for 2.6.32
Dave, following is a series of patches for the Gigaset driver which I would appreciate getting merged into kernel release 2.6.32. The first one is a bugfix I had already submitted for 2.6.31 but which seems to have fallen through the cracks. Please disregard if it's already present your tree. The next eight patches provide various small bugfixes, error handling and documentation improvements. The final three patches add an alternative interface to the driver, connecting to the Kernel ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 08/12] gigaset: correct debugging output selection
Dump payload data consistently only when DEBUG_STREAM_DUMP debug bit is set. Impact: debugging aid Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/isocdata.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/gigaset/isocdata.c b/drivers/isdn/gigaset/isocdata.c index bed38fc..7fd32f0 100644 --- a/drivers/isdn/gigaset/isocdata.c +++ b/drivers/isdn/gigaset/isocdata.c @@ -429,7 +429,7 @@ static inline int ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 03/12] gigaset: linearize skb
The code of the Gigaset driver assumes that sk_buff-s coming from the ISDN4Linux subsystem are always linear. Explicitly calling skb_linearize() is cheap if they are, but much more robust in case they ever aren't. Impact: robustness improvement Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/i4l.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/isdn/gigaset/i4l.c b/drivers/isdn/gigaset/i4l.c index 9b22f9c..322f16e 100644 --- ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 02/12] gigaset: fix reject/hangup handling
Signal D channel disconnect in a few cases where it was missed, including when an incoming call is disconnected before it was accepted. Impact: error handling improvement Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/ev-layer.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c index 2d91049..ff2ec2c 100644 --- a/drivers/isdn/gigaset/ev-layer.c +++ ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 01/12] gigaset: really fix chars_in_buffer
The tty_operation chars_in_buffer() is not allowed to return a negative value to signal an error. Corrects the problem flagged by commit 23198fda7182969b619613a555f8645fdc3dc334, "tty: fix chars_in_buffers". Impact: error handling bugfix Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/interface.c | 19 +++++++------------ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 06/12] gigaset: fix device ERROR response handling
Clear out pending command that got rejected with 'ERROR' response. This fixes the bug where unloading the driver module would hang with the message: "gigaset: not searching scheduled commands: busy" Impact: error handling bugfix Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/ev-layer.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c index ff2ec2c..2d47ff4 ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 07/12] gigaset: improve error recovery
When the Gigaset base stops responding, try resetting the USB connection to recover. Impact: error handling improvement Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/bas-gigaset.c | 69 +++++++++++++++++++++++------------ 1 files changed, 45 insertions(+), 24 deletions(-) diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c index 9e7108a..44bcfd9 100644 --- a/drivers/isdn/gigaset/bas-gigaset.c +++ ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 09/12] gigaset: add kerneldoc comments
Add kerneldoc comments to some functions in the Gigaset driver. Impact: documentation Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/asyncdata.c | 28 ++++++--- drivers/isdn/gigaset/common.c | 126 +++++++++++++++++++++++++++++++------- drivers/isdn/gigaset/ev-layer.c | 9 ++- drivers/isdn/gigaset/i4l.c | 17 +++++ drivers/isdn/gigaset/interface.c | 9 +++ drivers/isdn/gigaset/isocdata.c | 21 +++--- 6 files changed, 166 insertions(+), 44 ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 11/12] gigaset: allow building without I4L
Add a dummy LL interface to the Gigaset driver so that it can be built and, in a limited way, used without the ISDN4Linux subsystem. Impact: new configuration alternative Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/Kconfig | 13 +++++++- drivers/isdn/gigaset/Makefile | 4 ++- drivers/isdn/gigaset/dummyll.c | 68 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 83 insertions(+), 2 deletions(-) create mode 100644 ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 04/12] gigaset: handle isoc frame errors more gra ...
Don't drop the remainder of an URB if an isochronous frame has an error. Impact: error handling improvement Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/bas-gigaset.c | 18 +++++++----------- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c index 781c404..9e7108a 100644 --- a/drivers/isdn/gigaset/bas-gigaset.c +++ b/drivers/isdn/gigaset/bas-gigaset.c @@ -1331,28 +1331,24 @@ ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 10/12] gigaset: prepare for CAPI implementation
Reorganize the code of the Gigaset driver, moving all isdn4linux dependencies to the source file i4l.c so that it can be replaced by a file capi.c interfacing to Kernel CAPI instead. Impact: refactoring, no functional change Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- drivers/isdn/gigaset/asyncdata.c | 109 ++++----- drivers/isdn/gigaset/bas-gigaset.c | 4 +- drivers/isdn/gigaset/common.c | 42 ++-- drivers/isdn/gigaset/ev-layer.c | 63 +++-- ...
Sep 6, 11:58 am 2009
Tilman Schmidt
[PATCH 12/12] gigaset: add Kernel CAPI interface
Add a Kernel CAPI interface to the Gigaset driver. Impact: optional new functionality Signed-off-by: Tilman Schmidt <tilman@imap.cc> --- Documentation/isdn/README.gigaset | 34 +- drivers/isdn/gigaset/Kconfig | 18 +- drivers/isdn/gigaset/Makefile | 1 + drivers/isdn/gigaset/capi.c | 2095 +++++++++++++++++++++++++++++++++++++ drivers/isdn/gigaset/common.c | 26 + drivers/isdn/gigaset/ev-layer.c | 26 +- drivers/isdn/gigaset/gigaset.h | 7 +- 7 files ...
Sep 6, 11:58 am 2009
Jarek Poplawski
Re: net_sched 05/07: reintroduce dev->qdisc for use by sch_api
Probably I miss something, but in mq root case it seems to never do anything we need. If so, it could be the example of possible issues elsewhere. I thought this mq virtual root qdisc could be done more transparently and invisible for the current code, but it seems, in your implementation some pointers like this, or parent ids (especially TC_H_ROOT) might be different, and even if it works OK, needs a lot of verification. So, my question is, if it's really necessary. --
Sep 6, 11:57 am 2009
Xiaofei Wu
[iproute2] tc action mirred question
Hi, I have something to ask. I construct a network like this: /A\ B D \C/ All of the nodes(A, B, C, D) have two wireless cards (wlan0, wlan1). A-B, B-C, A-D, D-C are wireless links. Node A wnats to transmit packets with node C. Because the wireless links are not very reliable, I want to forward the same packet through A-B-C and A-D-C simultaneously. How to achieve my purpose? On node A, wlan0, IP address 192.168.1.1/24 ; wlan1, IP address 192.168.2.1/24 I use command 'tc ...
Sep 6, 10:13 am 2009
jamal
Re: [iproute2] tc action mirred question
Is there a trick to this question or is it too basic? ;-> You should repeat the same on wlan1 to mirror to wlan0 i.e on wlan1: match ip src 192.168.2.0/24 ... action mirred egress mirror dev wlan0 Note the node C will receive "wrong" src mac addresses on those interfaces; you may want to correct/edit them first before you send them out. Look at using the pedit action. cheers, jamal --
Sep 6, 11:13 am 2009
Moni Shoua
[PATCH RESEND] bonding: remap muticast addresses without ...
This patch fixes commit e36b9d16c6a6d0f59803b3ef04ff3c22c3844c10. The approach there is to call dev_close()/dev_open() whenever the device type is changed in order to remap the device IP multicast addresses to HW multicast addresses. This approach suffers from 2 drawbacks: *. It assumes tha the device is UP when calling dev_close(), or otherwise dev_close() has no affect. It is worth to mention that initscripts (Redhat) and sysconfig (Suse) doesn't act the same in this matter. *. ...
Sep 6, 4:34 am 2009
David Miller
Re: 2.6.31-rc9 breaks gianfar
From: Michael Guntsche <mike@it-loops.com> Date: Sun, 6 Sep 2009 09:27:08 +0200 Please also report networking bugs to netdev@vger.kernel.org Toru-chan, did you even compile test this again current kernels? I'll commit the following fix and push it to Linus, thanks. From 5db8bfee2dbb3ff28c18868081398fa6e2155053 Mon Sep 17 00:00:00 2001 From: David S. Miller <davem@davemloft.net> Date: Sun, 6 Sep 2009 01:41:02 -0700 Subject: [PATCH] gianfar: Fix build. Reported by Michael Guntsche ...
Sep 6, 1:41 am 2009
Dhananjay Phadke
[PATCH NEXT 0/6] nexten: fixes and enhancements
Series of 6 driver enhancements / fixes, please apply to net-next-2.6. Thanks, Dhananjay --
Sep 5, 8:43 pm 2009
Dhananjay Phadke
[PATCH NEXT 5/6] netxen: refactor firmware info code
o Combine netxen_get_firmware_info(), netxen_check_options() so that they are updated every time firmware is reset. o Set dma mask everytime firmware is reset. Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic.h | 1 - drivers/net/netxen/netxen_nic_hw.c | 59 -------------- drivers/net/netxen/netxen_nic_main.c | 141 +++++++++++++++++++++++---------- 3 files changed, 98 insertions(+), 103 deletions(-) diff --git ...
Sep 5, 8:43 pm 2009
Dhananjay Phadke
[PATCH NEXT 2/6] netxen: firmware hang detection
Implement state machine to detect firmware hung state and recover. Since firmware will be shared by all PCI functions that have different class drivers (NIC or FCOE or iSCSI), explicit hardware based serialization is required for initializing firmware. o Used global scratchpad register to maintain device reference count. Every probed pci function adds to ref count. o Implement timer (delayed work) for each pci func that checks firmware heartbit every 5 sec and detaches itself if ...
Sep 5, 8:43 pm 2009
Dhananjay Phadke
[PATCH NEXT 6/6] netxen: update version to 4.0.50
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h index df03ea4..2a52479 100644 --- a/drivers/net/netxen/netxen_nic.h +++ b/drivers/net/netxen/netxen_nic.h @@ -58,8 +58,8 @@ #define _NETXEN_NIC_LINUX_MAJOR 4 #define _NETXEN_NIC_LINUX_MINOR 0 -#define _NETXEN_NIC_LINUX_SUBVERSION 41 -#define ...
Sep 5, 8:43 pm 2009
Dhananjay Phadke
[PATCH NEXT 4/6] netxen: pre calculate register addresses
From: Amit Kumar Salecha <amit@netxen.com> For registers accessed in fast path (interrupt / softirq) avoid expensive I/O address translation. These registers are directly mapped in PCI bar 0 and do not require any window checks. Signed-off-by: Amit Kumar Salecha <amit@netxen.com> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic.h | 75 +++++--------- drivers/net/netxen/netxen_nic_ctx.c | 21 +++-- ...
Sep 5, 8:43 pm 2009
Dhananjay Phadke
[PATCH NEXT 3/6] netxen: fix ip addr hashing after firmw ...
From: Amit Kumar Salecha <amit@netxen.com> Reprogram local IP addresses after firmware is reset or after resuming from suspend. Signed-off-by: Amit Kumar Salecha <amit@netxen.com> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_main.c | 61 +++++++++++++++++++++------------ 1 files changed, 39 insertions(+), 22 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 4989436..7038e1b 100644 --- ...
Sep 5, 8:43 pm 2009
Dhananjay Phadke
[PATCH NEXT 1/6] netxen: handle firmware load errors
Unwind allocations and release file firmware when when firmware load fails. Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_hw.c | 3 +++ drivers/net/netxen/netxen_nic_init.c | 1 + drivers/net/netxen/netxen_nic_main.c | 20 ++++++++++++++++---- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_hw.c b/drivers/net/netxen/netxen_nic_hw.c index db510ce..d0ac8fa 100644 --- ...
Sep 5, 8:43 pm 2009
David Miller
Re: net_sched 02/07: make cls_ops->tcf_chain() optional
From: Patrick McHardy <kaber@trash.net> I'll add the following to patch 2: diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 8cbc66f..6a53694 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -433,6 +433,8 @@ static int tc_dump_tfilter(struct sk_buff *skb, struct netlink_callback *cb) goto out; if ((cops = q->ops->cl_ops) == NULL) goto errout; + if (cops->tcf_chain == NULL) + goto errout; if (TC_H_MIN(tcm->tcm_parent)) { cl = cops->get(q, ...
Sep 6, 2:06 am 2009
David Miller
Re: net_sched 00/07: classful multiqueue dummy scheduler
From: Patrick McHardy <kaber@trash.net> I've intesgrated this into patch 7, thanks! --
Sep 6, 2:01 am 2009
previous daytodaynext day
September 5, 2009September 6, 2009September 7, 2009