Home » Mailing list archives » linux-netdev » 2009 » September » 6

[PATCH 03/12] gigaset: linearize skb

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Tilman Schmidt
Subject: [PATCH 03/12] gigaset: linearize skb
Date: Sunday, September 6, 2009 - 11:58 am

The code of the Gigaset driver assumes that sk_buff-s coming
from the ISDN4Linux subsystem are always linear. Explicitly
calling skb_linearize() is cheap if they are, but much more
robust in case they ever aren't.

Impact: robustness improvement
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
 drivers/isdn/gigaset/i4l.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/isdn/gigaset/i4l.c b/drivers/isdn/gigaset/i4l.c
index 9b22f9c..322f16e 100644
--- a/drivers/isdn/gigaset/i4l.c
+++ b/drivers/isdn/gigaset/i4l.c
@@ -51,6 +51,12 @@ static int writebuf_from_LL(int driverID, int channel, int ack,
 		return -ENODEV;
 	}
 	bcs = &cs->bcs[channel];
+
+	/* can only handle linear sk_buffs */
+	if (skb_linearize(skb) < 0) {
+		dev_err(cs->dev, "%s: skb_linearize failed\n", __func__);
+		return -ENOMEM;
+	}
 	len = skb->len;
 
 	gig_dbg(DEBUG_LLDATA,
-- 
1.6.2.1.214.ge986c

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 12/12] gigaset: add Kernel CAPI interface, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 10/12] gigaset: prepare for CAPI implementation, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 04/12] gigaset: handle isoc frame errors more grace ..., Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 11/12] gigaset: allow building without I4L, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 09/12] gigaset: add kerneldoc comments, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 08/12] gigaset: correct debugging output selection, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 07/12] gigaset: improve error recovery, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 06/12] gigaset: fix device ERROR response handling, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 02/12] gigaset: fix reject/hangup handling, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 03/12] gigaset: linearize skb, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 05/12] gigaset: announce if built with debugging, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 01/12] gigaset: really fix chars_in_buffer, Tilman Schmidt, (Sun Sep 6, 11:58 am)
[PATCH 00/12] Gigaset driver patches for 2.6.32, Tilman Schmidt, (Sun Sep 6, 11:58 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, Daniel Walker, (Sun Sep 6, 6:26 pm)
[PATCH 07/12 v2] gigaset: improve error recovery, Tilman Schmidt, (Mon Sep 7, 1:59 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, David Miller, (Mon Sep 7, 2:00 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, Tilman Schmidt, (Mon Sep 7, 2:07 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, Tilman Schmidt, (Mon Sep 7, 2:11 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, David Miller, (Mon Sep 7, 2:18 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, Daniel Walker, (Mon Sep 7, 7:30 am)
Re: [PATCH 00/12] Gigaset driver patches for 2.6.32, Karsten Keil, (Mon Sep 7, 11:56 am)