[PATCH] ipv6: Add IFA_F_DADFAILED flag

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Brian Haley
Date: Friday, September 4, 2009 - 6:38 pm

[Note: if this is accepted I'll send out a patch for iproute,
 if you'd prefer to not use the last ifa_flag I'll send a
 much larger patch that does this differently :) ]


Add IFA_F_DADFAILED flag to denote an IPv6 address that has
failed Duplicate Address Detection, that way tools like
/sbin/ip can be more informative.

3: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qlen 1000
    inet6 2001:db8::1/64 scope global tentative dadfailed 
       valid_lft forever preferred_lft forever

Signed-off-by: Brian Haley <brian.haley@hp.com>
---

diff --git a/include/linux/if_addr.h b/include/linux/if_addr.h
index a60c821..fd97404 100644
--- a/include/linux/if_addr.h
+++ b/include/linux/if_addr.h
@@ -41,6 +41,7 @@ enum
 
 #define	IFA_F_NODAD		0x02
 #define IFA_F_OPTIMISTIC	0x04
+#define IFA_F_DADFAILED		0x08
 #define	IFA_F_HOMEADDRESS	0x10
 #define IFA_F_DEPRECATED	0x20
 #define IFA_F_TENTATIVE		0x40
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 43b3c9f..6532966 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1376,7 +1376,7 @@ static void addrconf_dad_stop(struct inet6_ifaddr *ifp)
 	if (ifp->flags&IFA_F_PERMANENT) {
 		spin_lock_bh(&ifp->lock);
 		addrconf_del_timer(ifp);
-		ifp->flags |= IFA_F_TENTATIVE;
+		ifp->flags |= IFA_F_DADFAILED;
 		spin_unlock_bh(&ifp->lock);
 		in6_ifa_put(ifp);
 #ifdef CONFIG_IPV6_PRIVACY
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ipv6: Add IFA_F_DADFAILED flag, Brian Haley, (Fri Sep 4, 6:38 pm)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Jens Rosenboom, (Tue Sep 8, 6:57 am)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Brian Haley, (Tue Sep 8, 8:18 am)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Jens Rosenboom, (Tue Sep 8, 8:43 am)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Brian Haley, (Wed Sep 9, 5:41 pm)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Jens Rosenboom, (Thu Sep 10, 9:11 am)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Brian Haley, (Thu Sep 10, 12:14 pm)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, David Miller, (Fri Sep 11, 12:38 pm)
Re: [PATCH] ipv6: Add IFA_F_DADFAILED flag, Stephen Hemminger, (Tue Dec 1, 5:01 pm)