Re: UDP multicast packet loss not reported if TX ring overrun?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Wednesday, August 26, 2009 - 7:08 am

I also see no UDP stats for packet drops. If Erics fix gets in then
ip_push_pending_frames() will give us an error code on drop.
Incrementing SNDBUFERRORS would require this simple patch.


UDP: Account for TX drops

UDP layer is currently not incrementing error counters when packets are
dropped. Use the SNDBUFERRORS to indicate packet drops on send.

Signed-off-by: Christoph Lameter <cl@linux-foundation.org>

---
 net/ipv4/udp.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux-2.6/net/ipv4/udp.c
===================================================================
--- linux-2.6.orig/net/ipv4/udp.c	2009-08-26 13:21:30.000000000 +0000
+++ linux-2.6/net/ipv4/udp.c	2009-08-26 13:46:35.000000000 +0000
@@ -559,6 +559,13 @@ static int udp_push_pending_frames(struc

 send:
 	err = ip_push_pending_frames(sk);
+
+	if (err)
+		/*
+		 * Packet was dropped.
+		 */
+		UDP_INC_STATS_USER(sock_net(sk),
+			UDP_MIB_SNDBUFERRORS, is_udplite);
 out:
 	up->len = 0;
 	up->pending = 0;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Tue Aug 25, 12:15 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Sridhar Samudrala, (Tue Aug 25, 3:35 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Wed Aug 26, 7:08 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Wed Aug 26, 8:27 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Wed Aug 26, 9:29 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Sridhar Samudrala, (Wed Aug 26, 10:50 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Wed Aug 26, 12:09 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Sridhar Samudrala, (Wed Aug 26, 3:11 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Thu Aug 27, 8:40 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Thu Aug 27, 1:23 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Fri Aug 28, 6:53 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Fri Aug 28, 9:15 am)
[PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Fri Aug 28, 10:26 am)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Fri Aug 28, 12:53 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Fri Aug 28, 1:00 pm)
Re: UDP multicast packet loss not reported if TX ring overrun?, Christoph Lameter, (Fri Aug 28, 1:09 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, David Miller, (Fri Aug 28, 11:38 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Mon Aug 31, 5:09 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, David Miller, (Tue Sep 1, 6:41 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Wed Sep 2, 7:43 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Wed Sep 2, 9:05 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Sridhar Samudrala, (Wed Sep 2, 9:11 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Wed Sep 2, 9:20 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Christoph Lameter, (Wed Sep 2, 11:22 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Christoph Lameter, (Wed Sep 2, 12:37 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Wed Sep 2, 3:26 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, David Miller, (Wed Sep 2, 6:05 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, David Miller, (Wed Sep 2, 6:09 pm)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Eric Dumazet, (Thu Sep 3, 7:12 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Christoph Lameter, (Thu Sep 3, 10:57 am)
Re: [PATCH net-next-2.6] ip: Report qdisc packet drops, Christoph Lameter, (Thu Sep 3, 11:35 am)