Home » Mailing list archives » linux-netdev » 2009 » August » 26

Re: [PATCH 1/2] Add an alternative cs89x0 driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Kurt Van Dijck
Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver
Date: Wednesday, August 26, 2009 - 3:46 am

Hi Sacha,

I'm using a 2.6.25.
Converting to your platform_device based driver,
I needed to configure the irq (see patch, irq flags).
Looking in the old cs89x0.c, it's done in the driver. Should I have
configured the irq level elsewhere? Or is this patch valid to do?

Kurt

Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
---
Index: drivers/net/cirrus-cs89x0.c
===================================================================
--- drivers/net/cirrus-cs89x0.c	(revision 7107)
+++ drivers/net/cirrus-cs89x0.c	(working copy)
@@ -487,7 +487,8 @@
        }
 
        /* install interrupt handler */
-       result = request_irq(ndev->irq, &cirrus_interrupt, 0, ndev->name, ndev);
+       result = request_irq(ndev->irq, &cirrus_interrupt,
+			IRQF_TRIGGER_HIGH, ndev->name, ndev);
        if (result < 0) {
                printk(KERN_ERR "%s: could not register interrupt %d\n",
                       ndev->name, ndev->irq);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Add new cs89x0 driver, Sascha Hauer, (Wed Apr 22, 12:59 am)
[PATCH 1/2] Add an alternative cs89x0 driver, Sascha Hauer, (Wed Apr 22, 12:59 am)
[PATCH 2/2] mx1ads: Add cs89x0 network support, Sascha Hauer, (Wed Apr 22, 12:59 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Ivo Clarysse, (Wed Apr 22, 2:28 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Gilles Chanteperdrix, (Wed Apr 22, 2:42 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Sascha Hauer, (Wed Apr 22, 5:18 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Sascha Hauer, (Wed Apr 22, 5:20 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Gilles Chanteperdrix, (Wed Apr 22, 5:25 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Sascha Hauer, (Wed Apr 22, 6:05 am)
Re: [PATCH] Add new cs89x0 driver, Lennert Buytenhek, (Wed Apr 22, 3:53 pm)
Re: [PATCH] Add new cs89x0 driver, Sascha Hauer, (Thu Apr 23, 12:03 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Kurt Van Dijck, (Wed Aug 26, 3:46 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Sascha Hauer, (Mon Sep 7, 3:24 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Kurt Van Dijck, (Mon Sep 7, 5:35 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Sascha Hauer, (Mon Sep 7, 6:21 am)
Re: [PATCH 1/2] Add an alternative cs89x0 driver, Kurt Van Dijck, (Fri Oct 16, 2:37 am)
Re: [PATCH] Add new cs89x0 driver, Ben Dooks, (Tue Oct 20, 2:55 am)