TSecr != 0 check in inet_lro.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Octavian Purdila
Date: Monday, August 24, 2009 - 2:54 pm

Hi,

We are seeing a performance issue with TSO/LRO which we tracked down to the 
TSecr !=0 check in lro_tcp_ip_check.

It happens when the LRO side's TSval wraps around and gets to 0. That triggers 
the TSO side to send packets with TSecr set to 0, which means that such 
packets won't be aggregated - and that will put a lot of burden on the stack 
which will result in lots of drops.

I'm failing to understand the purpose of this check. Any hints? :)

Thanks,
tavi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
TSecr != 0 check in inet_lro.c, Octavian Purdila, (Mon Aug 24, 2:54 pm)
Re: TSecr != 0 check in inet_lro.c, Eric Dumazet, (Mon Aug 24, 10:42 pm)
Re: TSecr != 0 check in inet_lro.c, Octavian Purdila, (Tue Aug 25, 4:50 am)
Re: TSecr != 0 check in inet_lro.c, David Miller, (Tue Sep 1, 3:46 pm)