Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Gregory Haskins
Date: Tuesday, August 11, 2009 - 5:06 pm

Michael S. Tsirkin wrote:

Only a quick review for now.  Will look closer later.

(see inline)


This seems odd.  If you have the flush to act as a sync-barrier, why do
you also need rcu_dereference(sock)?  At first blush, it seems
gratuitous.  Can you talk about this aspect of the design in more detail?


Would recommend using DYNAMIC-MINOR.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Tue Aug 11, 2:28 pm)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Gregory Haskins, (Tue Aug 11, 5:06 pm)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Wed Aug 12, 2:02 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Wed Aug 12, 3:52 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Gregory Haskins, (Wed Aug 12, 6:01 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Wed Aug 12, 6:25 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Gregory Haskins, (Wed Aug 12, 6:41 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Wed Aug 12, 6:47 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Paul E. McKenney, (Wed Aug 12, 7:11 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Wed Aug 12, 7:15 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Paul E. McKenney, (Wed Aug 12, 8:26 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Michael S. Tsirkin, (Wed Aug 12, 8:51 am)
Re: [PATCHv2 2/2] vhost_net: a kernel-level virtio server, Paul E. McKenney, (Wed Aug 12, 9:06 am)