linux-netdev mailing list

FromSubjectsort iconDate
Jorge Bastos
Crashes on ppp system
Howdy, I have a machine used for GW at my job, and i have a PPTPD VPN setup on it using poptop, and after updating to 2.6.30 i have crashes on the kernel all the time. Since i don't have the text, i made two pictures with it :P http://neotrix.decimal.pt/dbmail/ppp_1.jpg http://neotrix.decimal.pt/dbmail/ppp_2.jpg As you can see on the pic, i'm using 2.6.31-rc1-git11 now, since 2.6.30 i've tryed several git versions that had some work on the kernel PPP system, and the crash remains. Is there a...
Jul 5, 12:00 pm 2009
Eilon Greenstein
[PATCH 2/2] bnx2x: Fix the maximal values of coalescing time...
This patch properly defines the maximum values for rx/tx coalescing timeouts. Signed-off-by: Vlad Zolotarov <vladz@broadcom.com> Signed-off-by: Eilon Greenstein <eilong@broadcom.com> --- drivers/net/bnx2x.h | 2 ++ drivers/net/bnx2x_main.c | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h index 8678457..85a737c 100644 --- a/drivers/net/bnx2x.h +++ b/drivers/net/bnx2x.h @@ -902,6 +902,8 @@ struct bnx2x ...
Jul 5, 10:18 am 2009
Eilon Greenstein
[PATCH 1/2] bnx2x: Disable HC coalescing when setting timeou...
Problem reported by Flavio Leitner <fleitner@redhat.com>: When setting rx/tx coalescing timeout to the values less than 12 traffic was stopped. The FW supports coalescing in 12us granularity, and so value of less then 12 should be interpreted as disabling coalescing Signed-off-by: Vlad Zolotarov <vladz@broadcom.com> Signed-off-by: Eilon Greenstein <eilong@broadcom.com> --- drivers/net/bnx2x_main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/d...
Jul 5, 10:18 am 2009
аня Jul 5, 4:22 am 2009
Julia Lawall
[PATCH] drivers/net/cs89x0.c: Avoid using magic number in se...
From: Julia Lawall <julia@diku.dk> The constant DMA_RX_MODE is defined to be 0x14 in the local include file cs89x0.h. Since a constant with the same name is used elsewhere with set_dma_mode, it seems likely that this constant could be used here. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E1; identifier I; constant int C; @@ ( set_dma_mode(E1,I,...) | *set_dma_mode(E1,C,...) ) // </smpl> Sig...
Jul 5, 3:23 am 2009
Mike Rapoport
[PATCH v2] dm9000: add checksum offload support
> From: Yeasah Pell <yeasah@comrex.com> Add checksum offload support for DM9000A and DM9000B chips. -- v2 changes: added a local copy of ip_summed to save IO cycles in dm9000_send_packet Signed-off-by: Yeasah Pell <yeasah@comrex.com> Signed-off-by: Mike Rapoport <mike@compulab.co.il> --- drivers/net/dm9000.c | 109 ++++++++++++++++++++++++++++++++++++++++++-------- drivers/net/dm9000.h | 18 ++++++++ 2 files changed, 110 insertions(+), 17 deletions(-) diff --git a/...
Jul 5, 1:40 am 2009
Francois Romieu
Re: [PATCH v2] dm9000: add checksum offload support
Mike Rapoport <mike@compulab.co.il> : trans_start updating is done in core and can be removed. -- Ueimor --
Jul 5, 7:29 am 2009
Herbert Xu
Re: >10% performance degradation since 2.6.18
Not really. For now the best thing to do is to pin everything down and not move at all, because we can't afford to move. The only way for moving to work is if we had the ability to get the sockets to follow the processes. That means, we must have one RX queue per socket. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: [ message continues ]
" title="http://gondor.apana.org.au/~herbert/pu...">http://gondor.apana.org.au/~herbert/pu...
Jul 5, 12:01 am 2009
Jeff Garzik
Re: >10% performance degradation since 2.6.18
Is this a blind guess, or is there real world testing across multiple setups behind this answer? Consider a 2-package, quad-core system with 3 userland threads actively performing network communication, plus periodic, low levels of network activity from OS utilities (such as nightly 'yum upgrade'). That is essentially an under-utilized 8-CPU system. For such a case, it seems like a power win to idle or power down a few cores, or maybe even an entire package. Efficient power usage means...
Jul 5, 4:44 pm 2009
Matthew Wilcox
Re: >10% performance degradation since 2.6.18
Maybe not one RX queue per socket -- sockets belonging to the same thread could share the same RX queue. I'm fairly ignorant of the way networking works these days; is it possible to dynamically reassign a socket between RX queues, so we'd only need one RX queue per CPU? It seems the 82575 device has four queues per port, and it's a dual-port card, so that's eight queues in the system. We'd need hundreds of queues to get one queue per client process. The 82576 has sixteen queues per port, but ...
Jul 5, 9:09 am 2009
Herbert Xu
Re: >10% performance degradation since 2.6.18
Not reliably. You can tweak the hash in the NIC to redirect traffic (aka flow director) but ultimately if you've got more sockets than queues then it's a losing game. A better strategy for now is to pin everything down and try to get user-space involved by using threads and distributing the sockets based on which queue they're associated with. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: [ message continues ]
" title="http://gondor.a...">http://gondor.a...
Jul 5, 12:11 pm 2009
Sarveshwar Bandi
Re: [PATCH] be2net: Implementation of request_firmware inter...
I understand that most drivers use request_firmware() to load volatile firmware. I do see that there are other nic drivers that use this inferface to flash persistent firmware. We have other tools for offline flashing; but there is requirement to flash f/w through driver without having to use other proprietary tools. Since the firmware load happens only when there is a version mismatch with f/w in /lib/firmware, Users who want to avoid automatic flashing at boot time can choose not to copy the ...
Jul 5, 8:16 am 2009
Ben Hutchings
Re: [PATCH] be2net: Implementation of request_firmware inter...
The firmware blob is proprietary and has to be distributed separately from the kernel. So does it really matter that you have to distribute a special tool as well? (Based on requirements specified by major OEMs, I have implemented firmware update through the sfc driver (MDIO and MTD interfaces) but [...] Is there a way of loading the firmware into the controller's RAM but not writing it to flash? That ought to be the default behaviour. Ben. -- Ben Hutchings, Senior Software Engineer, ...
Jul 5, 10:20 am 2009
Herbert Xu
Re: [GIT]: Networking
I don't know about the DMA error but this is perfectly normal. You're invoking netpoll from within the NIC's xmit routine, that's why the trylock fails. So I guess you should fix spinlock debugging instead :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jul 5, 12:09 am 2009
Paweł Staszewski
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
Ok kernel configured with CONFIG_PREEMPT and all this day work without any problems (with Jarek last patch). So in attached file trere is fib_tirestats I dont see any big change of (cpu load or faster/slower routing/propagating routes from bgpd or something else) - in avg there is from 2% to 3% more of CPU load i dont know why but it is - i change from "preempt" to "no preempt" 3 times and check this my "mpstat -P ALL 1 30" always avg cpu load was from 2 to 3% more compared to "no preempt" ...
Jul 4, 8:26 pm 2009
Jarek Poplawski
[PATCH v2 -stable] Re: rib_trie / Fix inflate_threshold_root...
(Take 2: Changelog spelling fixes, sorry.) David & Robert, below are my recommendations for -stable plus one more patch: On Sun, Jul 05, 2009 at 02:26:54AM +0200, Paweł Staszewski wrote: So after these patches from net-2.6 are tested both for PREEMPT and PREEMPT_NONE I think they should go to -stable: 2.6.30 needs: ------------- commit e0f7cb8c8cc6cccce28d2ce39ad8c60d23c3799f Author: Jarek Poplawski <jarkao2@gmail.com> Date: Mon Jun 15 02:31:29 2009 -0700 ipv4: Fix fi...
Jul 5, 9:08 am 2009
Jarek Poplawski
[PATCH -stable] Re: rib_trie / Fix inflate_threshold_root. N...
David & Robert, below are my recommendations for -stable plus one more patch: On Sun, Jul 05, 2009 at 02:26:54AM +0200, Paweł Staszewski wrote: So after these patches from net-2.6 are tested both for PREEMPT and PREEMPT_NONE I think they should go to -stable: 2.6.30 needs: ------------- commit e0f7cb8c8cc6cccce28d2ce39ad8c60d23c3799f Author: Jarek Poplawski <jarkao2@gmail.com> Date: Mon Jun 15 02:31:29 2009 -0700 ipv4: Fix fib_trie rebalancing commit 7b85576d15bf2574b...
Jul 5, 8:56 am 2009
Paweł Staszewski Jul 4, 8:31 pm 2009
Paweł Staszewski
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
Oh I forgot - please Jarek give me patch with sync rcu and i will make test on preempt kernel Thanks Paweł Staszewski --
Jul 4, 8:30 pm 2009
Jarek Poplawski
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
Probably non-preempt kernel might need something like this more, but comparing is always interesting. This patch is based on Paul's suggestion (I hope). Thanks, Jarek P. ---> (synchronize take 7; apply on top of the 2.6.29.x with the last all-in-one patch, or net-2.6) net/ipv4/fib_trie.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index 00a54b2..fce8238 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_tr...
Jul 5, 12:20 pm 2009
Jarek Poplawski
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
Hold on ;-) Here is something even better... Syncing after 128 pages might be still too slow, so here is a higher initial value, 1000, plus you can change this while testing in: /sys/module/fib_trie/parameters/sync_pages It would be interesting to find the lowest acceptable value. Jarek P. ---> (synchronize take 8; apply on top of the 2.6.29.x with the last all-in-one patch, or net-2.6) net/ipv4/fib_trie.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) dif...
Jul 5, 1:32 pm 2009
Paul E. McKenney
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
Looks like a promising approach to me! --
Jul 5, 5:32 pm 2009
Jarek Poplawski
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
Hmm... As a matter of fact, I'm a bit sceptical now: I'm worrying this synchronize_rcu done at the lowest acceptable rate could be actually mostly idle or on the contrary too late. Probably some more complex (per cpu?) accounting would be necessary to really matter here, but on the other hand these problems weren't reported often enough. Thanks, --
Jul 5, 6:23 pm 2009
Paweł Staszewski
Re: [PATCH net-2.6] Re: rib_trie / Fix inflate_threshold_roo...
kernel 2.6.29.5 preempt bgp starts normal and kernel know routes normaly like without patch Here are some fib_triestats cat /proc/net/fib_triestat Basic info: size of leaf: 20 bytes, size of tnode: 36 bytes. Main: Aver depth: 2.44 Max depth: 6 Leaves: 277888 Prefixes: 291399 Internal nodes: 66818 1: 33080 2: 14584 3: 10788 4: 4911 5: 2185 6: 900 7: 366 8: 3 17: 1 Pointers: 595584 Null ptrs: 250879 To...
Jul 5, 7:53 pm 2009
Tziporet Koren
Re: [ofa-general][PATCH 2/2] mlx4: ConnectX multi functional...
This is NOT related to OFED at all. This is our 10G NIC driver. See the description: /* MT26468 ConnectX EN 10GigE, PCIe, 2.0 5Gt/s */ We have several customer that take our 10G driver from kernel.org, and once the HW is out we will have a problem. Also to include this code in next Redhat & Novell updates we need to have it in the kernel too. I know the risk is not zero, but you must admit its not high either, and we already tested it here thoroughly here with all device IDs Since we ...
Jul 5, 4:10 am 2009
Herbert Xu
Re: [PATCH] skbuff: don't corrupt mac_header on skb expansion
What uses skb_mac_header_was_set apart from a debugging printk in route.c and nfnetlink_log (which is also essentially a debugging printk)? This seems to be a bit much just to make a couple printks work? What about using mac_len instead to figure out whether the MAC header is there? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: [ message continues ]
" title="http://gondor.apana.org.au/~h...">http://gondor.apana.org.au/~h...
Jul 4, 11:55 pm 2009
Herbert Xu
Re: [PATCH] ipv6: Keep index within tab_unreach[]
Why not make code unsigned? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jul 4, 11:46 pm 2009
David Miller
Re: [PATCH] ipv6: Keep index within tab_unreach[]
From: Herbert Xu <herbert@gondor.apana.org.au> type and code should both be "u8"'s, we made a similar conversio of a family of ipv6 function arguments recently. Actually, it's already there and done to this very function. Herbert, this is just an ancient patch that has been superceded by the very change you are suggestions :-) --
Jul 5, 6:52 pm 2009
Herbert Xu
Re: QUESTION: can netdev_alloc_skb() errors be reduced by ...
If we're going to do this in the core then we should only do it in the spots where the packet may be held indefinitely. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jul 4, 11:44 pm 2009
Herbert Xu
Re: flow director and packet ordering
Methinks this whole idea is doomed. The fact is as long as there are more sockets than queues, then you can have two sockets pull the same queue in different directions and there's nothing you can do about that. That's my bit of uncertainty for you :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jul 5, 12:19 am 2009
David Miller
Re: flow director and packet ordering
From: Herbert Xu <herbert@gondor.apana.org.au> Flows map to queues, queues don't move. Rather the mapping between flows and queues changes dynamically. --
Jul 5, 6:53 pm 2009
Herbert Xu
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit
Here's a another crazy idea: Let's use dummy TX descriptors to generate an interrupt, either with or without transmitting an actual packet on the wire depending on the NIC. xmit(skb) if (TX queue contains no interrupting descriptor && qdisc is empty) mark TX descriptor as interrupting clean() do work if (TX queue contains no interrupting descriptor && TX queue non-empty && qdisc is empty) send dummy TX descriptor This is based on the ...
Jul 4, 11:26 pm 2009
Herbert Xu
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit
Here's an even crazier idea that doesn't use dummy descriptors. xmit(skb) if (TX queue contains no interrupting descriptor && qdisc is empty) mark TX descriptor as interrupting if (TX queue now contains an interrupting descriptor && qdisc len < 2) stop queue if (TX ring full) stop queue clean() do work wake queue as per usual Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana...
Jul 4, 11:34 pm 2009
Ken Kawasaki
[PATCH] pcnet_cs: add odd location support for write_asic fu...
Signed-off-by: Ken Kawasaki <ken_kawasaki@spring.nifty.jp> --- --- linux-2.6.31-rc1/drivers/net/pcmcia/pcnet_cs.c.orig 2009-06-27 10:15:47.000000000 +0900 +++ linux-2.6.31-rc1/drivers/net/pcmcia/pcnet_cs.c 2009-07-04 10:32:44.000000000 +0900 @@ -886,9 +886,10 @@ static void write_asic(unsigned int ioad outb_p(EE_ASIC|EE_CS|EE_DI|dataval, ee_addr); } // sync - outb(EE_ASIC|EE_CS, ee_addr); - outb(EE_ASIC|EE_CS|EE_CK, ee_addr); - outb(EE_ASIC|EE_CS, ee_addr); + dataval = (locat...
Jul 4, 8:19 pm 2009
Ken Kawasaki
[PATCH] pcnet_cs: add new id
add new id (RIOS System PC CARD3 ETHERNET). Signed-off-by: Ken Kawasaki <ken_kawasaki@spring.nifty.jp> --- --- linux-2.6.31-rc1/drivers/net/pcmcia/pcnet_cs.c.orig 2009-06-27 10:15:47.000000000 +0900 +++ linux-2.6.31-rc1/drivers/net/pcmcia/pcnet_cs.c 2009-07-04 14:19:21.000000000 +0900 @@ -1727,6 +1727,7 @@ static struct pcmcia_device_id pcnet_ids PCMCIA_DEVICE_PROD_ID12("PRETEC", "Ethernet CompactLAN 10BaseT 3.3V", 0xebf91155, 0x7f5a4f50), PCMCIA_DEVICE_PROD_ID12("Psion Dacom", "Gol...
Jul 4, 8:17 pm 2009
Ken Kawasaki
Re: [PATCH] pcnet_cs: add new id
On Tue, 30 Jun 2009 07:19:55 -0700 (PDT) Sorry, I cancel the use_shmem patch. (for re-test). Ken. --
Jul 5, 4:34 am 2009
Eric W. Biederman
Re: [RFC] arp announce, arp_proxy and windows ip conflict ve...
Multiple subnets on an ethernet segment sure. Multiple subnets subnets that don't communicate? Not telling your router about all of the subnets on the ethernet segment? The combination of not configuring the router to know about all of the subnets and enabling proxy arp is what is causing problems for Denys. That sure seems like a misconfiguration to me. Eric --
Jul 4, 8:07 pm 2009
Mark Smith
Re: [RFC] arp announce, arp_proxy and windows ip conflict ve...
On Sat, 04 Jul 2009 17:07:11 -0700 A misconfiguration if you don't intend it, otherwise, isolation between subnets on a common link can be useful. I've taken advantage of it in networking test labs. It can also be useful for basic traffic engineering. You set up two routers attached to the same link, but both with different configured prefixes. Nodes are assigned adresses out of one or the other prefix, to influence which outbound (and inbound) path their traffic takes. Leaving it like that wou...
Jul 5, 2:16 am 2009
Denys Fedoryschenko
Re: [RFC] arp announce, arp_proxy and windows ip conflict ve...
Real example Still a lot of letters, but i hope it will help to understand situation. Big office network. We trust each other and we dont have much money. So unmanaged switches. Network separated to two locations Router in the middle. eth0 - 10.0.0.2/24 eth1 - 10.0.1.1/24 default gateway is 10.0.0.1 arp_proxy enabled on both. Users have on machines netmask /22, so they can communicate freely. DHCP assigning addresses for them. I just install few Windows XP machines in same network, a...
Jul 4, 8:28 pm 2009
previous daytodaynext day
July 4, 2009July 5, 2009July 6, 2009