Stephen Hemminger <shemminger@vyatta.com> wrote:
quoted text
> The skb mac_header field is sometimes NULL (or ~0u) as a sentinel
> value. The places where skb is expanded add an offset which would
> change this flag into an invalid pointer (or offset).
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

What uses skb_mac_header_was_set apart from a debugging printk
in route.c and nfnetlink_log (which is also essentially a debugging
printk)?

This seems to be a bit much just to make a couple printks work?

What about using mac_len instead to figure out whether the MAC
header is there?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html