Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: <rusty@...>, <patrick.ohly@...>, <netdev@...>, <virtualization@...>, <divy@...>, <rolandd@...>, <xemul@...>, <dcbw@...>, <libertas-dev@...>
Date: Saturday, July 4, 2009 - 5:09 am

On Sat, Jul 04, 2009 at 03:42:45PM +0800, Herbert Xu wrote:

Actually it doesn't even matter for routing because only those
that are charged by the skb's or the pages care and they're the
only ones that would need to set this.

One potential problem is if the socket is constantly running
close to capacity, but that should only happen if the device
TX queue is also close to capacity which means that the qdisc
queue should be non-empty.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Fri May 29, 10:14 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Patrick Ohly, (Mon Jun 1, 3:47 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Tue Jun 2, 3:25 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Tue Jun 2, 10:08 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Tue Jun 2, 8:14 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Fri Jul 3, 11:02 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Fri Jul 3, 11:13 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Herbert Xu, (Sat Jul 4, 5:09 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Eric Dumazet, (Fri May 29, 11:11 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Mon Jun 1, 8:27 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Eric Dumazet, (Wed Jun 3, 5:02 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Wed Jun 3, 11:54 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Thu Jun 4, 12:00 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Eric Dumazet, (Thu Jun 4, 12:54 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Thu Jun 4, 12:56 am)