Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <herbert@...>
Cc: <rusty@...>, <patrick.ohly@...>, <netdev@...>, <virtualization@...>, <divy@...>, <rolandd@...>, <xemul@...>, <dcbw@...>, <libertas-dev@...>
Date: Friday, July 3, 2009 - 11:13 pm

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 4 Jul 2009 11:08:30 +0800


NIU

I basically can't defer interrupts because the chip supports
per-TX-desc interrupt indications but it lacks an "all TX queue sent"
event.  So if, say, tell it to interrupt every 1/4 of the TX queue
then up to 1/4 of the queue can have packets "stuck" in there
if TX activity all of a sudden ceases.

The only thing I've come up with to be able to mitigate interrupts is
to use an hrtimer of some sort.  But that's going to be hard to get
right, and who knows what kind of latencies will be introduced for TX
completion packet freeing unless I am very carefull.

And finally this belongs in generic code, not in the NIU driver,
whatever we come up with.  Especially since my understanding is that
this is similar to what Rusty needs.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Fri May 29, 10:14 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Patrick Ohly, (Mon Jun 1, 3:47 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Tue Jun 2, 3:25 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Tue Jun 2, 10:08 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Tue Jun 2, 8:14 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Fri Jul 3, 11:02 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Fri Jul 3, 11:13 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Eric Dumazet, (Fri May 29, 11:11 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Mon Jun 1, 8:27 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Eric Dumazet, (Wed Jun 3, 5:02 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Rusty Russell, (Wed Jun 3, 11:54 pm)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Thu Jun 4, 12:00 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, Eric Dumazet, (Thu Jun 4, 12:54 am)
Re: [PATCH 1/4] net: skb_orphan on dev_hard_start_xmit, David Miller, (Thu Jun 4, 12:56 am)