Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Berg
Date: Thursday, June 4, 2009 - 7:15 am

On Thu, 2009-06-04 at 18:10 +0400, Dmitry Eremin-Solenikov wrote:


There are a whole bunch of improvements possible at this particular
spot:

switch (X) {
case Y:
	if (A) {
		...
	}
	break;
...
}

can be written as

switch (X) {
case Y:
	if (!A)
		break;
	...
	break;
}


and=20

for (...) {
	if (A) {
		...
		break;
	}
}

can be written as

for (...) {
	if (!A)
		continue;
	...
	break;
}

etc.

Show some creativity!

johannes
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][WIP] IEEE 802.15.4 implementation for Linux v1, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 01/10] crc-itu-t: add bit-reversed calculation, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 02/10] Add constants for the ieee 802.15.4/ZigBee stack, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 03/10] net: add IEEE 802.15.4 socket family impleme ..., Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 04/10] net: add NL802154 interface for configuratio ..., Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 05/10] ieee802154: add simple HardMAC driver sample, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 06/10] mac802154: add a software MAC 802.15.4 imple ..., Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 07/10] ieee802154: add virtual loopback driver, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 08/10] tty_io: export tty_class, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 09/10] ieee802154: add serial dongle driver, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
[PATCH 10/10] ieee802154: add at86rf230/rf231 spi driver, Dmitry Eremin-Solenikov, (Mon Jun 1, 7:54 am)
Re: [PATCH 08/10] tty_io: export tty_class, Alan Cox, (Mon Jun 1, 8:07 am)
Re: [PATCH 08/10] tty_io: export tty_class, Dmitry Eremin-Solenikov, (Mon Jun 1, 8:10 am)
Re: [PATCH 08/10] tty_io: export tty_class, Alan Cox, (Mon Jun 1, 8:34 am)
Re: [PATCH 09/10] ieee802154: add serial dongle driver, Dmitry Eremin-Solenikov, (Mon Jun 1, 1:29 pm)
Re: [PATCH 10/10] ieee802154: add at86rf230/rf231 spi driver, Dmitry Eremin-Solenikov, (Mon Jun 1, 1:33 pm)
Ответ: [PATCH 10/10] ieee802154: add at86rf230/, Dmitry Eremin-Solenikov, (Tue Jun 2, 1:29 am)
Re: , Marcel Holtmann, (Tue Jun 2, 1:36 am)
Re: , Florian Fainelli, (Tue Jun 2, 1:46 am)
Re: Ответ: [PATCH 10/10] ieee802154: add at86rf, Maxim Osipov, (Tue Jun 2, 1:49 am)
Re: , Sergey Lapin, (Tue Jun 2, 1:52 am)
Re: , Holger Schurig, (Tue Jun 2, 2:15 am)
Re: , Jonathan Cameron, (Tue Jun 2, 2:29 am)
Re: ?????: [PATCH 10/10] ieee802154: add at86rf230/rf231 s ..., Dmitry Eremin-Solenikov, (Tue Jun 2, 4:42 am)
Re: [PATCH 08/10] tty_io: export tty_class, Dmitry Eremin-Solenikov, (Tue Jun 2, 7:22 am)
Re: [PATCH 08/10] tty_io: export tty_class, Alan Cox, (Tue Jun 2, 7:35 am)
Re: [PATCH 09/10] ieee802154: add serial dongle driver, Sergey Lapin, (Tue Jun 2, 7:43 am)
Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family imp ..., Dmitry Eremin-Solenikov, (Thu Jun 4, 4:16 am)
Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family imp ..., Dmitry Eremin-Solenikov, (Thu Jun 4, 7:10 am)
Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family imp ..., Johannes Berg, (Thu Jun 4, 7:15 am)
Re: [RFC][WIP] IEEE 802.15.4 implementation for Linux v1, Dmitry Eremin-Solenikov, (Thu Jun 4, 9:49 pm)
Re: [RFC][WIP] IEEE 802.15.4 implementation for Linux v1, Maxim Osipov, (Fri Jun 12, 10:37 pm)
Re: [RFC][WIP] IEEE 802.15.4 implementation for Linux v1, Pavel Machek, (Sat Jun 20, 11:40 pm)