Jarek Poplawski wrote:
quoted text
> On Wed, Jun 03, 2009 at 09:53:11AM +0200, Patrick McHardy wrote:
> ...
>> The necessary changes are
>> really trivial, all you need to do when changing the scaling factors
>> is to increase SM_MASK and decrease ISM_MASK accordingly.
> 
> OK, looks like it's really enough and I was confused with some
> rounding, thanks Patrick.

Looks fine in principle, but considering your change to the generic
scaling factors:

quoted text
> -#define PSCHED_US2NS(x)			((s64)(x) << 10)
> -#define PSCHED_NS2US(x)			((x) >> 10)
> +#define PSCHED_US2NS(x)			((s64)(x) << 6)
> +#define PSCHED_NS2US(x)			((x) >> 6)

PSCHED_SHIFT should be 4, right?

quoted text
> +#define	PSCHED_SHIFT	6	/* TODO: move to pkt_sched.h */
> +#define	SM_SHIFT	(30 - PSCHED_SHIFT)
> +#define	ISM_SHIFT	(8 + PSCHED_SHIFT)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html