Re: [PATCH] net: fix race in the receive/select

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Eric Dumazet <eric.dumazet@...>

Cc: David Miller <davem@...>, <davidel@...>, <oleg@...>, <netdev@...>, <linux-kernel@...>, <fbl@...>, <nhorman@...>, <htejun@...>

Subject: Re: [PATCH] net: fix race in the receive/select

Date: Monday, June 29, 2009 - 5:34 am

On Fri, Jun 26, 2009 at 09:35:28PM +0200, Eric Dumazet wrote:
quoted text> David Miller a écrit :
> > From: Davide Libenzi <davidel@xmailserver.org>
> > Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT)
> > 
> >> On Fri, 26 Jun 2009, Oleg Nesterov wrote:
> >>
> >>> Perhaps we can add
> >>>
> >>> 	void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt)
> >>> 	{
> >>> 		if (pt) {
> >>> 			poll_wait(file, sk->sk_sleep, pt);
> >>> 			/*
> >>> 			 * fat comment
> >>> 			 */
> >>> 			smp_mb(); // or smp_mb__after_unlock();
> >>> 		}
> >>> 	}
> >> That'd be fine IMHO. Are DaveM and Eric OK?
> > 
> > No objections from me.
> 
> Very good :)
> 
> Jiri, please respin a patch with this idea from Oleg
> 
> (We'll have to check all calls to poll_wait() in net tree)
> 
> Thanks everybody
>

thanks a lot! :) I'll send out new patch shortly..

I'll include all the poll_wait calls change I'm kind of sure of,
and list of others I'm not, so we can discuss them.

jirka
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] net: fix race in the receive/select, Jiri Olsa, (Thu Jun 25, 8:25 am)

Re: [PATCH] net: fix race in the receive/select, Andi Kleen, (Mon Jun 29, 5:12 am)

Re: [PATCH] net: fix race in the receive/select, Herbert Xu, (Tue Jun 30, 11:39 pm)

Re: [PATCH] net: fix race in the receive/select, Andi Kleen, (Wed Jul 1, 2:27 am)

Re: [PATCH] net: fix race in the receive/select, Herbert Xu, (Wed Jul 1, 3:03 am)

Re: [PATCH] net: fix race in the receive/select, Andi Kleen, (Wed Jul 1, 3:22 am)

Re: [PATCH] net: fix race in the receive/select, Herbert Xu, (Wed Jul 1, 4:31 am)

Re: [PATCH] net: fix race in the receive/select, Jiri Olsa, (Wed Jul 1, 4:44 am)

Re: [PATCH] net: fix race in the receive/select, Herbert Xu, (Wed Jul 1, 6:58 am)

Re: [PATCH] net: fix race in the receive/select, Herbert Xu, (Wed Jul 1, 9:07 am)

Re: [PATCH] net: fix race in the receive/select, Zan Lynx, (Mon Jun 29, 12:59 pm)

Re: [PATCH] net: fix race in the receive/select, Andi Kleen, (Mon Jun 29, 1:29 pm)

Re: [PATCH] net: fix race in the receive/select, Jiri Olsa, (Mon Jun 29, 5:24 am)

Re: [PATCH] net: fix race in the receive/select, Tejun Heo, (Thu Jun 25, 9:50 pm)

Re: [PATCH] net: fix race in the receive/select, Eric Dumazet, (Thu Jun 25, 7:18 pm)

Re: [PATCH] net: fix race in the receive/select, Oleg Nesterov, (Thu Jun 25, 8:24 am)

Re: [PATCH] net: fix race in the receive/select, Davide Libenzi, (Thu Jun 25, 9:31 pm)

Re: [PATCH] net: fix race in the receive/select, Eric Dumazet, (Thu Jun 25, 9:59 pm)

Re: [PATCH] net: fix race in the receive/select, Davide Libenzi, (Thu Jun 25, 10:04 pm)

Re: [PATCH] net: fix race in the receive/select, Eric Dumazet, (Thu Jun 25, 10:19 pm)

Re: [PATCH] net: fix race in the receive/select, Oleg Nesterov, (Fri Jun 26, 9:46 am)

Re: [PATCH] net: fix race in the receive/select, Davide Libenzi, (Thu Jun 25, 11:14 pm)

Re: [PATCH] net: fix race in the receive/select, Oleg Nesterov, (Fri Jun 26, 9:57 am)

Re: [PATCH] net: fix race in the receive/select, Davide Libenzi, (Fri Jun 26, 1:32 pm)

Re: [PATCH] net: fix race in the receive/select, Oleg Nesterov, (Fri Jun 26, 10:50 am)

Re: [PATCH] net: fix race in the receive/select, Jarek Poplawski, (Sun Jun 28, 7:10 am)

Re: [PATCH] net: fix race in the receive/select, Jarek Poplawski, (Sun Jun 28, 7:22 am)

Re: [PATCH] net: fix race in the receive/select, Oleg Nesterov, (Sun Jun 28, 2:04 pm)

Re: [PATCH] net: fix race in the receive/select, Jarek Poplawski, (Sun Jun 28, 5:48 pm)

Re: [PATCH] net: fix race in the receive/select, Jiri Olsa, (Mon Jun 29, 5:27 am)

Re: [PATCH] net: fix race in the receive/select, Davide Libenzi, (Fri Jun 26, 2:12 pm)

Re: [PATCH] net: fix race in the receive/select, David Miller, (Fri Jun 26, 2:17 pm)

Re: [PATCH] net: fix race in the receive/select, Eric Dumazet, (Fri Jun 26, 3:35 pm)

Re: [PATCH] net: fix race in the receive/select, Jiri Olsa, (Mon Jun 29, 5:34 am)

Re: [PATCH] net: fix race in the receive/select, Jarek Poplawski, (Fri Jun 26, 1:42 am)

Re: [PATCH] net: fix race in the receive/select, Jarek Poplawski, (Fri Jun 26, 4:10 am)

Re: [PATCH] net: fix race in the receive/select, David Miller, (Thu Jun 25, 10:11 pm)


linux-kernel:
Glauber de Oliveira Costa	[PATCH 08/79] [PATCH] use identify_boot_cpu
David Woodhouse	[PATCH v2] Stop pmac_zilog from abusing 8250's device numbers.
Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Jeremy Fitzhardinge	[PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).

Re: [PATCH] net: fix race in the receive/select

Online users