Why is there a `select PHYLIB' at the platform level? Shouldn't it be in
drivers/net/Kconfig, near the appropriate network driver? That way people can
build kernels without networking support, if they want.
With kind regards,
Technology and Software Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010
I agree w/you however the initial reason it was:
Author: Kumar Gala <firstname.lastname@example.org>
Date: Wed Jul 16 17:47:54 2008 -0500
powerpc/ep8248e: Unconditionally select PHYLIB for mdio_bitbang
Its possible to build the phylib as a module, however this breaks
board code because alloc_mdio_bitbang and mdiobus_register are not
available if we build as a module. These are needed by the board
since it implements the low level mdio bitbang ops.
So we unconditionally select PHYLIB to ensure its built into the
if we are building in EP8248E support.
Long term we should look at moving the mdio_ops into its own file
can be built as a module.
Signed-off-by: Kumar Gala <email@example.com>
so maybe it should:
select PHYLIB if NET
From: Alexander Beregalov <firstname.lastname@example.org>
This isn't right. Otherwise no networking driver would build
with NET_SCHED disabled.
net/sched/sch_generic.c is always built when NET is enabled
and that's where netif_carrier_off() is defined.
As you can see in net/sched/Makefile, sch_generic.o is
"obj-y", did you even check? :-)