Home » Mailing list archives » linux-netdev » 2009 » May » 20

Re: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules_ops.

Previous thread: [net-next-2.6 PATCH][be2net] remove napi in the tx path and do tx completion processing in interrupt context by Ajit Khaparde on Tuesday, May 19, 2009 - 5:10 am. (6 messages)

Next thread: rfkill vs. interface up by Johannes Berg on Tuesday, May 19, 2009 - 5:32 am. (4 messages)
[view original message]
From: Rami Rosen
Subject: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules_ops.
Date: Tuesday, May 19, 2009 - 5:54 am

Hi,

The netlink message header (struct nlmsghdr) is an unused parameter in
fill method of fib_rules_ops struct.
This patch removes this parameter from this method and fixes the places
where this method is called.

(include/net/fib_rules.h)



Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules_ops.
Date: Tuesday, May 19, 2009 - 3:18 pm

From: Rami Rosen <ramirose@gmail.com>

Please fix up this crazy multi-line tabbing that happened in
these function arg list transformations.

There's also space-tab sequences in here which should be fixed
up too in fact that's how I noticed the multi-line problem:

+ git apply --check --whitespace=error-all diff
diff:35: space before tab in indent.
			    								  struct fib_rule_hdr *frh)
diff:48: space before tab in indent.
			  									struct fib_rule_hdr *frh)
diff:61: space before tab in indent.
			  									struct fib_rule_hdr *frh)
fatal: 3 lines add whitespace errors.


Thanks.
--


[ message continues ]
[view original message]
From: Rami Rosen
Subject: Re: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules_ops.
Date: Tuesday, May 19, 2009 - 11:50 pm

Hi,
This fixes the  for the space-tab sequences  and
multi-line tabbing. Sorry.

The netlink message header (struct nlmsghdr) is an unused parameter in
fill method of fib_rules_ops struct.
This patch removes this parameter from this method and fixes the places
where this method is called.

(include/net/fib_rules.h)



Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@gmail.com>

[ message continues ]
[view original message]
From: Eric Dumazet
Subject: Re: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules_ops.
Date: Tuesday, May 19, 2009 - 11:57 pm

static int fib6_rule_fill(struct fib_rule *rule, struct sk_buff *skb,
-			  struct nlmsghdr *nlh, struct fib_rule_hdr *frh)
+			                    struct fib_rule_hdr *frh)


extra spaces after tabs.... it should be :

 static int fib6_rule_fill(struct fib_rule *rule, struct sk_buff *skb,
-			  struct nlmsghdr *nlh, struct fib_rule_hdr *frh)
+			  struct fib_rule_hdr *frh)




--


[ message continues ]
[view original message]
From: Rami Rosen
Subject: Re: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules_ops.
Date: Wednesday, May 20, 2009 - 4:07 am

Hi,
  Yes, you are right; sorry again!

(running "git apply --check --whitespace=error-all diff"
did not reveal what you mention, but you are right).

I hope that the attached patch is fully correct now.

The netlink message header (struct nlmsghdr) is an unused parameter in
fill method of fib_rules_ops struct.
This patch removes this parameter from this method and fixes the places
where this method is called.

(include/net/fib_rules.h)



Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[ message continues ]
Previous thread: [net-next-2.6 PATCH][be2net] remove napi in the tx path and do tx completion processing in interrupt context by Ajit Khaparde on Tuesday, May 19, 2009 - 5:10 am. (6 messages)

Next thread: rfkill vs. interface up by Johannes Berg on Tuesday, May 19, 2009 - 5:32 am. (4 messages)