Oops in tun: bisected to Limit amount of queued packets per device

Previous thread: [PATCH 2/2] ixgbe: only allow WOL for 82599 KX4 NIC by Jeff Kirsher on Wednesday, April 8, 2009 - 4:20 pm. (4 messages)

Next thread: [patch] error handling for platform_device_register_simple() by Dan Carpenter on Thursday, April 9, 2009 - 12:55 am. (1 message)
From: Christian Borntraeger
Date: Thursday, April 9, 2009 - 12:52 am

Hello Herbert,

with my kvm test scenario on s390 I get the following oops:
Unable to handle kernel pointer dereference at virtual kernel address 0000000400000000
Oops: 003b [#1] SMP
Modules linked in: kvm dm_multipath sunrpc qeth_l2 dm_mod qeth ccwgroup
CPU: 0 Not tainted 2.6.29-kvm-06607-ga317a1e-dirty #8
Process kuli (pid: 14827, task: 00000000b3df8138, ksp: 00000000b4703a98)
Krnl PSW : 0404e00180000000 0000000000171278 (__lock_acquire+0x3d4/0x191c)
           R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 EA:3
Krnl GPRS: 0000000000000001 0000000000000001 0000000000000001 0000000000000001
           0000000000000000 0000000000000000 0000000000000002 0000000000000000
           00000000b3df8138 00000000b3126c30 0000000000000000 00000000bfeb3498
           0000000400000137 0000000000527600 00000000bfeb3590 00000000bfeb3498
Krnl Code: 000000000017126c: a784fe66             brc     8,170f38
           0000000000171270: 41c0c138             la      %r12,312(%r12)
           0000000000171274: a7180001             lhi     %r1,1
          >0000000000171278: 5820c000             l       %r2,0(%r12)
           000000000017127c: 1832                 lr      %r3,%r2
           000000000017127e: 1a31                 ar      %r3,%r1
           0000000000171280: ba23c000             cs      %r2,%r3,0(%r12)
           0000000000171284: a744fffc             brc     4,17127c
Call Trace:
([<0000000000170270>] trace_hardirqs_on+0x2c/0x3c)
 [<0000000000172858>] lock_acquire+0x98/0xc0
 [<000000000051e9c8>] _spin_lock_irqsave+0x64/0xac
 [<0000000000127354>] __wake_up_sync+0x38/0x78
 [<00000000003a3dda>] tun_sock_write_space+0x5e/0xb4
 [<000000000040f924>] sock_wfree+0xb4/0xb8
 [<000000000041487a>] skb_release_head_state+0x82/0x134
 [<0000000000414460>] __kfree_skb+0x2c/0x120
 [<0000000000414660>] kfree_skb+0x88/0xcc
 [<00000000003a3938>] tun_net_xmit+0xbc/0x22c
 [<000000000041fd56>] dev_hard_start_xmit+0x2a6/0x324
 [<00000000004381f8>] __qdisc_run+0x164/0x2a0
 [<000000000042020c>] ...
From: Herbert Xu
Date: Thursday, April 9, 2009 - 2:38 am

This is weird.  It looks like it's dying on the wake_up_interruptible_sync
in tun_sock_write_space.  However, I can't see how that can cause this.

Were you in the middle of removing the tun module?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--

From: Christian Borntraeger
Date: Thursday, April 9, 2009 - 3:39 am

No, I was booting up a guest and the guest sent its first packet (arp). I 
forgot to mention, that the tap device is persistent and attached to a 
bridge. Does that give a clue?

Christian
--

From: Andreas Schwab
Date: Wednesday, April 15, 2009 - 7:30 am

Being persistent appears to make the difference.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--

From: Andreas Schwab
Date: Wednesday, April 22, 2009 - 1:34 pm

Any news on this?  It is still badly broken in 2.6.30-rc3.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--

From: Herbert Xu
Date: Wednesday, April 22, 2009 - 5:17 pm

I think the fixes are in Dave's tree, waiting to be pushed.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--

From: Andreas Schwab
Date: Thursday, April 23, 2009 - 3:08 am

Thanks, I've found them.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--

Previous thread: [PATCH 2/2] ixgbe: only allow WOL for 82599 KX4 NIC by Jeff Kirsher on Wednesday, April 8, 2009 - 4:20 pm. (4 messages)

Next thread: [patch] error handling for platform_device_register_simple() by Dan Carpenter on Thursday, April 9, 2009 - 12:55 am. (1 message)