Re: [PATCH] poll: Avoid extra wakeups in select/poll

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Eric Dumazet <dada1@...>
Cc: Christoph Lameter <cl@...>, linux kernel <linux-kernel@...>, Andi Kleen <andi@...>, David Miller <davem@...>, <jesse.brandeburg@...>, <netdev@...>, <haoki@...>, <mchan@...>, <davidel@...>
Date: Thursday, April 30, 2009 - 7:57 am

* Eric Dumazet <dada1@cosmosbay.com> wrote:


What does "perf stat -l -a sleep 10" show? I suspect your counters 
are scaled by about 67%, due to counter over-commit. -l will show 
the scaling factor (and will scale up the results).

If so then i think this behavior is confusing, and i'll make -l 
default-enabled. (in fact i just committed this change to latest 
-tip and pushed it out)

To get only instructions and cycles, do:

   perf stat -e instructions -e cycles


Hm, that would be a bug. Could you send the dmesg output of:

   echo p > /proc/sysrq-trigger 
   echo p > /proc/sysrq-trigger 

with counters running it will show something like:

[  868.105712] SysRq : Show Regs
[  868.106544] 
[  868.106544] CPU#1: ctrl:       ffffffffffffffff
[  868.106544] CPU#1: status:     0000000000000000
[  868.106544] CPU#1: overflow:   0000000000000000
[  868.106544] CPU#1: fixed:      0000000000000000
[  868.106544] CPU#1: used:       0000000000000000
[  868.106544] CPU#1:   gen-PMC0 ctrl:  00000000001300c0
[  868.106544] CPU#1:   gen-PMC0 count: 000000ffee889194
[  868.106544] CPU#1:   gen-PMC0 left:  0000000011e1791a
[  868.106544] CPU#1:   gen-PMC1 ctrl:  000000000013003c
[  868.106544] CPU#1:   gen-PMC1 count: 000000ffd2542438
[  868.106544] CPU#1:   gen-PMC1 left:  000000002dd17a8e

the counts should stay put (i.e. all counters should be disabled). 
If they move around - despite there being no 'perf stat -a' session 
running, that would be a bug.

Also, the overhead might be profile-able, via:

	perf record -m 1024 sleep 10

(this records the profile into output.perf.)

followed by:

	./perf-report | tail -20

to display a histogram, with kernel-space and user-space symbols 
mixed into a single profile.

(Pick up latest -tip to get perf-report built by default.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
udp ping pong with various process bindings (and correct cpu..., Christoph Lameter, (Fri Apr 24, 4:10 pm)
[PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Sun Apr 26, 6:46 am)
Re: [PATCH] poll: Avoid extra wakeups, Andi Kleen, (Tue Apr 28, 10:21 am)
[PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 11:06 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 5:16 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 5:36 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 6:27 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 8:29 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Davide Libenzi, (Wed Apr 29, 11:53 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 9:07 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Andrew Morton, (Wed Apr 29, 3:20 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 3:39 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 4:26 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Andi Kleen, (Wed Apr 29, 3:35 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 5:22 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 3:37 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 3:05 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 4:05 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 4:14 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 4:33 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 4:49 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 5:04 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 5:11 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 5:11 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Thu Apr 30, 6:49 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Thu Apr 30, 7:57 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Thu Apr 30, 10:08 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Paul E. McKenney, (Thu Apr 30, 5:24 pm)
[BUG] perf_counter: change cpu frequencies , Eric Dumazet, (Thu Apr 30, 12:07 pm)
Re: [BUG] perf_counter: change cpu frequencies, Eric Dumazet, (Sun May 3, 2:06 am)
Re: [BUG] perf_counter: change cpu frequencies, Ingo Molnar, (Sun May 3, 3:25 am)
Re: [BUG] perf_counter: change cpu frequencies, Eric Dumazet, (Mon May 4, 6:39 am)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 5:00 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 5:05 pm)
Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 5:04 pm)
Re: [PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Tue Apr 28, 10:58 am)
Re: [PATCH] poll: Avoid extra wakeups, David Miller, (Tue Apr 28, 5:15 am)
Re: [PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Tue Apr 28, 5:24 am)
Re: [PATCH] poll: Avoid extra wakeups, Jarek Poplawski, (Sun Apr 26, 9:33 am)
Re: [PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Sun Apr 26, 10:27 am)