Re: [PATCH] poll: Avoid extra wakeups in select/poll

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Eric Dumazet <dada1@...>

Cc: linux kernel <linux-kernel@...>, Andi Kleen <andi@...>, David Miller <davem@...>, <cl@...>, <jesse.brandeburg@...>, <netdev@...>, <haoki@...>, <mchan@...>, <davidel@...>

Subject: Re: [PATCH] poll: Avoid extra wakeups in select/poll

Date: Wednesday, April 29, 2009 - 9:07 am

* Eric Dumazet <dada1@cosmosbay.com> wrote:

quoted text> > should be inline perhaps?
> 
> Well, I thought current practice was not using inline for such 
> trivial functions, as gcc already inlines them anyway.

ok.

how about:

quoted text> > [ I'd still suggest to factor out the guts of do_select() as 
> >   its nesting is excessive that hurts its reviewability quite a 
> >   bit - but now your patch does not make the situation any 
> >   worse. ]

We tend to shop for drive-by cleanups in visibly ugly code whenever 
someone wants to touch that code. Could go into a separate patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

udp ping pong with various process bindings (and correct cpu..., Christoph Lameter, (Fri Apr 24, 4:10 pm)

[PATCH] net: Avoid extra wakeups of threads blocked in wait_..., Eric Dumazet, (Sat Apr 25, 11:47 am)

Re: [PATCH] net: Avoid extra wakeups of threads blocked in w..., David Miller, (Tue Apr 28, 5:26 am)

Re: [PATCH] net: Avoid extra wakeups of threads blocked in w..., David Miller, (Sun Apr 26, 5:04 am)

[PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Sun Apr 26, 6:46 am)

Re: [PATCH] poll: Avoid extra wakeups, Andi Kleen, (Tue Apr 28, 10:21 am)

[PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 11:06 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 5:16 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 5:36 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 6:27 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 8:29 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Davide Libenzi, (Wed Apr 29, 11:53 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 9:07 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Andrew Morton, (Wed Apr 29, 3:20 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 3:39 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 4:26 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Andi Kleen, (Wed Apr 29, 3:35 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 5:22 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Wed Apr 29, 3:37 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 3:05 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 4:05 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 4:14 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 4:33 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 4:49 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 5:04 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 5:11 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Wed Apr 29, 5:11 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Thu Apr 30, 6:49 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Ingo Molnar, (Thu Apr 30, 7:57 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Thu Apr 30, 10:08 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Paul E. McKenney, (Thu Apr 30, 5:24 pm)

[BUG] perf_counter: change cpu frequencies , Eric Dumazet, (Thu Apr 30, 12:07 pm)

Re: [BUG] perf_counter: change cpu frequencies, Eric Dumazet, (Sun May 3, 2:06 am)

Re: [BUG] perf_counter: change cpu frequencies, Ingo Molnar, (Sun May 3, 3:25 am)

Re: [BUG] perf_counter: change cpu frequencies, Eric Dumazet, (Mon May 4, 6:39 am)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 5:00 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Eric Dumazet, (Tue Apr 28, 5:05 pm)

Re: [PATCH] poll: Avoid extra wakeups in select/poll, Christoph Lameter, (Tue Apr 28, 5:04 pm)

Re: [PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Tue Apr 28, 10:58 am)

Re: [PATCH] poll: Avoid extra wakeups, David Miller, (Tue Apr 28, 5:15 am)

Re: [PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Tue Apr 28, 5:24 am)

Re: [PATCH] poll: Avoid extra wakeups, Jarek Poplawski, (Sun Apr 26, 9:33 am)

Re: [PATCH] poll: Avoid extra wakeups, Eric Dumazet, (Sun Apr 26, 10:27 am)

Re: udp ping pong with various process bindings (and correct..., Eric Dumazet, (Fri Apr 24, 5:18 pm)

Navigation

Popular discussions


linux-kernel:
David Miller	Re: Slow DOWN, please!!!
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Greg KH	Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Josip Rodin	bnx2_poll panicking kernel
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc:

Colocation donated by:

Online users

Syndicate