[PATCH 1/2] mlx4_en: Fix cleanup flow on cq activation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yevgeny Petrilin
Date: Sunday, April 26, 2009 - 11:41 pm

In case of mlx4_en_activate_cq() failure, the cleanup
code would go to rx_err and try to disable unactivated rings.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
---
 drivers/net/mlx4/en_netdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c
index 438678a..7bcc49d 100644
--- a/drivers/net/mlx4/en_netdev.c
+++ b/drivers/net/mlx4/en_netdev.c
@@ -583,7 +583,7 @@ int mlx4_en_start_port(struct net_device *dev)
 		err = mlx4_en_activate_cq(priv, cq);
 		if (err) {
 			mlx4_err(mdev, "Failed activating Rx CQ\n");
-			goto rx_err;
+			goto cq_err;
 		}
 		for (j = 0; j < cq->size; j++)
 			cq->buf[j].owner_sr_opcode = MLX4_CQE_OWNER_MASK;
--


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 2/5]mlx4_en: Fix a race at restart task, Yevgeny Petrilin, (Mon Apr 20, 7:26 am)
[PATCH 3/5] mlx4_en: Assign dummy event handler for TX queue, Yevgeny Petrilin, (Mon Apr 20, 7:30 am)
Re: [PATCH 2/5]mlx4_en: Fix a race at restart task, David Miller, (Tue Apr 21, 1:49 am)
[PATCH 1/2] mlx4_en: Fix cleanup flow on cq activation, Yevgeny Petrilin, (Sun Apr 26, 11:41 pm)
[PATCH 2/2] mlx4_en: Handle page allocation failure during ..., Yevgeny Petrilin, (Sun Apr 26, 11:42 pm)
[PATCH] mlx4_en: Fix not deleted napi structures, Yevgeny Petrilin, (Wed May 13, 4:47 am)
Re: [PATCH] mlx4_en: Fix not deleted napi structures, David Miller, (Sun May 17, 8:49 pm)
[PATCH 1/2] mlx4_en: Removed redundant stride variable, Yevgeny Petrilin, (Sun May 24, 6:16 am)
[PATCH 2/2] mlx4_en: Fix partial rings feature, Yevgeny Petrilin, (Sun May 24, 6:17 am)
Re: [PATCH 2/2] mlx4_en: Fix partial rings feature, David Miller, (Mon May 25, 12:36 am)
Re: [net-2.6 PATCH] mlx4_en: Fix a kernel panic when wakin ..., Yevgeny Petrilin, (Mon May 25, 11:49 pm)
[net-2.6 PATCH V2] mlx4_en: Fix a kernel panic when waking ..., Yevgeny Petrilin, (Mon May 25, 11:57 pm)
Re: [net-2.6 PATCH V2] mlx4_en: Fix a kernel panic when wa ..., Yevgeny Petrilin, (Tue May 26, 11:08 pm)
[PATCH 1/8] mlx4_en: Giving interface name in debug messages, Yevgeny Petrilin, (Mon Jun 1, 11:27 pm)
[PATCH 3/8] mlx4_en renamed en_params.c to en_ethtool.c, Yevgeny Petrilin, (Tue Jun 2, 2:21 am)
[PATCH 4/8] mlx4_en: Work with part of the ports., Yevgeny Petrilin, (Tue Jun 2, 2:22 am)
[PATCH 6/8] mlx4_en: multiqueue support, Yevgeny Petrilin, (Tue Jun 2, 2:24 am)
[PATCH 7/8] mlx4_en: Added vlan_features support, Yevgeny Petrilin, (Tue Jun 2, 2:28 am)
[PATCH 8/8] mlx4_en: Updated driver version, Yevgeny Petrilin, (Tue Jun 2, 2:29 am)
Re: [PATCH 8/8] mlx4_en: Updated driver version, David Miller, (Tue Jun 2, 2:36 am)