Good catch! This patch looks good.

Thanks,
Ram
quoted text
> -----Original Message-----
> From: Alexander Beregalov [mailto:a.beregalov@gmail.com]
> Sent: Thursday, April 23, 2009 6:32 PM
> To: Ramkrishna Vepa; netdev@vger.kernel.org
> Cc: Alexander Beregalov
> Subject: [PATCH] vxge: fix possible NULL dereference in vxge-traffic.c
> 
> If vpath is NULL then hldev is NULL also.
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
>  drivers/net/vxge/vxge-traffic.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-
> traffic.c
> index 7be0ae1..506625b 100644
> --- a/drivers/net/vxge/vxge-traffic.c
> +++ b/drivers/net/vxge/vxge-traffic.c
> @@ -1923,7 +1923,7 @@ enum vxge_hw_status
__vxge_hw_vpath_alarm_process(
quoted text
>  	if (vpath == NULL) {
>  		alarm_event = VXGE_HW_SET_LEVEL(VXGE_HW_EVENT_UNKNOWN,
>  			alarm_event);
> -		goto out;
> +		goto out2;
>  	}
> 
>  	hldev = vpath->hldev;
> @@ -2161,7 +2161,7 @@ enum vxge_hw_status
__vxge_hw_vpath_alarm_process(
quoted text
>  	}
>  out:
>  	hldev->stats.sw_dev_err_stats.vpath_alarms++;
> -
> +out2:
>  	if ((alarm_event == VXGE_HW_EVENT_ALARM_CLEARED) ||
>  		(alarm_event == VXGE_HW_EVENT_UNKNOWN))
>  		return VXGE_HW_OK;
> --
> 1.6.2.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html