Re: [RFC] percpu: convert SNMP mibs to new infra

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rusty Russell
Date: Wednesday, April 1, 2009 - 10:04 pm

On Thursday 02 April 2009 05:14:47 Eric Dumazet wrote:

OK, I have a whole heap of "convert to dynamic per-cpu" patches waiting in
the wings too, once Tejun's conversion is complete.

Also, what is optimal depends on the arch: we had a long discussion on this
(it's what local_t was supposed to do, with cpu_local_inc() etc: see
Subject: local_add_return 2008-12-16 thread).

eg. on S/390, atomic_inc is a win over the two-counter version.  On Sparc,
two-counter wins.  On x86, inc wins (obviously).

But efforts to create a single primitive have been problematic: maybe
open-coding it like this is the Right Thing.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] x86: percpu_to_op() misses memory and flags cl ..., Jeremy Fitzhardinge, (Wed Apr 1, 2:02 am)
Re: [PATCH] x86: percpu_to_op() misses memory and flags cl ..., Jeremy Fitzhardinge, (Wed Apr 1, 9:41 am)
Re: [PATCH] x86: percpu_to_op() misses memory and flags cl ..., Jeremy Fitzhardinge, (Wed Apr 1, 11:07 am)
[RFC] percpu: convert SNMP mibs to new infra, Eric Dumazet, (Wed Apr 1, 11:44 am)
Re: [RFC] percpu: convert SNMP mibs to new infra, Tejun Heo, (Wed Apr 1, 5:13 pm)
Re: [RFC] percpu: convert SNMP mibs to new infra, Ingo Molnar, (Wed Apr 1, 9:05 pm)
Re: [RFC] percpu: convert SNMP mibs to new infra, Rusty Russell, (Wed Apr 1, 10:04 pm)
Re: [RFC] percpu: convert SNMP mibs to new infra, Eric Dumazet, (Wed Apr 1, 10:19 pm)
[PATCH] percpu: convert SNMP mibs to new infra, Eric Dumazet, (Thu Apr 2, 1:07 am)
Re: [RFC] percpu: convert SNMP mibs to new infra, Rusty Russell, (Thu Apr 2, 4:46 am)
Re: [PATCH] x86: percpu_to_op() misses memory and flags cl ..., Jeremy Fitzhardinge, (Thu Apr 2, 7:12 am)
Re: [PATCH] percpu: convert SNMP mibs to new infra, Ingo Molnar, (Fri Apr 3, 10:10 am)