>On Thursday, April 16, 2009 Andrew Morton wrote:
quoted text
>
>(cc netdev)
>
>On Thu, 16 Apr 2009 23:05:00 +0200
>Roel Kluin <roel.kluin@gmail.com> wrote:
>
>> `!' has a higher precedence than `&'
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
>> index febde45..49a9037 100644
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -3946,7 +3946,7 @@ static void ixgbe_sfp_config_module_task(struct
>work_struct *work)
>>  	}
>>  	hw->mac.ops.setup_sfp(hw);
>>
>> -	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)
>> +	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))
>>  		/* This will also work for DA Twinax connections */
>>  		schedule_work(&adapter->multispeed_fiber_task);
>>  	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;
>
>This is fixed in linux-next, but hasn't been pushed to Linus yet.

Yes, Dave has this fix in his net-next-2.6 tree.

Dave - Can we pull this fix into net-2.6?

Cheers,
Jeff

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html