[PATCH] pci: fix kexec with power state D3

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Sunday, March 8, 2009 - 1:09 am

Impact: second kernel by kexec will have some pci devices working

Found one system with 82575EB, in the kernel that is kexeced, probe igb
failed with -2.

it looks like the same behavior happened on forcedeth.
try to check system_state to make sure if put it on D3

Jesse Brandeburg said that we should do that check in core code instead of
every device driver.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 drivers/pci/pci.c |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Index: linux-2.6/drivers/pci/pci.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci.c
+++ linux-2.6/drivers/pci/pci.c
@@ -593,6 +593,14 @@ int pci_set_power_state(struct pci_dev *
 	if (state == PCI_D3hot && (dev->dev_flags & PCI_DEV_FLAGS_NO_D3))
 		return 0;
 
+	/*
+	 * Apparently it is not possible to reinitialise from D3 hot,
+	 * only put the device into D3 if we really go for poweroff.
+	 */
+	if (system_state != SYSTEM_POWER_OFF &&
+	    (state == PCI_D3hot || state == PCI_D3cold))
+		return 0;
+
 	error = pci_raw_set_power_state(dev, state, true);
 
 	if (state > PCI_D0 && platform_pci_power_manageable(dev)) {
@@ -1124,6 +1132,15 @@ int pci_enable_wake(struct pci_dev *dev,
 	int error = 0;
 	bool pme_done = false;
 
+	/*
+	 * Apparently it is not possible to reinitialise from D3 hot,
+	 * only put the device into D3 if we really go for poweroff.
+	 * we only need to enable wake when we are going to power off
+	 */
+	if (enable && system_state != SYSTEM_POWER_OFF &&
+	    (state == PCI_D3hot || state == PCI_D3cold))
+		return 0;
+
 	if (enable && !device_may_wakeup(&dev->dev))
 		return -EINVAL;
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] igb: fix kexec with igb, Yinghai Lu, (Fri Mar 6, 9:33 pm)
Re: [PATCH] igb: fix kexec with igb, Jesse Brandeburg, (Sat Mar 7, 12:18 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sat Mar 7, 12:31 am)
Re: [PATCH] igb: fix kexec with igb, Eric W. Biederman, (Sat Mar 7, 11:20 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sat Mar 7, 11:50 am)
[PATCH] pci: fix kexec with power state D3, Yinghai Lu, (Sun Mar 8, 1:09 am)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Sun Mar 8, 3:08 am)
Re: [PATCH] pci: fix kexec with power state D3, Ingo Molnar, (Sun Mar 8, 3:15 am)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Sun Mar 8, 3:28 am)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Sun Mar 8, 3:33 am)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 3:45 am)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 3:57 am)
Re: [PATCH] pci: fix kexec with power state D3, Ingo Molnar, (Sun Mar 8, 4:08 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 11:03 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 11:10 am)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 2:08 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 2:18 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 2:32 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 2:40 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 3:35 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 3:57 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 4:04 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 4:57 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Wed Mar 11, 4:37 pm)
Re: [PATCH] pci: fix kexec with power state D3, Jesse Barnes, (Thu Mar 19, 6:49 pm)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Fri Mar 20, 4:29 am)
[Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sat Mar 21, 3:04 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sat Mar 28, 2:27 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Jeff Kirsher, (Sat Mar 28, 7:30 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 29, 4:19 am)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Jeff Kirsher, (Mon Mar 30, 2:36 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Mon Mar 30, 2:39 pm)
RE: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Tantilov, Emil S, (Tue Mar 31, 12:14 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Jeff Kirsher, (Tue Mar 31, 12:51 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Tue Mar 31, 1:27 pm)