[PATCH] igb: fix kexec with igb

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Friday, March 6, 2009 - 9:33 pm

Impact: could probe igb

Found one system with 82575EB, in the kernel that is kexeced, probe igb
failed with -2.

it looks like the same behavior happened on forcedeth.

try to check system_state to make sure if put it on D3

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 drivers/net/igb/igb_main.c |   19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

Index: linux-2.6/drivers/net/igb/igb_main.c
===================================================================
--- linux-2.6.orig/drivers/net/igb/igb_main.c
+++ linux-2.6/drivers/net/igb/igb_main.c
@@ -4358,14 +4358,22 @@ static int igb_suspend(struct pci_dev *p
 		wr32(E1000_WUFC, 0);
 	}
 
+	/*
+	 * Apparently it is not possible to reinitialise from D3 hot,
+	 * only put the device into D3 if we really go for poweroff.
+	 */
 	/* make sure adapter isn't asleep if manageability/wol is enabled */
 	if (wufc || adapter->en_mng_pt) {
-		pci_enable_wake(pdev, PCI_D3hot, 1);
-		pci_enable_wake(pdev, PCI_D3cold, 1);
+		if (system_state == SYSTEM_POWER_OFF) {
+			pci_enable_wake(pdev, PCI_D3hot, 1);
+			pci_enable_wake(pdev, PCI_D3cold, 1);
+		}
 	} else {
 		igb_shutdown_fiber_serdes_link_82575(hw);
-		pci_enable_wake(pdev, PCI_D3hot, 0);
-		pci_enable_wake(pdev, PCI_D3cold, 0);
+		if (system_state == SYSTEM_POWER_OFF) {
+			pci_enable_wake(pdev, PCI_D3hot, 0);
+			pci_enable_wake(pdev, PCI_D3cold, 0);
+		}
 	}
 
 	/* Release control of h/w to f/w.  If f/w is AMT enabled, this
@@ -4374,7 +4382,8 @@ static int igb_suspend(struct pci_dev *p
 
 	pci_disable_device(pdev);
 
-	pci_set_power_state(pdev, pci_choose_state(pdev, state));
+	if (system_state == SYSTEM_POWER_OFF)
+		pci_set_power_state(pdev, pci_choose_state(pdev, state));
 
 	return 0;
 }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] igb: fix kexec with igb, Yinghai Lu, (Fri Mar 6, 9:33 pm)
Re: [PATCH] igb: fix kexec with igb, Jesse Brandeburg, (Sat Mar 7, 12:18 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sat Mar 7, 12:31 am)
Re: [PATCH] igb: fix kexec with igb, Eric W. Biederman, (Sat Mar 7, 11:20 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sat Mar 7, 11:50 am)
[PATCH] pci: fix kexec with power state D3, Yinghai Lu, (Sun Mar 8, 1:09 am)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Sun Mar 8, 3:08 am)
Re: [PATCH] pci: fix kexec with power state D3, Ingo Molnar, (Sun Mar 8, 3:15 am)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Sun Mar 8, 3:28 am)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Sun Mar 8, 3:33 am)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 3:45 am)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 3:57 am)
Re: [PATCH] pci: fix kexec with power state D3, Ingo Molnar, (Sun Mar 8, 4:08 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 11:03 am)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 11:10 am)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 2:08 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 2:18 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 2:32 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 2:40 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 3:35 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 3:57 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Sun Mar 8, 4:04 pm)
Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 8, 4:57 pm)
Re: [PATCH] igb: fix kexec with igb, Yinghai Lu, (Wed Mar 11, 4:37 pm)
Re: [PATCH] pci: fix kexec with power state D3, Jesse Barnes, (Thu Mar 19, 6:49 pm)
Re: [PATCH] pci: fix kexec with power state D3, Rafael J. Wysocki, (Fri Mar 20, 4:29 am)
[Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sat Mar 21, 3:04 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sat Mar 28, 2:27 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Jeff Kirsher, (Sat Mar 28, 7:30 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Sun Mar 29, 4:19 am)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Jeff Kirsher, (Mon Mar 30, 2:36 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Mon Mar 30, 2:39 pm)
RE: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Tantilov, Emil S, (Tue Mar 31, 12:14 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Jeff Kirsher, (Tue Mar 31, 12:51 pm)
Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb, Rafael J. Wysocki, (Tue Mar 31, 1:27 pm)