Home » Mailing list archives » linux-netdev » 2009 » March » 4

Re: [PATCH 01/14] tg3: Fix 5906 link problems

Previous thread: [PATCH 05/14] tg3: Eliminate nvram routine forward declarations by Matt Carlson on Wednesday, February 25, 2009 - 5:24 pm. (1 message)

Next thread: [PATCH 04/14] tg3: Refine tg3_vlan_rx_register() by Matt Carlson on Wednesday, February 25, 2009 - 5:23 pm. (1 message)
[view original message]
From: Matt Carlson
Subject: [PATCH 01/14] tg3: Fix 5906 link problems
Date: Wednesday, February 25, 2009 - 5:21 pm

Commit 6833c043f9fc03696fde623914c4a0277df2a0bc introduced the phy
auto-powerdown capability.  While the APD feature only works for 5761
and 5784 asic revisions, the (harmless portion of the) code was applied
to all 5705 and newer devices.  However, the 5906 phy departs from the
usual design.  This commit was interfering with the 5906's ability to
negotiate link against some switches.  This patch corrects the problem.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
 drivers/net/tg3.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 67630fb..c7bbbb1 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -1473,7 +1473,8 @@ static void tg3_phy_toggle_apd(struct tg3 *tp, bool enable)
 {
 	u32 reg;
 
-	if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
+	if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ||
+	    GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
 		return;
 
 	reg = MII_TG3_MISC_SHDW_WREN |
-- 
1.6.0.6


--


[ message continues ]
[view original message]
From: Matt Carlson
Subject: Re: [PATCH 01/14] tg3: Fix 5906 link problems
Date: Tuesday, March 3, 2009 - 1:17 pm

Hi David.  Can we also apply this patch into net-2.6?  It fixes a
regression that was introduced during the 2.6.29 development cycle.


--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH 01/14] tg3: Fix 5906 link problems
Date: Wednesday, March 4, 2009 - 4:08 pm

From: "Matt Carlson" <mcarlson@broadcom.com>

Sure, I'll queue it up to net-2.6
--


[ message continues ]
Previous thread: [PATCH 05/14] tg3: Eliminate nvram routine forward declarations by Matt Carlson on Wednesday, February 25, 2009 - 5:24 pm. (1 message)

Next thread: [PATCH 04/14] tg3: Refine tg3_vlan_rx_register() by Matt Carlson on Wednesday, February 25, 2009 - 5:23 pm. (1 message)