Home » Mailing list archives » linux-netdev » 2009 » March » 4

Re: [PATCH] sungem: another error printed one too early

Previous thread: [PATCH] netxen: only half timeout waited by Roel Kluin on Monday, February 16, 2009 - 6:55 am. (3 messages)

Next thread: ATM DEBIT CARD by ATM CARD CENTER on Monday, February 16, 2009 - 7:22 am. (1 message)
[view original message]
From: Roel Kluin
Subject: [PATCH] sungem: another error printed one too early
Date: Monday, February 16, 2009 - 7:02 am

Another error was printed one too early.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 4918763..8d64b1d 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1157,7 +1157,7 @@ static void gem_pcs_reset(struct gem *gp)
 		if (limit-- <= 0)
 			break;
 	}
-	if (limit <= 0)
+	if (limit < 0)
 		printk(KERN_WARNING "%s: PCS reset bit would not clear.\n",
 		       gp->dev->name);
 }
--


[ message continues ]
[view original message]
From: Roel Kluin
Subject: Re: [PATCH] sungem: another error printed one too early
Date: Thursday, February 26, 2009 - 5:55 am

I am not sure why my script didn't report this earlier.
-----------------------------------------------------
Another error was printed one too early.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sungem.c b/drivers/net/sungem.c
index 8d64b1d..0fcb750 100644
--- a/drivers/net/sungem.c
+++ b/drivers/net/sungem.c
@@ -1229,7 +1229,7 @@ static void gem_reset(struct gem *gp)
 			break;
 	} while (val & (GREG_SWRST_TXRST | GREG_SWRST_RXRST));
 
-	if (limit <= 0)
+	if (limit < 0)
 		printk(KERN_ERR "%s: SW reset is ghetto.\n", gp->dev->name);
 
 	if (gp->phy_type == phy_serialink || gp->phy_type == phy_serdes)
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] sungem: another error printed one too early
Date: Wednesday, March 4, 2009 - 1:08 am

From: Roel Kluin <roel.kluin@gmail.com>

Applied, thanks.
--


[ message continues ]
Previous thread: [PATCH] netxen: only half timeout waited by Roel Kluin on Monday, February 16, 2009 - 6:55 am. (3 messages)

Next thread: ATM DEBIT CARD by ATM CARD CENTER on Monday, February 16, 2009 - 7:22 am. (1 message)