| From | Subject | Date |
|---|---|---|
| Stephen Hemminger | Re: [PATCH] PCI: Fix oops in pci_vpd_truncate
On Wed, 1 Apr 2009 02:23:41 +0400
If you are doing this you will never get sky2 vpd pci access,
but that is not a big loss. I worry that other thing could break if
devices are getting initialized before sysfs. Drivers that create sysfs
entries (like the 10G drivers) could also break?
But this is okay as a provisional step, the sysfs startup order
needs to be fixed.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
| Mar 31, 3:53 pm 2009 |
| Andy Grover | Re: [PATCH] rds: only for x86 or 64-bit at the moment...
Ok... I'll redo the latest rds patchseries with crit fixes only and a
fix for this.
Regards -- Andy
--
| Mar 31, 4:58 pm 2009 |
| David Miller | Re: [PATCH] rds: only for x86 or 64-bit at the moment...
From: Kyle McMartin <kyle@mcmartin.ca>
I would prefer the RDS folks simply fix this properly.
--
| Mar 31, 2:15 pm 2009 |
| David Miller | Re: [PATCH] rds: only for x86 or 64-bit at the moment...
From: Andy Grover <andy.grover@oracle.com>
Thanks a lot Andy.
--
| Mar 31, 4:59 pm 2009 |
| Kyle McMartin | [PATCH] rds: only for x86 or 64-bit at the moment...
From: Kyle McMartin <kyle@redhat.com>
set_64bit doesn't exist anywhere but x86 right now, so either
BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
build this module.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 796773b..84df275 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -1,7 +1,7 @@
config RDS
tristate "Reliable Datagram Sockets (RDS) (EXPERIMENTAL)"
- depends on INET && INFINIBAND_IPOIB && ...
| Mar 31, 2:06 pm 2009 |
| David Miller | Re: [PATCH] staging: at76_usb convert to netdev_ops
From: Kyle McMartin <kyle@mcmartin.ca>
Acked-by: David S. Miller <davem@davemloft.net>
--
| Mar 31, 2:11 pm 2009 |
| Kyle McMartin | [PATCH] staging: at76_usb convert to netdev_ops
From: Kyle McMartin <kyle@redhat.com>
Didn't see this in your patch queue, fixes build on Fedora, though we'll
probably end up turning on CONFIG_COMPAT_NET_DEV_OPS for now anyway.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
diff --git a/drivers/staging/at76_usb/at76_usb.c b/drivers/staging/at76_usb/at76_usb.c
index c8e4d31..59071e6 100644
--- a/drivers/staging/at76_usb/at76_usb.c
+++ b/drivers/staging/at76_usb/at76_usb.c
@@ -5259,6 +5259,18 @@ static int at76_alloc_urbs(struct ...
| Mar 31, 1:18 pm 2009 |
| Ben Hutchings | [PATCH] sfc: Call netif_napi_add() before registering ou ...
If we use a shared legacy IRQ then our interrupt handler may be called
as soon as it is registered even though IRQs are disabled on the NIC.
Now that the legacy interrupt handler also checks for event delivery,
it may decide to schedule polling in this case. Ensure that the NAPI
context is valid but disabled at this point.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
Please apply this to net-2.6; the bug it fixes is much easier to hit
following commit ...
| Mar 31, 12:07 pm 2009 |
| David Miller | Re: [PATCH] sfc: Call netif_napi_add() before registerin ...
From: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks.
--
| Mar 31, 3:07 pm 2009 |
| Anton Vorontsov | [PATCH] ucc_geth: Pass proper device to DMA routines, ot ...
The driver should pass a device that actually specifies internal DMA
ops, but currently it passes netdev's device, which is wrong and that
causes following oops:
Kernel BUG at c01c4df8 [verbose debug info unavailable]
Oops: Exception in kernel mode, sig: 5 [#1]
[...]
NIP [c01c4df8] get_new_skb+0x7c/0xf8
LR [c01c4da4] get_new_skb+0x28/0xf8
Call Trace:
[ef82be00] [c01c4da4] get_new_skb+0x28/0xf8 (unreliable)
[ef82be20] [c01c4eb8] rx_bd_buffer_set+0x44/0x98
[ef82be40] [c01c62bc] ...
| Mar 31, 11:58 am 2009 |
| Larry Finger | [PATCH 2/2 V2] kaweth: Clean up code
The driver kaweth yields a -EBUSY error when starting, and a -ETIME
error when shutting down. These errors are avoided, and the RX status
is further checked for other potential errors.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Jeff,
As the listed authors of this driver have not touched it in several years,
I have taken the liberty of sending it to you as networking drivers maintainer.
I hope this is OK.
Larry
---
Index: ...
| Mar 31, 11:47 am 2009 |
| Oliver Neukum | Re: [PATCH 2/2 V2] kaweth: Clean up code
Why the different treatment with respect to the error counter?
Isn't enough to print the numerical error? This takes a lot of
memory.
Regards
Oliver
--
| Mar 31, 2:49 pm 2009 |
| David Miller | Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
From: Oliver Neukum <oliver@neukum.org>
Please be specific, what is this "it" you are referring to?
Larry's patch modifies the locking many functions, and you didn't
quote the kernel locking error message if that provides the context of
your comment.
--
| Mar 31, 3:04 pm 2009 |
| Oliver Neukum | Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
Are you sure it is never called with disabled interrupts?
Regards
Oliver
--
| Mar 31, 2:50 pm 2009 |
| Oliver Neukum | Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
Here you enable interrupts. Are you sure ndo_start_xmit is never
called with interrupts disabled?
Regards
Oliver
--
| Mar 31, 3:13 pm 2009 |
| Oliver Neukum | Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
Thanks. The patch is good. I'll check the other USB network
drivers.
Regards
Oliver
--
| Mar 31, 4:06 pm 2009 |
| David Miller | Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
From: Oliver Neukum <oliver@neukum.org>
It must never be invoked that way, this would break so many
drivers.
On the other hand, all of these driver paths never execute
in a real hardware interrupt context, the deepest it gets
into is software interrupts. So spin_*lock*_bh() might be
more appropriate.
--
| Mar 31, 3:10 pm 2009 |
| Larry Finger | Re: [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
I think not, but all I really know is that the change from spin_lock() to
spin_lock_irq() makes the errors go away.
I checked a number of drivers to see what their ndo_start_xmit routines do. Most
use spin_lock_irq(), but some do no locking.
I tried removing the locking, but that resulted in a stall even when I bypassed
the faulty router.
Larry
--
| Mar 31, 4:01 pm 2009 |
| Larry Finger | [PATCH 1/2 V2] kaweth: Fix locking to be SMP-safe
On an SMP system, the following message is printed. The patch below gets
fixes the problem.
=================================
[ INFO: inconsistent lock state ]
2.6.29-Linus-05093-gc31f403 #57
---------------------------------
inconsistent {hardirq-on-W} -> {in-hardirq-W} usage.
bash/4105 [HC1[1]:SC0[0]:HE0:SE1] takes:
(&kaweth->device_lock){+...}, at: [<ffffffffa01aa286>]
kaweth_usb_receive+0x77/0x1af [kaw eth]
{hardirq-on-W} state was registered at:
[<ffffffff80260503>] ...
| Mar 31, 11:45 am 2009 |
| Gregory Haskins | Re: [RFC PATCH 14/17] kvm: add a reset capability
Hmm..I had not considered this. Any suggestions on ways to detect it?
| Mar 31, 1:02 pm 2009 |
| Gregory Haskins | [RFC PATCH 04/17] vbus: add bus-registration notifiers
We need to get hotswap events in environments which cannot use existing
facilities (e.g. inotify). So we add a notifier-chain to allow client
callbacks whenever an interface is {un}registered.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
include/linux/vbus.h | 15 +++++++++++++
kernel/vbus/core.c | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++
kernel/vbus/vbus.h | 1 +
3 files changed, 75 insertions(+), 0 deletions(-)
diff --git a/include/linux/vbus.h ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | [RFC PATCH 17/17] kvm: Add guest-side support for VBUS
This adds a driver to interface between the host VBUS support, and the
guest-vbus bus model.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
arch/x86/Kconfig | 9 +
drivers/Makefile | 1
drivers/vbus/proxy/Makefile | 2
drivers/vbus/proxy/kvm.c | 726 +++++++++++++++++++++++++++++++++++++++++++
4 files changed, 738 insertions(+), 0 deletions(-)
create mode 100644 drivers/vbus/proxy/Makefile
create mode 100644 drivers/vbus/proxy/kvm.c
diff ...
| Mar 31, 11:44 am 2009 |
| Gregory Haskins | [RFC PATCH 12/17] venettap: add scatter-gather support
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
drivers/vbus/devices/venet-tap.c | 236 +++++++++++++++++++++++++++++++++++++-
1 files changed, 229 insertions(+), 7 deletions(-)
diff --git a/drivers/vbus/devices/venet-tap.c b/drivers/vbus/devices/venet-tap.c
index ccce58e..0ccb7ed 100644
--- a/drivers/vbus/devices/venet-tap.c
+++ b/drivers/vbus/devices/venet-tap.c
@@ -80,6 +80,13 @@ enum {
TX_IOQ_CONGESTED,
};
+struct venettap;
+
+struct venettap_rx_ops {
+ int ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | [RFC PATCH 15/17] kvm: add dynamic IRQ support
This patch provides the ability to dynamically declare and map an
interrupt-request handle to an x86 8-bit vector.
Problem Statement: Emulated devices (such as PCI, ISA, etc) have
interrupt routing done via standard PC mechanisms (MP-table, ACPI,
etc). However, we also want to support a new class of devices
which exist in a new virtualized namespace and therefore should
not try to piggyback on these emulated mechanisms. Rather, we
create a way to dynamically register interrupt resources ...
| Mar 31, 11:44 am 2009 |
| Gregory Haskins | [RFC PATCH 02/17] vbus: add virtual-bus definitions
See Documentation/vbus.txt for details
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
Documentation/vbus.txt | 386 +++++++++++++++++++++++++++++
arch/x86/Kconfig | 2
fs/proc/base.c | 96 +++++++
include/linux/sched.h | 4
include/linux/vbus.h | 147 +++++++++++
include/linux/vbus_device.h | 416 ++++++++++++++++++++++++++++++++
kernel/Makefile | 1
kernel/exit.c | 2
kernel/fork.c ...
| Mar 31, 11:42 am 2009 |
| Gregory Haskins | [RFC PATCH 01/17] shm-signal: shared-memory signals
This interface provides a bidirectional shared-memory based signaling
mechanism. It can be used by any entities which desire efficient
communication via shared memory. The implementation details of the
signaling are abstracted so that they may transcend a wide variety
of locale boundaries (e.g. userspace/kernel, guest/host, etc).
The shm_signal mechanism supports event masking as well as spurious
event delivery mitigation.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
...
| Mar 31, 11:42 am 2009 |
| Gregory Haskins | Re: [RFC PATCH 01/17] shm-signal: shared-memory signals
Yeah, good idea. What is the official way to do this these days? Are
Totally agreed. If you look, most of the ABI has a type of "NEGCAP"
(negotiate capabilities) feature. The version number is a contingency
plan in case I still have to break it for whatever reason. I will
always opt for the feature bits over bumping the version when its
This is still somewhat of a immature part of the design. Its supposed
to be used so that by default, its a panic. But on the host side, we
can do ...
| Mar 31, 1:58 pm 2009 |
| Gregory Haskins | [RFC PATCH 00/17] virtual-bus
applies to v2.6.29 (will port to git HEAD soon)
FIRST OFF: Let me state that this is not a KVM or networking specific
technology. Virtual-Bus is a mechanism for defining and deploying
software “devices” directly in a Linux kernel. The example use-case we
have provided supports a “virtual-ethernet” device being utilized in a
KVM guest environment, so comparisons to virtio-net will be natural.
However, please note that this is but one use-case, of many we have
planned for the future (such as ...
| Mar 31, 11:42 am 2009 |
| Gregory Haskins | Re: [RFC PATCH 15/17] kvm: add dynamic IRQ support
These points are all valid, and I really struggled with this particular
part of the design. The entire vbus design only requires one IRQ for
the entire guest, so its conceivable that I could present a simple
"dummy" PCI device with some "VBUS" type PCI-ID, just to piggy back on
the IRQ routing logic. Then userspace could simply pass the IRQ routing
info down to the kernel with an ioctl, or something similar.
Ultimately I wasn't sure whether I wanted all that goo just to get an
IRQ ...
| Mar 31, 12:39 pm 2009 |
| Gregory Haskins | [RFC PATCH 13/17] x86: allow the irq->vector translation ...
The ioapic code currently privately manages the mapping between irq
and vector. This results in some layering violations as the support
for certain MSI operations need this info. As a result, the MSI
code itself was moved to the ioapic module. This is not really
optimal.
We now have another need to gain access to the vector assignment on
x86. However, rather than put yet another inappropriately placed
function into io-apic, lets create a way to export this simple data
and therefore allow ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | Re: [RFC PATCH 13/17] x86: allow the irq->vector transla ...
Its needed for the kvm-connector patches later in the series, so it was
included intentionally.
On that topic, I probably should have had a TOC of some kind. Hmm..let
me hack one together now:
Patch 1: Stand-alone "shared-memory signal" construct, used by various
components in vbus/venet
Patches 2-5: Basic vbus infrastructure
Patches 6-7: IOQ construct, similar to virtio-ring. Used to overlay
ring-like behavior over the shm interface in vbus
Patches 8-12: virtual-ethernet front and ...
| Mar 31, 1:02 pm 2009 |
| Avi Kivity | Re: [RFC PATCH 15/17] kvm: add dynamic IRQ support
Won't this have scaling issues? One IRQ means one target vcpu. Whereas
I'd like virtio devices to span multiple queues, each queue with its own
MSI IRQ. Also, the single IRQ handler will need to scan for all
potential IRQ sources. Even if implemented carefully, this will cause
s/PCI/the native IRQ solution for your platform/. virtio has the same
problem; on s390 we use the native (if that word ever applies to s390)
interrupt and device discovery mechanism.
--
I have a truly ...
| Mar 31, 1:13 pm 2009 |
| Gregory Haskins | [RFC PATCH 16/17] kvm: Add VBUS support to the host
This patch adds support for guest access to a VBUS assigned to the same
context as the VM. It utilizes a IOQ+IRQ to move events from host->guest,
and provides a hypercall interface to move events guest->host.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
arch/x86/include/asm/kvm_para.h | 1
arch/x86/kvm/Kconfig | 9
arch/x86/kvm/Makefile | 3
arch/x86/kvm/x86.c | 6
arch/x86/kvm/x86.h | 12
include/linux/kvm.h ...
| Mar 31, 11:44 am 2009 |
| Avi Kivity | Re: [RFC PATCH 01/17] shm-signal: shared-memory signals
Similarly, this should be padded to 0 (mod 8).
Instead of versions, I prefer feature flags which can be independently
This means "->inject() has been called from the other side"?
(reading below I see this is so. not used to reading well commented
When you overlay a ring on top of this, won't the ring indexes convey
the same information as ->dirty?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
| Mar 31, 1:44 pm 2009 |
| Gregory Haskins | Re: [RFC PATCH 15/17] kvm: add dynamic IRQ support
Hmm..you know I hadnt really thought of it that way, but you have a
point. To clarify, my design actually uses one IRQ per "eventq", where
we can have an arbitrary number of eventq's defined (note: today I only
define one eventq, however). An eventq is actually a shm-ring construct
where I can pass events up to the host like "device added" or "ring X
signaled". Each individual device based virtio-ring would then
aggregates "signal" events onto this eventq mechanism to actually inject
events to ...
| Mar 31, 1:32 pm 2009 |
| Gregory Haskins | [RFC PATCH 06/17] ioq: Add basic definitions for a share ...
We can map these over VBUS shared memory (or really any shared-memory
architecture if it supports shm-signals) to allow asynchronous
communication between two end-points. Memory is synchronized using
pure barriers (i.e. lockless), so IOQs are friendly in many contexts,
even if the memory is remote.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
include/linux/ioq.h | 410 +++++++++++++++++++++++++++++++++++++++++++++++++++
lib/Kconfig | 12 +
lib/Makefile | 1 ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | [RFC PATCH 03/17] vbus: add connection-client helper inf ...
We expect to have various types of connection-clients (e.g. userspace,
kvm, etc), each of which is likely to have common access patterns and
marshalling duties. Therefore we create a "client" API to simplify
client development by helping with mundane tasks such as handle-2-pointer
translation, etc.
Special thanks to Pat Mullaney for suggesting the optimization to pass
a cookie object down during DEVICESHM operations to save lookup overhead
on the event channel.
Signed-off-by: Gregory ...
| Mar 31, 11:43 am 2009 |
| Andi Kleen | Re: [RFC PATCH 00/17] virtual-bus
Gregory Haskins <ghaskins@novell.com> writes:
What might be useful is if you could expand a bit more on what the high level
use cases for this.
Questions that come to mind and that would be good to answer:
This seems to be aimed at having multiple VMs talk
to each other, but not talk to the rest of the world, correct?
Is that a common use case?
Wouldn't they typically have a default route anyways and be able to talk to each
other this way?
And why can't any such isolation be done ...
| Mar 31, 1:18 pm 2009 |
| Gregory Haskins | [RFC PATCH 09/17] net: Add vbus_enet driver
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
drivers/net/Kconfig | 13 +
drivers/net/Makefile | 1
drivers/net/vbus-enet.c | 706 +++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 720 insertions(+), 0 deletions(-)
create mode 100644 drivers/net/vbus-enet.c
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 62d732a..ac9dabd 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -3099,4 +3099,17 @@ config VIRTIO_NET
This is ...
| Mar 31, 11:43 am 2009 |
| Alan Cox | Re: [RFC PATCH 13/17] x86: allow the irq->vector transla ...
On Tue, 31 Mar 2009 14:43:55 -0400
This appears to have been muddled in with the vnet patches ?
--
| Mar 31, 12:16 pm 2009 |
| Gregory Haskins | [RFC PATCH 07/17] ioq: add vbus helpers
It will be common to map an IOQ over the VBUS shared-memory interfaces,
so lets generalize their setup so we can reuse the pattern.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
include/linux/vbus_device.h | 7 +++
include/linux/vbus_driver.h | 7 +++
kernel/vbus/Kconfig | 2 +
kernel/vbus/Makefile | 1
kernel/vbus/proxy.c | 64 +++++++++++++++++++++++++++++++
kernel/vbus/shm-ioq.c | 89 +++++++++++++++++++++++++++++++++++++++++++
6 ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | [RFC PATCH 05/17] vbus: add a "vbus-proxy" bus model for ...
This will generally be used for hypervisors to publish any host-side
virtual devices up to a guest. The guest will have the opportunity
to consume any devices present on the vbus-proxy as if they were
platform devices, similar to existing buses like PCI.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
include/linux/vbus_driver.h | 73 +++++++++++++++++++++
kernel/vbus/Kconfig | 9 +++
kernel/vbus/Makefile | 4 +
kernel/vbus/proxy.c | 152 ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | [RFC PATCH 11/17] venet: add scatter-gather support
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
drivers/net/vbus-enet.c | 249 +++++++++++++++++++++++++++++++++++++++++++++--
include/linux/venet.h | 39 +++++++
2 files changed, 275 insertions(+), 13 deletions(-)
diff --git a/drivers/net/vbus-enet.c b/drivers/net/vbus-enet.c
index e698b3f..8e96c9c 100644
--- a/drivers/net/vbus-enet.c
+++ b/drivers/net/vbus-enet.c
@@ -42,6 +42,8 @@ static int rx_ringlen = 256;
module_param(rx_ringlen, int, 0444);
static int tx_ringlen = ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | [RFC PATCH 14/17] kvm: add a reset capability
We need a way to detect if a VM is reset later in the series, so lets
add a capability for userspace to signal a VM reset down to the kernel.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
arch/x86/kvm/x86.c | 1 +
include/linux/kvm.h | 2 ++
include/linux/kvm_host.h | 6 ++++++
virt/kvm/kvm_main.c | 36 ++++++++++++++++++++++++++++++++++++
4 files changed, 45 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index ...
| Mar 31, 11:44 am 2009 |
| Avi Kivity | Re: [RFC PATCH 14/17] kvm: add a reset capability
Best would be not to detect it; it's tying global events into a device.
Instead, have a reset command for your device and have the driver issue
it on load and unload.
btw, reset itself would be better controlled from userspace; qemu knows
about resets and can reset vbus devices directly instead of relying on
kvm to reset them. This decouples the two code bases a bit. This is
what virtio does.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow ...
| Mar 31, 1:18 pm 2009 |
| Avi Kivity | Re: [RFC PATCH 15/17] kvm: add dynamic IRQ support
You will get get cachelines bounced around when events from different
devices are added to the queue. On the plus side, a single injection
can contain interrupts for multiple devices.
I'm not sure how useful this coalescing is; certainly you will never see
it on microbenchmarks, but that doesn't mean it's not useful.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
| Mar 31, 1:59 pm 2009 |
| Stephen Hemminger | Re: [RFC PATCH 09/17] net: Add vbus_enet driver
On Tue, 31 Mar 2009 14:43:34 -0400
Please consider adding basic set of ethtool_ops to allow controlling
offload, etc.
--
| Mar 31, 1:39 pm 2009 |
| Avi Kivity | Re: [RFC PATCH 01/17] shm-signal: shared-memory signals
I see.
This raises a point I've been thinking of - the symmetrical nature of
the API vs the assymetrical nature of guest/host or user/kernel
interfaces. This is most pronounced in ->inject(); in the host->guest
direction this is async (host can continue processing while the guest is
handling the interrupt), whereas in the guest->host direction it is
synchronous (the guest is blocked while the host is processing the call,
unless the host explicitly hands off work to a different ...
| Mar 31, 2:05 pm 2009 |
| Avi Kivity | Re: [RFC PATCH 14/17] kvm: add a reset capability
How do you handle the case of a guest calling kexec to load a new
kernel? Or is that not important for your use case?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
| Mar 31, 12:22 pm 2009 |
| Gregory Haskins | [RFC PATCH 08/17] venet: add the ABI definitions for an ...
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
include/linux/venet.h | 47 +++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 47 insertions(+), 0 deletions(-)
create mode 100644 include/linux/venet.h
diff --git a/include/linux/venet.h b/include/linux/venet.h
new file mode 100644
index 0000000..ef6b199
--- /dev/null
+++ b/include/linux/venet.h
@@ -0,0 +1,47 @@
+/*
+ * Copyright 2008 Novell. All Rights Reserved.
+ *
+ * Virtual-Ethernet adapter
+ *
+ * ...
| Mar 31, 11:43 am 2009 |
| Gregory Haskins | Re: [RFC PATCH 14/17] kvm: add a reset capability
Yes, good point. This is doable within the existing infrastructure, but
it would have to be declared in each devices ABI definition. I could
make it more formal and add it to the list of low-level bus-verbs, like
In a way, this is what I have done (note to self: post the userspace
patches)
The detection is done by userspace, and it invokes an ioctl. The kernel
based devices then react if they are interested. In my case, vbus
registers for reset-notification, and it acts as if the guest ...
| Mar 31, 1:37 pm 2009 |
| Gregory Haskins | [RFC PATCH 10/17] venet-tap: Adds a "venet" compatible " ...
This module is similar in concept to a "tuntap". A tuntap module provides
a netif() interface on one side, and a char-dev interface on the other.
Packets that ingress on one interface, egress on the other (and vice versa).
This module offers a similar concept, except that it substitues the
char-dev for a VBUS/IOQ interface. This allows a VBUS compatible entity
(e.g. userspace or a guest) to directly inject and receive packets
from the host/kernel stack.
Thanks to Pat Mullaney for ...
| Mar 31, 11:43 am 2009 |
| Avi Kivity | Re: [RFC PATCH 15/17] kvm: add dynamic IRQ support
A major disadvantage of dynirq is that it will only work on guests which
have been ported to it. So this will only be useful on newer Linux, and
will likely never work with Windows guests.
Why is having an emulated PCI device so bad? We found that it has
several advantages:
- works with all guests
- supports hotplug/hotunplug, udev, sysfs, module autoloading, ...
- supported in all OSes
- someone else maintains it
See also the kvm irq routing work, merged into 2.6.30, which does ...
| Mar 31, 12:20 pm 2009 |
| Anton Vorontsov | [PATCH] fsl_pq_mdio: Revive UCC MDIO support
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") introduced a regression so that UCC
MDIO buses no longer work.
This is because fsl_pq_mdio driver wrongly masks all non-TBI PHYs
for !fsl,gianfar-mdio buses, while it should do that only for
fsl,gianfar-tbi buses.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/net/fsl_pq_mdio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git ...
| Mar 31, 11:33 am 2009 |
| Jeremy Jackson | keeping ifindex in 16bits or does it have to be sparse?
The question came up when profiling Quagga... a performance issue occurs
because it's iterating over a linked list of interface structures... and
this person is using 2000 interfaces for ADSL PPPoE server. It's an
interesting use case.
There are 2 options to make the interface lookup in quagga scale: array
or hash. My first thought was array, but it seems that ifindex can get
sparse, that is, the largest ifindex can be much bigger (eg 408589) the
number of max number of interfaces.
So ...
| Mar 31, 8:08 am 2009 |
| Stephen Hemminger | Re: keeping ifindex in 16bits or does it have to be sparse?
On Tue, 31 Mar 2009 11:08:17 -0400
Hash the names as well, since quagga does a lot of lookup by name.
--
| Mar 31, 10:02 am 2009 |
| Ben Greear | Re: keeping ifindex in 16bits or does it have to be sparse?
Please use a hash...I'm sure someone will have a use-case with more than
64k interfaces
sometime soon.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
--
| Mar 31, 8:24 am 2009 |
| Atsushi Nemoto | [PATCH] tc35815: Fix build error if NAPI enabled
This driver contains experimental NAPI code disabled by default.
The commit bea3348ee ("[NET]: Make NAPI polling independent of struct
net_device objects.") converted the NAPI path of this driver but that
conversion was not complete. This patch fixes a build error
introduced by the commit.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
drivers/net/tc35815.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tc35815.c ...
| Mar 31, 8:05 am 2009 |
| Kumar Gala | [PATCH 2/2] ucc_geth: Remove unused header
Now that the driver is exclusively an of_platform driver we no longer
use the structs and #defines in fsl_devices.h
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/net/ucc_geth.c | 1 -
drivers/net/ucc_geth.h | 1 -
drivers/net/ucc_geth_ethtool.c | 1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 933fcfb..a124615 100644
--- a/drivers/net/ucc_geth.c
+++ ...
| Mar 31, 6:42 am 2009 |
| Kumar Gala | [PATCH 1/2] gianfar: Remove unused header
Now that the driver is exclusively an of_platform driver we no longer
use the structs and #defines in fsl_devices.h
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/net/gianfar.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/gianfar.h b/drivers/net/gianfar.h
index dd499d7..0642d52 100644
--- a/drivers/net/gianfar.h
+++ b/drivers/net/gianfar.h
@@ -45,7 +45,6 @@
#include <linux/crc32.h>
#include <linux/workqueue.h>
#include ...
| Mar 31, 6:42 am 2009 |
| Alan Carvalho de Assis | [PATCH] i.MX31: Fixing cs89x0 network building to i.MX31ADS
This is a fix to get cs89x0 network driver working on i.MX31ADS
Signed-off-by: Alan Carvalho de Assis <acassis@gmail.com>
---
drivers/net/cs89x0.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c
index ff64976..8ccc8f7 100644
--- a/drivers/net/cs89x0.c
+++ b/drivers/net/cs89x0.c
@@ -190,6 +190,7 @@ static unsigned int cs8900_irq_map[] =
{IRQ_IXDP2X01_CS8900, 0, 0, 0};
static unsigned int netcard_portlist[] __used ...
| Mar 31, 6:36 am 2009 |
| Jan Dumon | [PATCH] hso: add Vendor/Product ID's for new devices
From: Jan Dumon <j.dumon@option.com>
Add Vendor/Product ID's for new devices.
Signed-off-by: Jan Dumon <j.dumon@option.com>
---
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index fe98aca..d47c508 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
{USB_DEVICE(0x0af0, 0x7701)},
{USB_DEVICE(0x0af0, 0x7801)},
{USB_DEVICE(0x0af0, 0x7901)},
- {USB_DEVICE(0x0af0, 0x7361)},
- {USB_DEVICE(0x0af0, ...
| Mar 31, 4:56 am 2009 |
| Stephen Hemminger | Re: Patch: Fix fec_mpc52xx driver to use net_device_ops
On Tue, 31 Mar 2009 12:44:15 +0200
What about change_mtu? Don't you want:
.ndo_change_mtu = eth_change_mtu,
--
| Mar 31, 7:48 am 2009 |
| Grant Likely | Re: Patch: Fix fec_mpc52xx driver to use net_device_ops
On Tue, Mar 31, 2009 at 8:48 AM, Stephen Hemminger
Yes, you're right. fixed.
Thanks,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Mar 31, 9:48 am 2009 |
| Henk Stegeman | Patch: Fix fec_mpc52xx driver to use net_device_ops
Fix fec_mpc52xx driver to use net_device_ops and to be careful not to
dereference phy_device if a phy has not yet been connected.
Signed-off-by: Henk Stegeman <henk.stegeman@gmail.com>
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index cd8e98b..ca76b95 100644
--- a/drivers/net/fec_mpc52xx.c
+++ b/drivers/net/fec_mpc52xx.c
@@ -847,24 +847,40 @@ static void mpc52xx_fec_get_drvinfo(struct
net_device *dev,
static int mpc52xx_fec_get_settings(struct net_device *dev, ...
| Mar 31, 3:44 am 2009 |
| Grant Likely | Re: Patch: Fix fec_mpc52xx driver to use net_device_ops
On Tue, Mar 31, 2009 at 8:48 AM, Stephen Hemminger
Hi Henk,
I hadn't heard from you for a while about the signed-off-by line, but
I really needed to get those changes queued because the 2.6.30 merge
window is open now, and some of my patches depend on it. I ended up
rewriting your patch from scratch, testing it and posting it last
night.
I would really like to stick with the rewritten version since it is a
little tighter, and it is the one I've got tested. However, now that
I've heard ...
| Mar 31, 9:42 am 2009 |
| Grant Likely | [PATCH 08/14] net: rework fsl_pq_mdio driver to use of_m ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/fsl_pq_mdio.c | 53 +++------------------------------------------
1 files changed, 4 insertions(+), 49 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b3079a5..83a98f4 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -34,6 +34,7 @@
...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 06/14] openfirmware: Add OF phylib support code
From: Grant Likely <grant.likely@secretlab.ca>
Add support for parsing the device tree for PHY devices on an MDIO bus
CC: Andy Fleming <afleming@freescale.com>
CC: linuxppc-dev@ozlabs.org
CC: devtree-discuss@ozlabs.org
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/of/Kconfig | 6 ++
drivers/of/Makefile | 1
drivers/of/of_mdio.c | 139 +++++++++++++++++++++++++++++++++++++++++++++++
include/linux/of_mdio.h | 22 +++++++
4 files changed, 168 ...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 01/14] of: add of_parse_phandle() helper for pars ...
From: Grant Likely <grant.likely@secretlab.ca>
of_parse_phandle() is a helper function to read and parse a phandle
property and return a pointer to the resulting device_node.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
CC: Michael Ellerman <michael@ellerman.id.au>
---
drivers/of/base.c | 24 ++++++++++++++++++++++++
include/linux/of.h | 3 +++
2 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index cd17092..104b8c0 ...
| Mar 31, 1:26 am 2009 |
| Grant Likely | [PATCH 10/14] net: Rework ucc_geth driver to use of_mdio ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/ucc_geth.c | 47 ++++++++++++-----------------------------------
drivers/net/ucc_geth.h | 2 +-
2 files changed, 13 insertions(+), 36 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 933fcfb..471a30a 100644
--- a/drivers/net/ucc_geth.c
+++ ...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 13/14] net: Rework fs_enet driver to use of_mdio ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/fs_enet/fs_enet-main.c | 69 ++++++------------------------------
drivers/net/fs_enet/mii-bitbang.c | 29 +--------------
drivers/net/fs_enet/mii-fec.c | 26 +-------------
include/linux/fs_enet_pd.h | 6 +--
4 files changed, 16 insertions(+), 114 deletions(-)
diff --git ...
| Mar 31, 1:27 am 2009 |
| David Miller | Re: [PATCH 00/14] Add common OF device tree support for ...
From: Grant Likely <grant.likely@secretlab.ca>
No, sorry.
We could have worked out the interdependencies before the merge window
openned up. There is no reason this could not have sat in at least
somebody's tree before the merge window started.
It therefore didn't get any -next exposure, so it's unreasonable to
merge this stuff now.
--
| Mar 31, 2:57 pm 2009 |
| Grant Likely | [PATCH 14/14] net: add Xilinx ll_temac device driver
From: Grant Likely <grant.likely@secretlab.ca>
This patch adds support for the Xilinx ll_temac 10/100/1000 Ethernet
device. The ll_temac ipcore is typically used on Xilinx Virtex and
Spartan designs attached to either a PowerPC 4xx or Microblaze
processor.
At the present moment, this driver only works with Virtex5 PowerPC
designs because it assumes DCR is used to access the DMA registers.
However, the low level access to DMA registers is abstracted and
it should be easy to adapt for the ...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 07/14] net: Rework mpc5200 fec driver to use of_m ...
From: Grant Likely <grant.likely@secretlab.ca>
The patch reworks the MPC5200 Fast Ethernet Controller (FEC) driver to
use the of_mdio infrastructure for registering PHY devices from data out
openfirmware device tree, and eliminates the assumption that the PHY
for the FEC is always attached to the FEC's own MDIO bus. With this
patch, the FEC can use a PHY attached to any MDIO bus if it is described
in the device tree.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 03/14] net/fec_mpc52xx: Don't dereference phy_dev ...
From: Grant Likely <grant.likely@secretlab.ca>
The FEC Ethernet device isn't always attached to a phy. Be careful
not to dereference phy_device if it is NULL.
Reported-by: Henk Stegeman <henk.stegeman@gmail.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/fec_mpc52xx.c | 22 ++++++++++++----------
1 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index 75d0569..e10eb2c 100644
--- ...
| Mar 31, 1:26 am 2009 |
| Grant Likely | [PATCH 11/14] net: Rework pasemi_mac driver to use of_md ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch simplifies the driver by making use of more common code.
Tested-by: Olof Johansson <olof@lixom.net>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/platforms/pasemi/gpio_mdio.c | 32 +++++------------------------
drivers/net/pasemi_mac.c | 28 ++++---------------------
drivers/net/pasemi_mac.h | 1 -
3 files changed, 9 ...
| Mar 31, 1:27 am 2009 |
| Grant Likely | Re: [PATCH 00/14] Add common OF device tree support for ...
It's been out there on the list since before the merge window, getting
tested by more than just me. This is not series which has simply
dropped out of thin air. I've been working hard to address issues
reported by others (Thanks Olof!) and to keep it building and applying
Since when has sitting in a -next tree been a requirement for merging
when the series has been kept up to date and tested? I purposefully
kept it out of -next to ensure that when it was applied for real to a
-next tree it ...
| Mar 31, 3:19 pm 2009 |
| Grant Likely | [PATCH 00/14] Add common OF device tree support for MDIO ...
This series adds common code for reading PHY connection data out of
the OpenFirmware device tree. This simplifies the network drivers
which use the device tree and which currently implement their own
solutions for reading the PHY data out of the device tree directly.
This series was depending on changes in both the netdev and powerpc
-next trees. Now that both trees have been merged by Linus, I'm
able to post this series in a usable form.
David, as I mentioned below, I'd really like to get ...
| Mar 31, 1:26 am 2009 |
| Grant Likely | [PATCH 09/14] net: Rework gianfar driver to use of_mdio ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/gianfar.c | 103 ++++++++++++++++++-------------------------------
drivers/net/gianfar.h | 3 +
2 files changed, 40 insertions(+), 66 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 65f5587..c22eba9 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ ...
| Mar 31, 1:27 am 2009 |
| David Miller | Re: [PATCH 00/14] Add common OF device tree support for ...
From: Grant Likely <grant.likely@secretlab.ca>
I know your pissed off, but take a deep breath and consider this
from my position.
If I don't put a line in the sand somewhere, everyone can say
"I've been working so hard, I posted it to the lists a thousand
times, I have tons of testers" and I have to put the change in.
That doesn't work, so please wait until the next release to get
your changes in. And get them into a tree that gets exposure
in linux-next. Then you have nothing to worry ...
| Mar 31, 3:22 pm 2009 |
| Grant Likely | [PATCH 12/14] powerpc/82xx: Rework Embedded Planet ep824 ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch modifies the bitbanged MDIO driver in the ep8248e platform
code to use the common of_mdio infrastructure.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/platforms/82xx/ep8248e.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/82xx/ep8248e.c b/arch/powerpc/platforms/82xx/ep8248e.c
index 0eb6d7f..51fcae4 100644
--- ...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 05/14] phylib: add *_direct() variants of phy_con ...
From: Grant Likely <grant.likely@secretlab.ca>
Add phy_connect_direct() and phy_attach_direct() functions so that
drivers can use a pointer to the phy_device instead of trying to determine
the phy's bus_id string.
This patch is useful for OF device tree descriptions of phy devices where
the driver doesn't need or know what the bus_id value in order to get a
phy_device pointer.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/phy/phy_device.c | 118 ...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 04/14] phylib: rework to prepare for OF registrat ...
From: Grant Likely <grant.likely@secretlab.ca>
This patch makes changes in preparation for supporting open firmware
device tree descriptions of MDIO busses. Changes include:
- Cleanup handling of phy_map[] entries; they are already NULLed when
registering and so don't need to be re-cleared, and it is good practice
to clear them out when unregistering.
- Split phy_device registration out into a new function so that the
OF helpers can do two stage registration (separate allocation and
...
| Mar 31, 1:27 am 2009 |
| Grant Likely | [PATCH 02/14] net/fec_mpc52xx: Migrate to net_device_ops.
From: Grant Likely <grant.likely@secretlab.ca>
Since not using net_device_ops gets you shunned out the cool crowd,
this patch modifies the fec_mpc52xx Ethernet driver to provide the
management hooks via a struct net_device_ops.
Reported-by: Henk Stegeman <henk.stegeman@gmail.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/fec_mpc52xx.c | 35 +++++++++++++++++++----------------
1 files changed, 19 insertions(+), 16 deletions(-)
diff --git ...
| Mar 31, 1:26 am 2009 |
| David Miller | Re: [PATCH] core: remove pointless conditional before kfree()
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Applied, thanks.
--
| Mar 31, 3:06 pm 2009 |
| Wei Yongjun | [PATCH] core: remove pointless conditional before kfree()
Remove pointless conditional before kfree().
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/core/ethtool.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 244ca56..d9d5160 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -261,8 +261,7 @@ static int ethtool_get_rxnfc(struct net_device *dev, void __user *useraddr)
ret = 0;
err_out:
- if (rule_buf)
- kfree(rule_buf);
+ kfree(rule_buf);
...
| Mar 31, 1:09 am 2009 |
| Grant Likely | [PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops
From: Grant Likely <grant.likely@secretlab.ca>
The driver triggers a BUG_ON() when allocating DMA buffers if the
arch/powerpc dma_ops from the of_platform device are not copied
into net_device structure.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
Becky, does this look better to you?
g.
drivers/net/fec_mpc52xx.c | 19 ++++++++++++-------
1 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index ...
| Mar 30, 7:25 pm 2009 |
| Grant Likely | Re: [PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops
Thanks Becky.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Mar 31, 12:10 pm 2009 |
| Becky Bruce | Re: [PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops
Reviewed-by: Becky Bruce <beckyb@kernel.crashing.org>
I think this is OK now, and Kumar agrees....
Thanks!
--
| Mar 31, 11:58 am 2009 |
| Mrs Helen Anderson | claims of
You have just been awarded,the sum of £500,000 GBP in the UK Online Promotion, held March. For Claims email your details to:pinket.griphin22@btinternet.com
Names:............
Address:..............
Country:.................
Age:..........
Sex:..............
Phone/cellphone........
regard
Mrs Helen Anderson
--
| Mar 30, 6:47 pm 2009 |
| Roland Dreier | Re: [PATCH 6/9] RDS: Fix ordering in a conditional
> - if (0 <= ret && (unsigned) ret < nr_pages) {
> + if (ret > 0 && (unsigned) ret < nr_pages) {
This is not an equivalent transformation -- the original code is true if
ret == 0, while the new code is false.
Also it seems you don't need the unsigned cast here, since the clause
before just checked that ret is positive?
- R.
--
| Mar 30, 9:27 pm 2009 |
| Andrew Grover | Re: [PATCH 6/9] RDS: Fix ordering in a conditional
True, but I'd bet the compiler will warn if we remove it. I'll try it
tomorrow and see.
Thanks! -- Regards -- Andy
--
| Mar 30, 11:56 pm 2009 |
| David Miller | Re: [PATCH 6/9] RDS: Fix ordering in a conditional
From: Andrew Grover <andy.grover@gmail.com>
Andy, also please resubmit only the real honest-to-goodness bug fixes
in this patch series.
I don't want to see cleanups, or optimizations like the transformation
over to using get_user_pages_fast().
You could have sent that kind of stuff to me weeks ago.
Thanks.
--
| Mar 31, 2:50 pm 2009 |
| David Miller | Re: [PATCH 0/3] [git-pull] net firmware patches
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
Pulled, thanks!
--
| Mar 31, 2:44 pm 2009 |
| David Miller | Re: [PATCH net-2.6 ] ipv4: remove unused parameter from ...
From: Rami Rosen <ramirose@gmail.com>
Applied.
--
| Mar 31, 2:43 pm 2009 |
| David Miller | Re: [PATCH] ETHOC: fix build breakage on s390
From: Thierry Reding <thierry.reding@avionic-design.de>
Applied.
--
| Mar 31, 2:41 pm 2009 |
| Jesper Dangaard Brouer | Re: [PATCH v2 3/3] Doc: Fix spelling in RCU/rculist_nulls.txt.
Doc: Fix spelling in RCU/rculist_nulls.txt.
Trival spelling fixes in RCU/rculist_nulls.txt.
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
---
Documentation/RCU/rculist_nulls.txt | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/RCU/rculist_nulls.txt b/Documentation/RCU/rculist_nulls.txt
index 239f542..6389dec 100644
--- a/Documentation/RCU/rculist_nulls.txt
+++ ...
| Mar 31, 12:36 pm 2009 |
| Jesper Dangaard Brouer | Re: [PATCH v2 3/3] Doc: Fix spelling in RCU/rculist_nulls.txt.
Sorry, it because my email program "pine" insists on line wrapping. I
have tried to adjust the preferences ("newmail-window-width" and
"composer-wrap-column") but it still insists... grrr
It looks like that patchwork corrected the line wrappings
(http://patchwork.ozlabs.org/patch/25337/) but if I download the patch via
patchwork, it also fails because a space has been added in front of all
lines, hmmm...
Okay, I'll try to repost using another email program (as reply to this
message ...
| Mar 31, 12:17 pm 2009 |
| Jarek Poplawski | Re: [PATCH v2 3/3] Doc: Fix spelling in RCU/rculist_nulls.txt.
Hmm... still "reviewing", and maybe it's only me, but can't apply...
(v1 works OK.)
--
| Mar 31, 3:54 am 2009 |
| David Miller | Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
From: Larry Finger <Larry.Finger@lwfinger.net>
I've been handling networking driver patches for a few months
now, so you only need CC: me.
Thanks.
--
| Mar 31, 3:00 pm 2009 |
| Oliver Neukum | Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
Do you get something with sysrq-t ?
Regards
Oliver
--
| Mar 31, 12:39 am 2009 |
| Larry Finger | Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
The problem turned out to be an old, slow router that was locking, and not a
problem with kaweth. I'll resubmit my patches.
Larry
--
| Mar 31, 11:40 am 2009 |
| Larry Finger | Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
No. The rest of the system was still functioning; however, the driver needed to
be unloaded and reloaded before continuing. There were no log entries until the
driver was unloaded.
Larry
--
| Mar 31, 7:55 am 2009 |
| Larry Finger | Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
No, that one did not print.
My initial level of debugging was to #define DEBUG. When the dbg() macros didn't
trigger, I included a local copy of that one and then saw those messages.
From my reading of include/linux/device.h, dev_warn() should always be enabled.
Did I miss something?
Larry
--
| Mar 31, 8:24 am 2009 |
| Oliver Neukum | Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
This sounds like kaweth_tx_timeout() should have been called.
Did you enable enough logging to see
dev_warn(&net->dev, "%s: Tx timed out. Resetting.\n", net->name);
Regards
Oliver
--
| Mar 31, 8:13 am 2009 |
| Ilpo Järvinen | Re: WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/ ...
On Tue, 31 Mar 2009, Markus Trippelsdorf wrote:
> On Mon, Mar 30, 2009 at 09:52:55PM +0300, Ilpo J
| Mar 31, 2:16 am 2009 |
| Markus Trippelsdorf | Re: WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/ ...
The machine hanged again this night and I took two pictures:
http://www.mypicx.com/uploadimg/1055813374_03302009_2.jpg
http://www.mypicx.com/uploadimg/1543678904_03302009_1.jpg
But this time there was no tcp related warning in the logs.
I then pulled the lateset git changes, rebuild, rebooted and setup the
workload again. The machine was still up and running in the morning
(~4 hours uptime). So it may well be that the issue was fixed with
the latest changes. If it ever occurs again I will ...
| Mar 31, 12:10 am 2009 |
| Ilpo Järvinen | Re: WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/ ...
On Tue, 31 Mar 2009, Markus Trippelsdorf wrote:
> On Tue, Mar 31, 2009 at 12:16:51PM +0300, Ilpo J
| Mar 31, 12:12 pm 2009 |
| Markus Trippelsdorf | Re: WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd55/ ...
It happend again. In this case it took ~10 minutes from the warning to
the final crash. I'm pretty sure there must be some kind of relation
between the two. How else could one explain that the machine crashes just
minutes after _each_ instance of that WARNING?
(Unfortunately I was in X again, because I thought this problem was
solved)
------------[ cut here ]------------
WARNING: at net/ipv4/tcp_input.c:2927 tcp_ack+0xd5b/0x19a6()
Hardware name: To Be Filled By O.E.M.
Pid: 0, comm: ...
| Mar 31, 11:49 am 2009 |
| Kumar Gala | Re: "no new taxes"
I will say that some people who submit patches dont follow this list
on regular basis and might miss this request (as I just did and
submitted a minor cleanup patch against two networking drivers --
sorry about that).
- k
--
| Mar 31, 7:13 am 2009 |
| Li Yang | Re: [PATCH] ucc_geth: Rework the TX logic.
I noticed that in gianfar these memory access is not protected by
"volatile". Can this be the reason why the compiler did some unwanted
optimization?
- Leo
--
| Mar 31, 1:16 am 2009 |
| Scott Wood | Re: [PATCH] ucc_geth: Rework the TX logic.
Enabling cacheing on MURAM, at least when used for buffer descriptors.
The cache line ping-pong would probably outweigh the cost of the
Hmm. I looked in the driver and saw numerous muram allocations, but I
didn't try to follow the driver enough to ensure that they were for the
It would be uncacheable on systems without coherent DMA, but I don't
No, unfortunately. PowerPC sync instructions are a bit complicated.
For example, you can use eieio to sync between reading the interrupt ...
| Mar 31, 7:37 am 2009 |
| Li Yang | Re: [PATCH] ucc_geth: Rework the TX logic.
On Tue, Mar 31, 2009 at 5:07 PM, Joakim Tjernlund
1 and 3 are the same. All of them use cacheable memory as we have a
hardware coherency module to take care of the cache coherency problem.
However it might be better to use dma_alloc_coherent() for the code
to be more readible. Thanks.
- Leo
--
| Mar 31, 3:58 am 2009 |
| Joakim Tjernlund | Re: [PATCH] ucc_geth: Rework the TX logic.
I am a bit confused, what isn't worth it? Currently MURAM isn't used by
ucc_geth, but
it is easy to change. Swap MEM_PART_SYSTEM to MEM_PART_MURAM, however,
just
tried that and the driver stopped working. I known this worked earlier
because
I tried it and I even think I sent a patch to Leo.
What choices do we have, I see three:
1) MEM_PART_SYSTEM, as today.
2) MEM_PART_MURAM. I guess this should be uncacheable memory?
3) as gianfar, dma_alloc_coherent(). I presume this is uncacheable ...
| Mar 31, 2:07 am 2009 |
| Kurt Van Dijck | Re: Network Device Naming mechanism and policy
My idea as a user, having configured some servers:
with kernel point of view, there should be no preference. If users
the problem here is the monotonic increasing order. I never rename ethX
back to the monotonic ethX numbering. IMHO, renaming eth0 to eth1 sounds
redundant.
I rename ethx to lan, wan, wlan, remote, lan0, lan1, ...
--
| Mar 31, 7:07 am 2009 |
| Eric W. Biederman | Re: [PATCH 2/2] sysctl: lockdep support for sysctl refe ...
Exactly.
I must have written an explanation so many times that it got
lost when I wrote that commit message.
In particular the problem can be see with /proc/sys/net/ipv4/conf/*/forwarding.
The problem is that the handler for fowarding takes the rtnl_lock
with the reference count held.
Then we call unregister_sysctl_table under the rtnl_lock.
If the refcount is to be considered a lock. sysctl_lock must be considered
the internals of that lock. lockdep gets extremely confused ...
| Mar 31, 6:40 am 2009 |
| Peter Zijlstra | Re: [PATCH 2/2] sysctl: lockdep support for sysctl refe ...
Usually lock internal locks still get lockdep coverage. Let see if we
can find a way for this to be true even here. I suspect the below to
There you acquire the table while holding the spinlock, generating:
sysctl_lock -> table_lock, however you then release the sysctl_lock and
re-acquire it, generating table_lock -> sysctl_lock.
Indeed, just checking.
--
| Mar 31, 8:35 am 2009 |
| Peter Zijlstra | Re: [PATCH 2/2] sysctl: lockdep support for sysctl refe ...
It would be very good to extend this changelog with a more detailed
explanation of the deadlock in question.
Let me see if I got it right:
We're holding a lock, while waiting for the refcount to drop to 0.
Dropping that refcount is blocked on that lock.
This means every sysctl thingy gets the same class, is that
intended/desired?
--
| Mar 31, 1:17 am 2009 |
| Eric W. Biederman | Re: [PATCH 2/2] sysctl: lockdep support for sysctl refe ...
That is an artifact of sysctl_lock being used to implement
table_lock as best as I can tell. The case you point
out I could probably play with where I claim the lock
is acquired and make it work.
__sysctl_head_next on the read side is trickier.
We come in with table_lock held for read.
We grab sysctl_lock.
We release table_lock (aka the reference count is decremented)
We grab table_lock on the next table (aka the reference count is incremented)
We release sysctl_lock
If we generate ...
| Mar 31, 3:44 pm 2009 |
| Eric W. Biederman | Re: [PATCH 2/2] sysctl: lockdep support for sysctl refe ...
In theory. In practice I removed the one case that could legitimately
--
| Mar 31, 1:47 am 2009 |
| Peter Zijlstra | Re: [PATCH 2/2] sysctl: lockdep support for sysctl refe ...
Ah, I was under the impression they weren't quite finished yet,
apparently I was mistaken.
Eric, didn't you need recursive locks fixed and such?
Let me have a look at them.
--
| Mar 31, 1:10 am 2009 |
| Kyle McMartin | Re: [PATCH] Phonet:fix build problem
Thanks! Sorted.
cheers, Kyle
--
| Mar 30, 8:07 pm 2009 |
| James Bottomley | Re: [PATCH] Phonet:fix build problem
You can add:
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
James
--
| Mar 30, 8:06 pm 2009 |
| Kyle McMartin | Re: [PATCH] Phonet:fix build problem
Oh, bah, want to resend that with a sign-off, James?
regards, Kyle
--
| Mar 30, 7:41 pm 2009 |
| Nobuhiro Iwamatsu | Re: [PATCH] sh_eth: Change handling of IRQ
I should have reported that these were taken in.
I will report it from the next time.
Best regards,
Nobuhiro
--
| Mar 30, 5:58 pm 2009 |
| Matt Carlson | Re: [Bugme-new] [Bug 12877] New: tg3: eth0 transit timed ...
Bernhard, any word on what happened?
--
| Mar 31, 9:26 am 2009 |
| Bernhard Schmidt | Re: [Bugme-new] [Bug 12877] New: tg3: eth0 transit timed ...
So far so good. In the last week my watchdog (cannot reach the default
gateway) triggered once, but since there were no "PCI Memory Mapped IO
Disabled!!!!" messages in the logfile I assume that was a real network
problem. Since the box ran fine for months initially and the first two
occurances of this issue were two weeks apart I cannot say for sure, but
it definitely feels better than the "once in two days" in the end.
Bernhard
--
| Mar 31, 3:16 pm 2009 |
| Yu Zhao | Re: [ANNOUNCE] New driver vxge for Neterion's X3100 seri ...
Xen upstream already supports the SR-IOV, and the native Linux and KVM
will be supporting it too when 2.6.30 comes out.
Intel 82576 driver has been patched to enable the SR-IOV capability:
http://patchwork.kernel.org/patch/8063/
http://patchwork.kernel.org/patch/8064/
http://patchwork.kernel.org/patch/8065/
http://patchwork.kernel.org/patch/8066/
Thought one of these patches uses the sysfs interface to receive the NumVFs
from user space, which is deprecated, rest of them still ...
| Mar 30, 11:13 pm 2009 |
| Leonid Grossman | RE: [ANNOUNCE] New driver vxge for Neterion's X3100 seri ...
Agreed - once SR-IOV support ships in Linux and Xen, using X3100
Multi-function mode becomes optional and the device can/will be used in
SR IOV mode. In other hypervisors, transition to SR IOV will take longer
time and Multi-function mode will be used for a while.
Enabling SR IOV mode should be transparent to vxge driver - the driver
has no SR IOV specific code, and we plan to use the same netdev driver
in both Linux and DomU Linux guest. Also (an optional) Xen Dom0
privileged vxge driver ...
| Mar 31, 7:38 am 2009 |
| Alexander Duyck | Re: [ANNOUNCE] New driver vxge for Neterion's X3100 seri ...
For the most part I think the bit you would be interested in is the
"sysfs" patch, http://patchwork.kernel.org/patch/8066/, which is what I
had used in the original implementation to enable the VFs. I am going
to push this to a module parameter similar to your max_config_dev. The
rest of the patches handle PF to VF communications and configuration
which it sounds like is handled via firmware for your adapter.
Most of the changes you would probably need to make would be in ...
| Mar 31, 10:50 am 2009 |
| Tantilov, Emil S | RE: [Updated patch] Re: [PATCH] igb: fix kexec with igb
The patch checks out. I tested suspend/resume (including WOL) and kexec. There is only a small issue with warning on compile when CONFIG_PM is disabled:
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index 13fe162..0a4f8f4 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -135,8 +135,8 @@ static inline int igb_set_vf_rlpml(struct igb_adapter *, int, int);
static int igb_set_vf_mac(struct igb_adapter *adapter, int, unsigned char *);
static void ...
| Mar 31, 12:14 pm 2009 |
| Rafael J. Wysocki | Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb
Fine with me.
Thanks,
Rafael
--
| Mar 31, 1:27 pm 2009 |
| Jeff Kirsher | Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb
On Tue, Mar 31, 2009 at 12:14 PM, Tantilov, Emil S
Rafael - Based on Emil's testing, I will modify the patch with Emil's
suggestion and push to Dave, ok?
--
Cheers,
Jeff
--
| Mar 31, 12:51 pm 2009 |
| Patrick Ohly | Re: TX time stamping
PTPd already only sends on one interface. How to deal with packets that
go out via multiple interfaces becomes relevant when generalizing the
I'm not familiar with AF_PACKET. It let's user space assemble the
complete packet (including Ethernet header) and send directly via a
specific interface, right?
The drawback is that the user space daemon would have to reimplement the
joining/leaving of a multicast group. When using the IP stack, it can
let the kernel do that.
It also still uses ...
| Mar 30, 11:53 pm 2009 |
| Jesper Dangaard Brouer | Re: [PATCH] netfilter: finer grained nf_conn locking
On Mon, 30 Mar 2009, Eric Dumazet wrote:
> Jesper Dangaard Brouer a
| Mar 31, 12:52 pm 2009 |
| Jesper Dangaard Brouer | Re: [PATCH] netfilter: finer grained nf_conn locking
Thanks a lot, I didn't know that!
(hint: cat /proc/cpuinfo | egrep -e 'processor|physical id|core id')
I sort of got a "too large" speedup on the Xeon system:
I want to use core 0 and 1 on physical CPU 0, for some strange reason CPU0
and CPU4 is these respective cores...
netperf -T 0,4 -l 60 -H localhost
TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to localhost (127.0.0.1) port 0 AF_INET : demo : cpu bind
Recv Send Send
Socket Socket Message Elapsed
Size Size ...
| Mar 31, 1:52 pm 2009 |
| Eric Dumazet | Re: [PATCH] netfilter: finer grained nf_conn locking
warning, because on my machine,
cpu0 is on physical id 0, core 0
cpu1 is on physical id 1, core 0
cpu2 is on physical id 0, core 1
cpu3 is on physical id 1, core 1
cpu3 is on physical id 0, core 2
cpu4 is on physical id 1, core 2
cpu5 is on physical id 0, core 3
cpu6 is on physical id 1, core 3
So -T 0,1 might not do what you think...
$ netperf -T 0,1 -l 120 -H localhost
TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to localhost.localdomain (127.0.0.1) port 0 AF_INET : cpu ...
| Mar 31, 1:23 pm 2009 |
| Rick Jones | Re: [PATCH] netfilter: finer grained nf_conn locking
Thanks. That makes a decent quantity of sense for a unidirectional test I
suppose. If you get bored you might see what happens with a burst
request/response test.
./configure --enbable-burst
make netperf
netperf -T 0,2 -t TCP_RR -c -C -- -b 64 -D
altering the parms to either -T or -b as you find necessary/desireable.
rick
--
| Mar 31, 1:35 pm 2009 |
| previous day | today | next day |
|---|---|---|
| March 30, 2009 | March 31, 2009 | April 1, 2009 |
