Home » Mailing list archives » linux-netdev » 2009 » March » 30

[PATCH 2/9] RDS/IW+IB: Set recv ring low water mark to 1/2 full.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andy Grover
Subject: [PATCH 2/9] RDS/IW+IB: Set recv ring low water mark to 1/2 full.
Date: Monday, March 30, 2009 - 11:44 am

From: Steve Wise <swise@opengridcomputing.com>

Currently the recv ring low water mark is 1/4 the depth.  Performance
measurements show that this limits iWARP throughput by flow controlling
the rds-stress senders.  Setting it to 1/2 seems to max the T3
performance.  I tried even higher levels but that didn't help and it
started to increase the rds thread cpu utilization.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Andy Grover <andy.grover@oracle.com>
---
 net/rds/ib_ring.c |    2 +-
 net/rds/iw_ring.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rds/ib_ring.c b/net/rds/ib_ring.c
index 99a6cca..ff97e8e 100644
--- a/net/rds/ib_ring.c
+++ b/net/rds/ib_ring.c
@@ -137,7 +137,7 @@ int rds_ib_ring_empty(struct rds_ib_work_ring *ring)
 
 int rds_ib_ring_low(struct rds_ib_work_ring *ring)
 {
-	return __rds_ib_ring_used(ring) <= (ring->w_nr >> 2);
+	return __rds_ib_ring_used(ring) <= (ring->w_nr >> 1);
 }
 
 /*
diff --git a/net/rds/iw_ring.c b/net/rds/iw_ring.c
index d422d4b..da8e3b6 100644
--- a/net/rds/iw_ring.c
+++ b/net/rds/iw_ring.c
@@ -137,7 +137,7 @@ int rds_iw_ring_empty(struct rds_iw_work_ring *ring)
 
 int rds_iw_ring_low(struct rds_iw_work_ring *ring)
 {
-	return __rds_iw_ring_used(ring) <= (ring->w_nr >> 2);
+	return __rds_iw_ring_used(ring) <= (ring->w_nr >> 1);
 }
 
 
-- 
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/9] RDS updates, Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 1/9] RDS: Fix m_rs_lock deadlock, Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 2/9] RDS/IW+IB: Set recv ring low water mark to 1/2 ..., Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 3/9] RDS: Correct some iw references in rdma_transp ..., Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 4/9] RDS/IW+IB: Set the RDS_LL_SEND_FULL bit when w ..., Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 5/9] RDS/IW+IB: Allow max credit advertise window., Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 6/9] RDS: Fix ordering in a conditional, Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 7/9] RDS: Establish connection before parsing CMSGs, Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 8/9] RDS: Rewrite connection cleanup, Andy Grover, (Mon Mar 30, 11:44 am)
[PATCH 9/9] RDS: use get_user_pages_fast(), Andy Grover, (Mon Mar 30, 11:44 am)
Re: [PATCH 6/9] RDS: Fix ordering in a conditional, Roland Dreier, (Mon Mar 30, 9:27 pm)
Re: [PATCH 6/9] RDS: Fix ordering in a conditional, Andrew Grover, (Mon Mar 30, 11:56 pm)
Re: [PATCH 6/9] RDS: Fix ordering in a conditional, David Miller, (Tue Mar 31, 2:50 pm)