Home » Mailing list archives » linux-netdev » 2009 » March » 30

Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oliver Neukum
Subject: Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
Date: Sunday, March 29, 2009 - 11:28 pm

Am Montag 30 März 2009 01:32:34 schrieb Larry Finger:

Thanks for this report and the patch. I think, however that it introduces
unneeded locking. It seems to me that we should be fine if we fix
kaweth_start_xmit(). That code assumes that it is called with interrupts
off and under a spinlock. Is that incorrect?

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/2] kaweth: Fix locking to be SMP-safe, Larry Finger, (Sun Mar 29, 4:32 pm)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Oliver Neukum, (Sun Mar 29, 11:28 pm)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Larry Finger, (Mon Mar 30, 8:58 am)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Oliver Neukum, (Tue Mar 31, 12:39 am)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Larry Finger, (Tue Mar 31, 7:55 am)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Oliver Neukum, (Tue Mar 31, 8:13 am)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Larry Finger, (Tue Mar 31, 8:24 am)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, Larry Finger, (Tue Mar 31, 11:40 am)
Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe, David Miller, (Tue Mar 31, 3:00 pm)