Re: [PATCH] drivers/net/b44.c: fix regressions in error recovery

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Sunday, March 29, 2009 - 1:48 pm

From: Christiaan Welvaart <cjw@daneel.dyndns.org>
Date: Sun, 29 Mar 2009 15:25:16 +0200 (CEST)


Firstly your patch was corrupted by your email client,
lots of whitespace damange at the beginning of lines etc.

And I don't necessarily agree with your change.

If the chip TX times out, we have no idea really what caused
the problem otherwise it wouldn't happen in the first place.
So resetting the PHY is definitely an appropriate course of
action.

You really need to find out why the chip is crapping out in
the first place, and fix that, to get rid of the delays.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] drivers/net/b44.c: fix regressions in error recovery, Christiaan Welvaart, (Sun Mar 29, 6:25 am)
Re: [PATCH] drivers/net/b44.c: fix regressions in error re ..., David Miller, (Sun Mar 29, 1:48 pm)