Home » Mailing list archives » linux-netdev » 2009 » March » 29

[PATCH 1/2]: gianfar: Fix use-after-of_node_put() in gfar_of_init().

Previous thread: [PATCH 2/2]: tg3: Add GRO support. by David Miller on Sunday, March 29, 2009 - 3:17 am. (1 message)

Next thread: [PATCH 2/2]: ucc_geth: Fix use-after-of_node_put() in ucc_geth_probe(). by David Miller on Sunday, March 29, 2009 - 3:18 am. (1 message)
[view original message]
From: David Miller
Subject: [PATCH 1/2]: gianfar: Fix use-after-of_node_put() in gfar_of_init().
Date: Sunday, March 29, 2009 - 3:18 am

We can't put 'mdio' until after we've used it in the
fsl_pq_mdio_bus_name() call.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/gianfar.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 6a38800..65f5587 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -289,9 +289,9 @@ static int gfar_of_init(struct net_device *dev)
 		id = of_get_property(phy, "reg", NULL);
 
 		of_node_put(phy);
-		of_node_put(mdio);
 
 		fsl_pq_mdio_bus_name(bus_name, mdio);
+		of_node_put(mdio);
 		snprintf(priv->phy_bus_id, sizeof(priv->phy_bus_id), "%s:%02x",
 				bus_name, *id);
 	}
-- 
1.6.2.1.222.g570cc

--


[ message continues ]
Previous thread: [PATCH 2/2]: tg3: Add GRO support. by David Miller on Sunday, March 29, 2009 - 3:17 am. (1 message)

Next thread: [PATCH 2/2]: ucc_geth: Fix use-after-of_node_put() in ucc_geth_probe(). by David Miller on Sunday, March 29, 2009 - 3:18 am. (1 message)