Home » Mailing list archives » linux-netdev » 2009 » March » 26

[patch] xfrm: spin_lock() should be spin_unlock() in xfrm_state.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Chuck Ebbert
Subject: [patch] xfrm: spin_lock() should be spin_unlock() in xfrm_state.c
Date: Thursday, March 26, 2009 - 3:58 pm

xfrm: spin_lock() should be spin_unlock() in xfrm_state.c

spin_lock() should be spin_unlock() in xfrm_state_walk_done().

caused by:
commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2
"ipsec: Put dumpers on the dump list"

Reported-by: Marc Milgram <mmilgram@redhat.com>
Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
---

--- linux-2.6.29.noarch.orig/net/xfrm/xfrm_state.c
+++ linux-2.6.29.noarch/net/xfrm/xfrm_state.c
@@ -1615,7 +1615,7 @@ void xfrm_state_walk_done(struct xfrm_st
 
 	spin_lock_bh(&xfrm_state_lock);
 	list_del(&walk->all);
-	spin_lock_bh(&xfrm_state_lock);
+	spin_unlock_bh(&xfrm_state_lock);
 }
 EXPORT_SYMBOL(xfrm_state_walk_done);
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] xfrm: spin_lock() should be spin_unlock() in xfrm_ ..., Chuck Ebbert, (Thu Mar 26, 3:58 pm)
Re: [patch] xfrm: spin_lock() should be spin_unlock() in x ..., Herbert Xu, (Thu Mar 26, 6:16 pm)
Re: [patch] xfrm: spin_lock() should be spin_unlock() in x ..., David Miller, (Fri Mar 27, 12:24 am)
Re: [patch] xfrm: spin_lock() should be spin_unlock() in x ..., Herbert Xu, (Fri Mar 27, 12:38 am)