Re: [PATCH] net: fix unaligned memory accesses in ASIX

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Thursday, March 26, 2009 - 1:08 am

From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Thu, 26 Mar 2009 07:52:39 +0100


There are some gratuitous (and wrong) changes in here:

 ...

It's a u32 whether you like it or not.  Please don't
change away from fixed sized types.

Also isn't there a way we can prefixed what this packet
offset is going to be?  If so, we can adjust the skb_reserve()
call the generic USB net code uses.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] net: fix unaligned memory accesses in ASIX, Giuseppe CAVALLARO, (Wed Mar 25, 11:52 pm)
Re: [PATCH] net: fix unaligned memory accesses in ASIX, David Miller, (Thu Mar 26, 1:08 am)
Re: [PATCH] net: fix unaligned memory accesses in ASIX, Giuseppe CAVALLARO, (Thu Mar 26, 1:40 am)
Re: [PATCH] net: fix unaligned memory accesses in ASIX, David Miller, (Thu Mar 26, 2:00 am)
Re: [PATCH] net: fix unaligned memory accesses in ASIX, Giuseppe CAVALLARO, (Thu Mar 26, 3:01 am)
Re: [PATCH] net: fix unaligned memory accesses in ASIX, David Miller, (Wed Apr 15, 3:14 am)