Home » Mailing list archives » linux-netdev » 2009 » March » 26

[PATCH] bridge: bad error handling when adding invalid ether address

Previous thread: Re: gianfar: reallocate skb when headroom is not enough for fcb by David Miller on Wednesday, March 25, 2009 - 5:21 pm. (9 messages)

Next thread: linux-next: net tree build warnings by Stephen Rothwell on Wednesday, March 25, 2009 - 11:37 pm. (8 messages)
[view original message]
From: Stephen Hemminger
Subject: [PATCH] bridge: bad error handling when adding invalid ether address
Date: Wednesday, March 25, 2009 - 8:57 pm

This fixes an crash when empty bond device is added to a bridge.
If an interface with invalid ethernet address (all zero) is added
to a bridge, then bridge code detects it when setting up the forward
databas entry. But the error unwind is broken, the bridge port object 
can get freed twice: once when ref count went to zeo, and once by kfree.
Since object is never really accessible, just free it.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
Patch against 2.6.29, but same code has been around for a while
in older releases, so should apply to 2.6.27.y as well.


--- a/net/bridge/br_if.c	2009-03-25 20:29:08.310404430 -0700
+++ b/net/bridge/br_if.c	2009-03-25 20:48:21.353468017 -0700
@@ -426,7 +426,6 @@ err2:
 err1:
 	kobject_del(&p->kobj);
 err0:
-	kobject_put(&p->kobj);
 	dev_set_promiscuity(dev, -1);
 put_back:
 	dev_put(dev);
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] bridge: bad error handling when adding invalid ether address
Date: Wednesday, March 25, 2009 - 9:01 pm

From: Stephen Hemminger <shemminger@vyatta.com>

Applied, thanks.
--


[ message continues ]
Previous thread: Re: gianfar: reallocate skb when headroom is not enough for fcb by David Miller on Wednesday, March 25, 2009 - 5:21 pm. (9 messages)

Next thread: linux-next: net tree build warnings by Stephen Rothwell on Wednesday, March 25, 2009 - 11:37 pm. (8 messages)