Re: 2.6.29 forcedeth hang W/O NAPI enabled

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Wednesday, March 25, 2009 - 5:05 pm

From: Adam Richter <adam_richter2004@yahoo.com>
Date: Wed, 25 Mar 2009 16:24:47 -0700 (PDT)


We're pretty sure we know exactly what commit causes this.

Can you try playing with a patch Jarek P. just posted in
the thread where this bug is being discussed?  (Subject:
Revert "gro: Fix legacy path napi_complete crash"):

diff --git a/net/core/dev.c b/net/core/dev.c
index e3fe5c7..cf53c24 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2589,7 +2589,11 @@ static int process_backlog(struct napi_struct *napi, int quota)
 		skb = __skb_dequeue(&queue->input_pkt_queue);
 		if (!skb) {
 			local_irq_enable();
-			napi_complete(napi);
+			napi_gro_flush(napi);
+			local_irq_disable();
+			if (skb_queue_empty(&queue->input_pkt_queue))
+				__napi_complete(napi);
+			local_irq_enable();
 			goto out;
 		}
 		local_irq_enable();

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: 2.6.29 forcedeth hang W/O NAPI enabled, Adam Richter, (Wed Mar 25, 4:24 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, David Miller, (Wed Mar 25, 5:05 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, Adam Richter, (Wed Mar 25, 6:20 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, David Miller, (Wed Mar 25, 8:14 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, Herbert Xu, (Wed Mar 25, 8:36 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, Adam Richter, (Wed Mar 25, 10:24 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, Herbert Xu, (Wed Mar 25, 11:58 pm)
Re: 2.6.29 forcedeth hang W/O NAPI enabled, Adam Richter, (Thu Mar 26, 4:29 pm)