linux-netdev mailing list

FromSubjectDatesort icon
Greg Kroah-Hartman
[PATCH 15/61] net: struct device - replace bus_id with d ...
From: Kay Sievers <kay.sievers@vrfy.org> Cc: davem@davemloft.net Cc: netdev@vger.kernel.org Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> --- drivers/net/arm/ks8695net.c | 2 +- drivers/net/au1000_eth.c | 8 ++++---- drivers/net/bfin_mac.c | 12 ++++++------ drivers/net/bmac.c | 2 +- drivers/net/cpmac.c | 2 +- drivers/net/declance.c | 6 +++--- drivers/net/depca.c | 6 ...
Mar 24, 5:26 pm 2009
Jeff Kirsher
[net-next PATCH] e1000e: add support for 82574 device ID ...
From: Bruce Allan <bruce.w.allan@intel.com> Add device ID for a new variant of the 82574 adapter. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Acked-by: John Ronciak <john.ronciak@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/e1000e/hw.h | 1 + drivers/net/e1000e/netdev.c | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000e/hw.h b/drivers/net/e1000e/hw.h index 11a2f20..d8b8229 100644 --- ...
Mar 24, 6:32 pm 2009
Brian Haley
[PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' module p ...
This is the quick and easy patch to add autoconf and disable_ipv6 module parameters to IPv6. I don't think anything more complicated is needed, assuming you play with the /etc configuration files. For example, if you wanted to enable IPv6 just on 'lo' you would: 1. Add "ipv6" to /etc/modules (if you don't, step #3 might fail) 2. Add this to /etc/modprobe.conf: options ipv6 disable_ipv6=1 3. Add these to ...
Mar 24, 6:49 pm 2009
Brian Haley
Re: PROBLEM: IPv6 autoconf/accept_ra default values
"default" is what's inherited by future devices, "all" is supposed to be the My patch wouldn't address getting a static address via a module parameter, that can still be done in, for example, /etc/network/interfaces. So no, this isn't I fixed the autoconf one, but this would still need to be addressed in a future patch, trying to sneak-in before the deadline. Might be too late... I sent the actual patch to netdev a few minutes ago for review. -Brian --
Mar 24, 6:49 pm 2009
Siemens News Center
Winner.........Siemens Promo
Your email ID has been awarded 750,000,00 GBP in our recent Siemens draw,Contact this office via: Name:.................... Country:................. Sex:..................... Age: ..................... Address:................... --
Mar 24, 6:53 pm 2009
Siemens News Center
Winner.........Siemens Promo
Your email ID has been awarded 750,000,00 GBP in our recent Siemens draw,Contact this office via: Name:.................... Country:................. Sex:..................... Age: ..................... Address:................... --
Mar 24, 6:53 pm 2009
Siemens News Center
Winner.........Siemens Promo
Your email ID has been awarded 750,000,00 GBP in our recent Siemens draw,Contact this office via: Name:.................... Country:................. Sex:..................... Age: ..................... Address:................... --
Mar 24, 6:53 pm 2009
Siemens News Center
Winner.........Siemens Promo
Your email ID has been awarded 750,000,00 GBP in our recent Siemens draw,Contact this office via: Name:.................... Country:................. Sex:..................... Age: ..................... Address:................... --
Mar 24, 6:53 pm 2009
Vlad Yasevich
Re: The Plan
Hi David Can you give any indication which way you are leaning on the IPv6 binding patches? I have some updates and can resubmit if you are planning on taking them. Thanks -vlad --
Mar 24, 7:03 pm 2009
David Miller
Re: The Plan
From: Vlad Yasevich <vladislav.yasevich@hp.com> Please send them sooner rather than later. --
Mar 24, 7:06 pm 2009
Vlad Yasevich
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
This is kind of confusing. First you say, disable IPv6, then you say enable IPv6, but nothing happens. Unless you typo-ed the 'all.disable_ipv6 = 0'... Also, it looks like if someone decides to switch IPv6 back on for a particular interface, they would have to wait until the next RA to get an address. Not an Why set 'all'? Since no interfaces are created yet, setting dflt accomplishes what you want. --
Mar 24, 7:12 pm 2009
Vlad Yasevich
[PATCH v2] ipv6: Fix bind conficts with v4-mapped addresses
This is an updated patch series to fix up bind() conflicts between v4-mapped and IPv6 addresses. These patches correct the following problems: 1) Disallow binding of a v4-mapped address on a IPV6_V6ONLY socket. 2) Allow IPv4 wildcards to bind at the same time as a native IPv6 address. 3) Make v4-mapped bind()s consitant with IPv4 native binds. 4) Fix conflict resolutions between v4-mapped addresses, v4 addresses, and v6 addresses Thanks -vlad --
Mar 24, 7:24 pm 2009
Vlad Yasevich
[PATCH v2 1/4] ipv6: Disallow binding to v4-mapped addre ...
A socket marked v6-only, can not receive or send traffic to v4-mapped addresses. Thus allowing binding to v4-mapped address on such a socket makes no sense. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- net/ipv6/af_inet6.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index fbf533c..7f092fa 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -276,6 +276,13 @@ int inet6_bind(struct socket ...
Mar 24, 7:24 pm 2009
Vlad Yasevich
[PATCH v2 2/4] ipv6: Allow ipv4 wildcard binds after ipv ...
The IPv4 wildcard (0.0.0.0) address does not intersect in any way with explicit IPv6 addresses. These two should be permitted, but the IPv4 conflict code checks the ipv6only bit as part of the test. Since binding to an explicit IPv6 address restricts the socket to only that IPv6 address, the side-effect is that the socket behaves as v6-only. By explicitely setting ipv6only in this case, allows the 2 binds to succeed. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- ...
Mar 24, 7:24 pm 2009
Vlad Yasevich
[PATCH v2 3/4] ipv6: Make v4-mapped bindings consitant w ...
Binding to a v4-mapped address on an AF_INET6 socket should produce the same result as binding to an IPv4 address on AF_INET socket. The two are interchangable as v4-mapped address is really a portability aid. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- net/ipv6/af_inet6.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index 9b6a37d..61f5538 100644 --- a/net/ipv6/af_inet6.c +++ ...
Mar 24, 7:24 pm 2009
Vlad Yasevich
[PATCH v2 4/4] ipv6: Fix conflict resolutions during ipv ...
The ipv6 version of bind_conflict code calls ipv6_rcv_saddr_equal() which at times wrongly identified intersections between addresses. It particularly broke down under a few instances and caused erroneouse bind conflicts. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- include/net/addrconf.h | 4 ++-- include/net/udp.h | 2 ++ net/ipv4/udp.c | 3 ++- net/ipv6/addrconf.c | 34 ---------------------------------- net/ipv6/udp.c | 28 ...
Mar 24, 7:24 pm 2009
Stephen Hemminger
Re: [PATCH 15/61] net: struct device - replace bus_id wi ...
On Tue, 24 Mar 2009 17:26:19 -0700 I know this is needed, but could please put some more explicit rational in changelog. --
Mar 24, 8:31 pm 2009
Jianjun Kong
[PATCH] net: remove two duplicated include
net: remove two duplicated include Signed-off-by: Jianjun Kong <jianjun@zeuux.org> --- drivers/net/atl1c/atl1c.h | 1 - drivers/net/dnet.c | 1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/atl1c/atl1c.h b/drivers/net/atl1c/atl1c.h index ac11b84..e1658ef 100644 --- a/drivers/net/atl1c/atl1c.h +++ b/drivers/net/atl1c/atl1c.h @@ -45,7 +45,6 @@ #include <linux/vmalloc.h> #include <linux/pagemap.h> #include <linux/tcp.h> -#include ...
Mar 24, 8:31 pm 2009
Eric Dumazet
Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
I have a litle problem on __nf_conntrack_find() being exported. Problem is that with SLAB_DESTROY_BY_RCU we must take a reference on object to recheck it. So ideally only nf_conntrack_find_get() should be used, or callers of __nf_conntrack_find() should lock nf_conntrack_lock (as properly done for example in net/netfilter/nf_conntrack_netlink.c, line 1292) Here is preliminary patch for review (not tested at all, its 4h50 am here :) ) Could you help me, by checking __nf_conntrack_find() ...
Mar 24, 8:53 pm 2009
Greg KH
Re: [PATCH 15/61] net: struct device - replace bus_id wi ...
bus_id is going away, much more rational isn't really needed :) thanks, greg k-h --
Mar 24, 9:18 pm 2009
Kolbjørn Barmen
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
Isnt this the normal way anyways, or do new interfaces send some sort of "I'm new here, give me a prefix and router announcement, please!" normally How do you know that no interfaces are created? The IPv6 modules might not -- kolla --
Mar 24, 9:28 pm 2009
David Miller
Re: [PATCH] net: remove two duplicated include
From: Jianjun Kong <jianjun@zeuux.org> This one is already in the net-next-2.6 tree --
Mar 24, 11:24 pm 2009
David Miller
Re: [PATCH v2] ipv6: Fix bind conficts with v4-mapped ad ...
From: Vlad Yasevich <vladislav.yasevich@hp.com> All applied, thanks Vlad. --
Mar 24, 11:27 pm 2009
David Miller
Re: [net-next PATCH] e1000e: add support for 82574 devic ...
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Applied, thanks. --
Mar 24, 11:28 pm 2009
David Miller
Re: [PATCH 15/61] net: struct device - replace bus_id wi ...
From: Greg Kroah-Hartman <gregkh@suse.de> None of this patch applies to net-next-2.6 Probably because, just like the wimax case, these changes are already there. --
Mar 24, 11:29 pm 2009
David Miller
Re: [PATCH 1/2] drivers/net/ax88796.c: take IRQ flags fr ...
From: Daniel Mack <daniel@caiaq.de> Applied. --
Mar 24, 11:31 pm 2009
David Miller
Re: [PATCH 2/2] ax88796: Add method to take MAC from pla ...
From: Daniel Mack <daniel@caiaq.de> Also applied, thanks. --
Mar 24, 11:32 pm 2009
David Miller
Re: igbvf: add new driver to support 82576 virtual functions
This breaks the build: drivers/net/igbvf/ethtool.c: In function 'igbvf_set_ringparam': drivers/net/igbvf/ethtool.c:299: error: implicit declaration of function 'vmalloc' drivers/net/igbvf/ethtool.c:299: warning: assignment makes pointer from integer without a cast drivers/net/igbvf/ethtool.c:346: error: implicit declaration of function 'vfree' --
Mar 24, 11:38 pm 2009
David Miller
Re: [PATCH] net/bridge: use the maximum hard_header_len ...
From: Li Yang <leoli@freescale.com> Your driver must be able to cope with any amount of available headroom, no matter what hacks we put into the bridging layer. Please fix your driver, I'm not applying this patch. --
Mar 24, 11:40 pm 2009
David Miller
Re: [RFC] net: release dst entry in dev_queue_xmit()
From: Eric Dumazet <dada1@cosmosbay.com> This will break various packet schedulers and classifiers. Heck sch_sfq.c even uses skb->dst as part of it's flow hash function :-) --
Mar 24, 11:43 pm 2009
frank.blaschka
[patch 0/6] s390: qeth fixes for 2.6.30
Hi Dave, here are a couple of qeth fixes for 2.6.30 shortlog: Kay Sievers (1) qeth: struct device - replace bus_id with dev_name(), dev_set_name() Klaus-Dieter Wacker (1) qeth: unregister MAC addresses during recovery Ursula Braun (1) qeth: check for completion of a running recovery Heiko Carstens(1) qeth: fix wait_event_timeout handling Frank Blaschka (2) qeth: add statistics for tx csum qeth: remove EDDP Thanks, Frank --
Mar 24, 11:57 pm 2009
frank.blaschka
[patch 1/6] [PATCH] qeth: struct device - replace bus_id ...
From: Kay Sievers <kay.sievers@vrfy.org> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_l3_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -urpN linux-2.6/drivers/s390/net/qeth_l3_main.c ...
Mar 24, 11:57 pm 2009
frank.blaschka
[patch 2/6] [PATCH] qeth: add statistics for tx csum
From: Frank Blaschka <frank.blaschka@de.ibm.com> Add statistics counter for software tx checksumming. Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_core.h | 1 + drivers/s390/net/qeth_core_main.c | 2 ++ drivers/s390/net/qeth_l2_main.c | 5 ++++- drivers/s390/net/qeth_l3_main.c | 5 ++++- 4 files changed, 11 insertions(+), 2 deletions(-) diff -urpN linux-2.6/drivers/s390/net/qeth_core.h ...
Mar 24, 11:57 pm 2009
frank.blaschka
[patch 3/6] [PATCH] qeth: remove EDDP
From: Frank Blaschka <frank.blaschka@de.ibm.com> Performance measurements showed EDDP does not lower CPU costs but increase them. So we dump out EDDP code from qeth driver. Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/Makefile | 2 drivers/s390/net/qeth_core.h | 7 drivers/s390/net/qeth_core_main.c | 99 +---- drivers/s390/net/qeth_core_offl.c | 699 -------------------------------------- drivers/s390/net/qeth_core_offl.h | 76 ...
Mar 24, 11:57 pm 2009
frank.blaschka
[patch 4/6] [PATCH] qeth: unregister MAC addresses durin ...
From: Klaus-Dieter Wacker <kdwacker@de.ibm.com> qeth: Unregister MAC addresses from device (layer 2) during recovery cycle. When the device is set online the MAC addresses are registered again on the device. Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_l2_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff -urpN linux-2.6/drivers/s390/net/qeth_l2_main.c ...
Mar 24, 11:57 pm 2009
frank.blaschka
[patch 5/6] [PATCH] qeth: check for completion of a runn ...
From: Ursula Braun <ursula.braun@de.ibm.com> When a recovery is started for a qeth device, additional invocations to change a mac address, to configure a VLAN interface on top, or to add multicast addresses should wait till recovery is finished, otherwise recovery might fail. Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_l2_main.c | 15 +++++++++++++++ drivers/s390/net/qeth_l3_main.c | 7 ...
Mar 24, 11:57 pm 2009
frank.blaschka
[patch 6/6] [PATCH] qeth: fix wait_event_timeout handling
From: Heiko Carstens <heiko.carstens@de.ibm.com> wait_event_timeout just takes the numnber of jiffies to wait as an argument. That value does not include jiffies itself. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_core_main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) Index: ...
Mar 24, 11:57 pm 2009
David Miller
Re: rndis_wlan netdev ops
From: David Miller <davem@davemloft.net> Here is how I ended up fixing this: rndis_wlan: Fix build with netdev_ops compat disabled. Instead of storing a private ->set_multicast_list, just have a private netdev ops. Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/wireless/rndis_wlan.c | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c index 82af21e..db91db7 ...
Mar 25, 12:04 am 2009
Li Yang
Re: [PATCH] net/bridge: use the maximum hard_header_len ...
Ok. But it's not good to reallocate every packet generated locally. Why not take this patch too? - Leo --
Mar 25, 12:05 am 2009
David Miller
Re: [PATCH] net/bridge: use the maximum hard_header_len ...
From: Li Yang <leoli@freescale.com> Because as Stephen showed it didn't handle all cases. Look at the patch I posted, that's the way to go. --
Mar 25, 12:06 am 2009
David Miller
Re: [patch 0/6] s390: qeth fixes for 2.6.30
From: frank.blaschka@de.ibm.com Any particular reason you wait until right when the merge window opens to send me stuff? I said on netdev that I wanted to empty my patchwork queue then submit the tree to Linus. So then you send me more stuff on top of that? :-/ Your EDDP was slow because the implementation was incredibly sub-optimal. %90 of the code is doing copies and fiddling with SKB internals. --
Mar 25, 12:08 am 2009
Patrick Ohly
Re: TX time stamping
Hello Dave, Herbert! Agreed. It never was the goal to somehow force this into the kernel unless you are happy with it - not that this would have worked anyway ;-) I'd be happy to discuss better ways of solving these issues; the current patches work, but they have their shortcomings. There's no point in including them when you don't deem them sufficient. As I said in my initial email in this thread, I don't know a better solution and depend on some guidance by experts in this area. When ...
Mar 25, 12:08 am 2009
Eric Dumazet
Re: [RFC] net: release dst entry in dev_queue_xmit()
Well, as one of the hash perturbator, for other protocols than IPV4 & IPV6... default: h = (unsigned long)skb->dst ^ skb->protocol; h2 = (unsigned long)skb->sk; } return sfq_fold_hash(q, h, h2); But teql indeed mandates dst in __teql_resolve() Darn... This dst freeing should be done very late then, in the NIC driver itself, just before giving skb to hardware, or right before in dev_hard_start_xmit() If done in ...
Mar 25, 12:13 am 2009
David Miller
Re: [RFC] net: release dst entry in dev_queue_xmit()
From: Eric Dumazet <dada1@cosmosbay.com> Usually it should be OK because the packet schedulers have a sort-of one-behind state that allows them to reinsert the SKB into their queue datastructures without reclassifying. But I'm not %100 sure there isn't some case that might still need skb->dst there. --
Mar 25, 12:17 am 2009
David Miller
Re: [net-2.6 PATCH 3/10] Neterion: New driver: pci_ids
From: Ramkrishna Vepa <ram.vepa@neterion.com> This file is deprecated. If your driver is the only place that needs this PCI ID just use the constant there. --
Mar 25, 1:06 am 2009
Marco Berizzi
Re: network traffic stop with 2.6.29 after ftp put
no, it doesn't fix the problem. This morning I got the same problem (I was reading the kernel mailing list on lkml.indiana.edu with firefox) --
Mar 25, 1:10 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 0/10] Neterion: New driver: vxge: Resubmission
The following series of 10 patches are a resubmission of Neterion's new driver, "vxge", for our latest PCIe based X3100 10GbE Server/Storage Adapter. Changes from the last submission include fixes from comments from Ben Hutchings, Andi Kleen, Bill Fink and David Miller. The details of the fixes are in the individual patches. Regards, Ram --
Mar 25, 1:12 am 2009
David Miller
Re: [net-2.6 PATCH 5/10] Neterion: New driver: Hardware ...
From: Ramkrishna Vepa <ram.vepa@neterion.com> This driver won't build on 32-bit platforms, not even x86. You didn't build test on i386? You have to provide a readq/writeq implementation on 32-bit machines so that you can choose in what order it is safe to read/write the upper and lower 32-bit halfs of a 64-bit register. See the following from drivers/net/niu.c: #ifndef readq static u64 readq(void __iomem *reg) { return ((u64) readl(reg)) | (((u64) readl(reg + 4UL)) << ...
Mar 25, 1:12 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 0/10] Neterion: New driver: vxge: Resubmission
The following series of 10 patches are a resubmission of Neterion's new driver, "vxge", for our latest PCIe based X3100 10GbE Server/Storage Adapter. Changes from the last submission include fixes from comments from Ben Hutchings, Andi Kleen, Bill Fink and David Miller. The details of the fixes are in the individual patches. Regards, Ram --
Mar 25, 1:12 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
- vxge driver help text file. - Changes from previous submission - - Incorporated following fixes based on comments from Ben Hutchings Removed references to earlier kernel versions. Removed sections that are similar for all drivers - Load/Unload Identifying the adapter/interface Boot time configuration Removed loadable parameter - NAPI - Napi is always enabled. rx_steering_type & ring_blocks - The driver default settings work well in most if not all cases. Another patch to ...
Mar 25, 1:12 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 2/10] Neterion: New driver: Update Mainta ...
- update to Maintainer list of S2IO 10GbE drivers (xframe / vxge). Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com> Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com> --- diff -Nurp patch_1/MAINTAINERS patch_2/MAINTAINERS --- patch_1/MAINTAINERS 2009-03-23 09:17:41.000000000 -0700 +++ patch_2/MAINTAINERS 2009-03-23 09:17:41.000000000 -0700 @@ -3079,7 +3079,7 @@ M: shemminger@linux-foundation.org ...
Mar 25, 1:12 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 3/10] Neterion: New driver: pci_ids
- Update device ID of X3100 Series 10GbE PCIe I/O Virtualized Server Adapter. Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com> Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com> --- diff -Nurp patch_2/include/linux/pci_ids.h patch_3/include/linux/pci_ids.h --- patch_2/include/linux/pci_ids.h 2009-03-23 09:17:41.000000000 -0700 +++ patch_3/include/linux/pci_ids.h 2009-03-23 09:17:41.000000000 -0700 @@ ...
Mar 25, 1:12 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 4/10] Neterion: New driver: register set ...
- Complete Register map details of Neterion Inc's X3100 Series 10GbE PCIe I/O Virtualized Server Adapter. - Changes from previous submission - - Incorporated following comments from Ben Hutchings - Use original macros for endian checks - Remove VXGE_OS_PLATFORM_* macros as they are unused. - Converted multiple bVALX macros into single with additional width parameter and renamed it to vxge_bVALn. - Using __packed instead of pragma pack(1) - ...
Mar 25, 1:12 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 5/10] Neterion: New driver: Hardware init ...
This patch takes care of Initialization and configuration steps of Neterion Inc's X3100 Series 10GbE PCIe I/O Virtualized Server Adapter. - Device Initialization. - Verification and setting of device config parameters. - Allocation of Tx FIFO and Rx Ring descriptors (DTR). - APIs to get various type of hw stats - APIs to configure RTS (Receive Traffic Steering) - Changes from previous submission - - Incorporated following comments from Ben Hutchings - Start a comment with "/**" to make ...
Mar 25, 1:13 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 6/10] Neterion: New driver: Traffic & ala ...
This patch takes care of trafic handling related APIS. - Interrupt Enable and disable - Mask / Unmask Interrupt - Traffic Interrupt handling. - Alarm Interrupt handling. - Changes from previous submission - - General cleanup - removed unused functions and variables. - Use asserts where necessary - Reported by Andi Kleen - Fixed sparse warnings - Reported by Andi Kleen - Use a prefix, "__vxge" in front of hw functions to make them globally unique - Ben Hutchings Signed-off-by: ...
Mar 25, 1:13 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 7/10] Neterion: New driver: Main entry points
This patch implements all the driver entry point functions. - Definition of all module loadable paramters. - Implementation of all driver entry point functions. - Changes from previous submission - - Incorporated following review comments from Ben Hutchings - NAPI is always enabled (no option to turn it OFF). - Loadable parameters rx_steering_type: This loadable option is removed. ring_blocks: This loadable option is removed. The driver default settings work well in most if not all ...
Mar 25, 1:13 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 8/10] Neterion: New driver: Ethtool related
This patch implements all ethtool related entry point functions for the driver. - Changes from previous submission - - Incorporated following comments from Ben Hutchings - No need to restart the interface in vxge_ethtool_sset - Do not use #ifdef ADVERTISED_XX - Remove unnecessart intermediate copy in vxge_ethtool_gdrvinfo - Use strlcpy() to ensure null-termination. - Use ethtool_op_get_tso, ethtool_op_set_tx_hw_csum instead of redefining the ...
Mar 25, 1:13 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 9/10] Neterion: New driver: Driver version
- Driver version - Changes from previous submission - - Updated driver version. Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com> Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com> --- diff -Nurp patch_8/drivers/net/vxge/vxge-version.h patch_9/drivers/net/vxge/vxge-version.h --- patch_8/drivers/net/vxge/vxge-version.h 1969-12-31 16:00:00.000000000 -0800 +++ ...
Mar 25, 1:13 am 2009
Ramkrishna Vepa
[net-2.6 PATCH 10/10] Neterion: New driver: Kconfig and ...
- Kconfig and Makefile related changes for vxge driver. - Changes from previous submission - - Incorporated the following review comments as per Bill Flink: - Add dependancy on INET along with PCI - Remove dependancy on INET_LRO and add GRO support. - Made this patch as last patch as per Ben Hutchings comments. Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com> Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com> Signed-off-by: Ramkrishna Vepa ...
Mar 25, 1:13 am 2009
Frank Blaschka
Re: [patch 0/6] s390: qeth fixes for 2.6.30
Sorry, this was by accident. Next time I will send the patches I did not wrote the EDDP code but this was my impression too. Thanks for confirming my study. Also the filling of the hardware buffers was not efficient and passing more buffers to the hw was expensive too. --
Mar 25, 1:25 am 2009
Ramkrishna Vepa
RE: [net-2.6 PATCH 5/10] Neterion: New driver: Hardware ...
I missed that one! Yes, it was only tested on 64 bit kernels. The following macros were removed/deleted by mistake. We'll make these changes, check and submit. #ifndef readq static inline u64 readq(void *addr) { u64 ret = 0; ret = readl(addr + 4); ret <<= 32; ret |= readl(addr); return ret; } #endif #ifndef writeq static inline void writeq(u64 val, void *addr) { writel((u32) (val), addr); writel((u32) (val >> 32), (addr + ...
Mar 25, 1:25 am 2009
Li Yang
Re: [PATCH] net/bridge: use the maximum hard_header_len ...
Patch coming right away. However I have some comment about your way. The choice is yours. - Leo --
Mar 25, 1:38 am 2009
Li Yang
Re: [PATCH] net/bridge: use the maximum hard_header_len ...
Dynamically adjusting is a good idea, but the rx_alloc_extra can only go up not the other way down in your code. Another thought is that if you re-allocate skb here the driver would be saved from checking the headroom in the fastpath, am I right? - Leo --
Mar 25, 1:43 am 2009
Jeff Kirsher
Re: igbvf: add new driver to support 82576 virtual functions
Sorry Dave, I thought this was called out earlier, but I see it was not. The igbvf driver requires the following patches applied to your tree to have them compile. Last I heard, these SR-IOV patches were accepted for 2.6.30, in the PCI tree. Yu, can you confirm that these patches have been accepted for ...
Mar 25, 1:45 am 2009
Jeff Kirsher
Re: igbvf: add new driver to support 82576 virtual functions
On Wed, Mar 25, 2009 at 1:45 AM, Jeff Kirsher I confirmed that Jesse Barnes has these SR-IOV patches queued up for 2.6.30. http://marc.info/?l=linux-kernel&m=123757169806111&w=2 -- Cheers, Jeff --
Mar 25, 2:03 am 2009
Li Yang
[PATCH] gianfar: reallocate skb when headroom is not eno ...
Gianfar uses a hardware header FCB for offloading. However when used with bridging or IP forwarding, TX skb might not have enough headroom for the FCB. Reallocate skb for such cases. Signed-off-by: Li Yang <leoli@freescale.com> --- drivers/net/gianfar.c | 31 +++++++++++++++++++++---------- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 9831b3f..29dc4ee 100644 --- a/drivers/net/gianfar.c +++ ...
Mar 25, 2:15 am 2009
Florian Fainelli
[PATCH 1/2] r6040: Fix second PHY address
This patch fixes the second PHY address which is strapped to be at PHY address 3 instead of 2. Signed-off-by: Florian Fainelli <florian@openwrt.org> --- diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c index 9c95ebe..d3458ef 100644 --- a/drivers/net/r6040.c +++ b/drivers/net/r6040.c @@ -54,7 +54,7 @@ /* PHY CHIP Address */ #define PHY1_ADDR 1 /* For MAC1 */ -#define PHY2_ADDR 2 /* For MAC2 */ +#define PHY2_ADDR 3 /* For MAC2 */ #define PHY_MODE 0x3100 /* PHY CHIP Register 0 ...
Mar 25, 2:34 am 2009
Florian Fainelli
[PATCH 2/2] Bump release date to 25Mar2009 and version to 0.22
This patch bumps the driver release date to March 25th 2009 and release version to 0.22. Signed-off-by: Florian Fainelli <florian@openwrt.org> --- diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c index d3458ef..0a37f99 100644 --- a/drivers/net/r6040.c +++ b/drivers/net/r6040.c @@ -49,8 +49,8 @@ #include <asm/processor.h> #define DRV_NAME "r6040" -#define DRV_VERSION "0.21" -#define DRV_RELDATE "09Jan2009" +#define DRV_VERSION "0.22" +#define DRV_RELDATE "25Mar2009" /* PHY ...
Mar 25, 2:34 am 2009
Kay Sievers
Re: [PATCH 15/61] net: struct device - replace bus_id wi ...
Yeah, I think -next handles duplicate and completely indentical patches from differnt trees just fine, so that all has been in -next for a while, and while it was still in Greg's tree when the other tree merged it. This patch is in your -next tree: http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commit;h=db1d7bf70f... The problem with -next is that if some tree is dropped because of a non-trivial conflict, and Greg removes merged patches, ...
Mar 25, 2:34 am 2009
Yu Zhao Mar 25, 2:47 am 2009
Andi Kleen
Re: netfilter 07/41: arp_tables: unfold two critical loo ...
Newer gcc often[1] knows how to generate specialized aligned memcmp() based on the type alignment. However you need to make sure the input types are right. So in theories some casts might be enough given a new enough compiler. [1] not always unfortunately, sometimes it loses this information. -Andi -- ak@linux.intel.com -- Speaking for myself only. --
Mar 25, 3:33 am 2009
Eric Dumazet
[PATCH] netfilter: factorize ifname_compare()
Here is a patch to factorize these functions, as suggested by Jan Thank you [PATCH] netfilter: factorize ifname_compare() We use same not trivial helper function in four places. We can factorize it. Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> --- include/linux/netfilter/x_tables.h | 23 +++++++++++++++++++++++ net/ipv4/netfilter/arp_tables.c | 14 +------------- net/ipv4/netfilter/ip_tables.c | 23 ++--------------------- net/ipv6/netfilter/ip6_tables.c | 23 ...
Mar 25, 4:27 am 2009
Sachin Sant
Next March 25: net/netfilter/xt_LED build failure.
Today's next randconfig build on x86 failed with following error. net/netfilter/xt_LED.c:40: error: field netfilter_led_trigger has incomplete type net/netfilter/xt_LED.c: In function led_timeout_callback: net/netfilter/xt_LED.c:78: warning: unused variable ledinternal net/netfilter/xt_LED.c: In function led_tg_check: net/netfilter/xt_LED.c:102: error: implicit declaration of function led_trigger_register net/netfilter/xt_LED.c: In function led_tg_destroy: net/netfilter/xt_LED.c:135: error: ...
Mar 25, 4:34 am 2009
Vlad Yasevich
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
When the interface first comes up, it sends a Router Solicitation that triggers Ah, but the IPv6 portions of the interface are created by the ipv6 module when it loads. At the addrconf_init_net() time, no interface are created yet. -vlad --
Mar 25, 4:51 am 2009
Herbert Xu
Re: network traffic stop with 2.6.29 after ftp put
Please try the full GRO revert for netif_rx that I just posted. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Mar 25, 5:09 am 2009
Vlad Yasevich
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
Oh, and another issue I just figured out this morning... You are letting link-locals to autoconfigure, but did not correctly finish DAD, because once you set disable_ipv6, ip6_output and ipv6_rcv will drop all IPv6 packets. Then later, when you re-enable IPv6, you will not run DAD because the interface will think that it's already finished. So there is a possibility of duplicates not being detected. --
Mar 25, 5:36 am 2009
Jiri Pirko
[PATCH] bonding: allow bond in mode balance-alb to work ...
(resend) Hi all. The problem is described in following bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=487763 Basically here's what's going on. In every mode, bonding interface uses the same mac address for all enslaved devices. Except for mode balance-alb. When you put this kind of bond device into a bridge it will only add one of mac adresses into a hash list of mac addresses, say X. This mac address is marked as local. But this bonding interface also has mac address Y. Now then ...
Mar 25, 6:04 am 2009
Global Promo
Short Notice (Winners Alert!!!)
You have just been awarded,the sum of £950.000.00 GBP in the Global Online Promotion, Anniversary Bonanza. held March. For Claims email your details to: glo.pro_alert@btinternet.com Names:...... Address:....... Country:........ Age:....... Sex:......... Phone/cellphone........ regard Mrs Joan Thoms --
Mar 25, 6:21 am 2009
Ilpo Järvinen
Re: [Bugme-new] [Bug 12327] New: Intermittent TCP issues ...
They are included in, commits: a2bd40ad3151d4d346fd167e01fb84b06f7247fc 47e0e1ca13d64eeeb687995fbe4e239e743d7544 I think they are in 2.9.29-rc2 already and thus in 2.6.29 (if I read gitk's output correctly). -- i. --
Mar 25, 6:26 am 2009
Joakim Tjernlund
[PATCH] ucc_geth: Move freeing of TX packets to NAPI context.
>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> Date: Tue, 24 Mar 2009 10:19:27 +0100 Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. Also increase NAPI weight somewhat. This will make the system alot more responsive while ping flooding the ucc_geth ethernet interaface. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> --- drivers/net/ucc_geth.c | 30 ...
Mar 25, 6:30 am 2009
Patrick McHardy
Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
In case of xt_connlimit, it seems fine to just take a reference. In case of ctnetlink, keeping the unreferenced lookup under the lock seems fine. We unfortunately have to export some internals like nf_conntrack lock for ctnetlink anyways, so I don't think it would be worth to change it to take references and unexport Are you sure this is enough? An entry might have been reused and added --
Mar 25, 6:39 am 2009
Eric Dumazet Mar 25, 6:40 am 2009
Eric Dumazet
Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
check net/ipv4/udp.c for an example (__udp4_lib_lookup()) In case of UDP, key check is not returning true/false, but a score. So UDP case is a litle bit more complex than conntrack case. rcu_read_lock(); begin: result = NULL; badness = -1; sk_nulls_for_each_rcu(sk, node, &hslot->head) { score = compute_score(sk, net, saddr, hnum, sport, daddr, dport, dif); if (score > badness) { ...
Mar 25, 6:44 am 2009
Subrata Modak
[PATCH] Re: Next March 25: net/netfilter/xt_LED build failure.
The following patch will solve the build problem reported by Sachin. But would leave the following warnings. I hope we can ignore them: net/netfilter/xt_LED.c: In function ‘led_timeout_callback’: net/netfilter/xt_LED.c:78: warning: unused variable ‘ledinternal’ net/netfilter/xt_LED.c: In function ‘led_tg_check’: net/netfilter/xt_LED.c:87: warning: unused variable ‘err’ Signed-Off-By: Subrata Modak<subrata@linux.vnet.ibm.com> --- --- a/linux-2.6.29/include/linux/leds.h 2009-03-25 ...
Mar 25, 6:57 am 2009
Anthony Mar 25, 6:59 am 2009
Eric Dumazet
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
Cant you test (ucce & UCCE_TX_EVENTS) or something here to avoid Why tx completions dont change "howmany" ? --
Mar 25, 7:04 am 2009
Patrick McHardy Mar 25, 7:08 am 2009
Anton Vorontsov
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
Some time ago I've tried a similar thing for this driver, but during tcp (or udp I don't quite remember) netperf tests I was getting tx watchdog timeouts after ~2-5 minutes of work. I was testing with a gigabit and 100 Mbit link, with 100 Mbit link the issue was not reproducible. Though, I recalling I was doing a bit more than your patch: I was also clearing the TX events in the ucce register before calling ucc_geth_tx, that way I was trying to avoid stale interrupts. That helped to increase ...
Mar 25, 7:25 am 2009
Subrata Modak
Re: [PATCH] Re: Next March 25: net/netfilter/xt_LED buil ...
Sorry, yes it does for make. But i was executing: Thanks. Regards-- Subrata --
Mar 25, 7:31 am 2009
Patrick McHardy Mar 25, 7:34 am 2009
Jiri Pirko Mar 25, 7:39 am 2009
Thierry Reding
Re: [PATCH] net: Add support for the OpenCores 10/100 Mb ...
I did look at the uClinux driver at some point, but decided to rewrite it- from scratch. But to be honest it's been quite some time since I started work on this and I'm not a 100% certain that one part or another may not be borrowed from it. I think this is a good idea, but I'm not quite sure about how this should be implemented. The total number of buffers is dependent on the total buffer size as defined by the second IORESOURCE_MEM resource. That really only leaves the option for ...
Mar 25, 7:43 am 2009
Thierry Reding
Re: [PATCH] net: Add support for the OpenCores 10/100 Mb ...
Actually these special padding cases are only necessary for the FPGA interface we use and have nothing to do with the OpenCores Ethernet MAC itself. The ARM memcpy_{to,from}io() functions don't work correctly with my setup because our VLIO bridge implementation apparently doesn't handle byte-wise accesses very well. I can work around that by implementing the memcpy_{to,from}io() functions differently, though. That may however break anything else using those See follow-up patch in reply to ...
Mar 25, 7:52 am 2009
Thierry Reding
Re: [PATCH] net: Add support for the OpenCores 10/100 Mb ...
[snip] Yes, ether_crc() does the trick. See follow-up patch. Thanks. Cheers, Thierry --
Mar 25, 7:55 am 2009
Thierry Reding
[PATCH v2] net: Add support for the OpenCores 10/100 Mbp ...
This patch adds a platform device driver that supports the OpenCores 10/100 Mbps Ethernet MAC. The driver expects three resources: one IORESOURCE_MEM resource defines the memory region for the core's memory-mapped registers while a second IORESOURCE_MEM resource defines the network packet buffer space. The third resource, of type IORESOURCE_IRQ, associates an interrupt with the driver. Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> Acked-by: Florian Fainelli ...
Mar 25, 7:57 am 2009
Joakim Tjernlund
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
Probably, but I want this patch as simple as possible. There account tx event above... This is unclear and last I checked not very common amongst other drivers in the tree. UCC_GETH_DEV_WEIGHT needs to be a bit bigger than the number of RX HW buffers avaliable, otherwise one won't be able to drain the whole queue in one go. Changing weight to something bigger made a big difference. Jocke --
Mar 25, 8:16 am 2009
Jiri Pirko
[PATCH] bonding: allow bond in mode balance-alb to work ...
(resend, using compare_ether_addr_64bits instead of memcmp) Hi all. The problem is described in following bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=487763 Basically here's what's going on. In every mode, bonding interface uses the same mac address for all enslaved devices. Except for mode balance-alb. When you put this kind of bond device into a bridge it will only add one of mac adresses into a hash list of mac addresses, say X. This mac address is marked as local. But this ...
Mar 25, 8:19 am 2009
Joakim Tjernlund
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
Ran this on my host against my target board: netperf -t UDP_RR -H 192.168.1.16 netperf -t UDP_STREAM -H 192.168.1.16 netperf -t TCP_STREAM -H 192.168.1.16 netperf -t TCP_SENDFILE -H 192.168.1.16 netperf -t TCP_MAERTS -H 192.168.1.16 netperf -t TCP_RR -H 192.168.1.16 netperf -t TCP_CRR -H 192.168.1.16 Didn't notice any timeouts, but I only have 100Mbit interfaces. --
Mar 25, 8:21 am 2009
Brian Haley
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
Well, at least on my test system, this worked. Loading the IPv6 module with disable_ipv6=1 sets the .all and .default (and all interfaces) to disable, then sysctl turns them back on selectively. If you don't enable the .all.disable_ipv6 knob nothing will actually work - see the change in addrconf_prefix_rcv(). You still have to enable it on each Yes, if someone later-on enables IPv6 on an interface they'll need to Yeah, that's probably not necessary, I assumed if the user passed the ...
Mar 25, 8:22 am 2009
Brian Haley
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
No, the module parameter disabled it, but we need to re-enable the .all.disable_ipv6 knob in order for lo to be able to configure itself. If I follow Vlad's advice of only setting the .default knob then you I'll see about putting in a callback to send a router solicitation. But on the flip side if someone changes eth0.disable_ipv6=0 to 1, we won't be removing the address either. An ifdown/ifup cycle would remove the need for us to do anything here. -Brian --
Mar 25, 8:28 am 2009
Stephen Hemminger
Re: [net-2.6 PATCH 7/10] Neterion: New driver: Main entr ...
On 25 Mar 2009 00:13:33 -0800 Module parameters are a method of last resort. Module parameters are a pain for customers because they are hard to configure, and only work on one device driver. They should not be used if anything else is available. Therefore the following can be replaced by existing ethtool hooks gro -> ethtool_get_gro, ethtool_set_gro tx/rx_pause -> ethtool_get_pauseparm, ethtool_set_pauseparm I would like to see the following added to ethtool, go ahead and ...
Mar 25, 8:30 am 2009
Jiri Pirko
[PATCH] bonding: select current active slave when enslav ...
Hi. I've hit an issue on my system when I've been using RealTek RTL8139D cards in bonding interface in mode balancing-alb. When I enslave a card, the current active slave (bond->curr_active_slave) is not set and the link is therefore not functional. ---- # cat /proc/net/bonding/bond0 Ethernet Channel Bonding Driver: v3.5.0 (November 4, 2008) Bonding Mode: adaptive load balancing Primary Slave: None Currently Active Slave: None MII Status: up MII Polling Interval (ms): 100 Up Delay ...
Mar 25, 8:50 am 2009
Stephen Hemminger
Re: [PATCH] gianfar: reallocate skb when headroom is not ...
On Wed, 25 Mar 2009 17:15:33 +0800 Overall, this looks like the wrong code (not copying back new skb) and in awkward place. Also your version doesn't handle case where skb headroom is not writable. Why not: --- a/drivers/net/gianfar.c 2009-03-25 08:39:03.890718197 -0700 +++ b/drivers/net/gianfar.c 2009-03-25 08:51:39.733279404 -0700 @@ -1309,6 +1309,17 @@ static int gfar_start_xmit(struct sk_buf unsigned long flags; unsigned int nr_frags, length; + /* make sure there is space and ...
Mar 25, 8:53 am 2009
Brian Haley
Re: [PATCH] IPv6: Add 'autoconf' and 'disable_ipv6' modu ...
If you just set autoconf=0 and don't set disable_ipv6=1, then DAD will complete for the link-locals just fine. If you "disable" them both you won't get any addresses at all. So I guess your point is that if you then enable IPv6 on an interface and it gets a prefix in an RA, you'll add a global without having link-local? It almost looked like the code in addrconf_prefix_rcv() prevented that from happening (ipv6_inherit_eui64()), but it doesn't. -Brian --
Mar 25, 8:54 am 2009
Randy Dunlap
Re: Next March 25: staging/epl build break.
There are lots of build errors similar to this, in appletalk, irda, tokenring, etc etc... -- ~Randy --
Mar 25, 9:04 am 2009
Alexander Duyck
Re: igbvf: add new driver to support 82576 virtual functions
The problem isn't the SR-IOV patches it is a difference in architectures. The x86/x86_64 architecture lets you be a bit more sloppy when it comes to including vmalloc. I've seen it in the past with igb, and I suspect that is why we didn't catch this in testing. We just need to add a #include of vmalloc.h in ethtool.c and the issue should be fixed. Thanks, Alex --
Mar 25, 9:10 am 2009
Patrick McHardy Mar 25, 9:26 am 2009
Patrick McHardy
Re: netfilter 00/41: Netfilter update for 2.6.30
Thanks. The discussions seems to be over already, so I'll just collect the resulting patches :) --
Mar 25, 9:29 am 2009
Jay Vosburgh
Re: [PATCH] bonding: allow bond in mode balance-alb to w ...
I think you mean "only balance-alb will simultaneously use multiple MAC addresses across different slaves." Yes? I ask because the active-backup mode with fail_over_mac=active will change the bond's MAC to always be the MAC of whatever the currently active slave is, but I don't think that will trigger the Since you put the hook outside of the skb_bond_should_drop function, does the VLAN accelerated receive path do the right thing if, e.g., there's a VLAN on top of bonding and that VLAN ...
Mar 25, 9:31 am 2009
Oliver Hartkopp
Re: [ANNOUNCE] iproute2 v2.6.29
Hi Stephen, the CAN stuff i mailed to you is still missing. Sigh. Oliver --
Mar 25, 9:32 am 2009
Patrick McHardy Mar 25, 9:32 am 2009
Patrick McHardy
Re: netfilter spurious ELOOP
Just to clarify: does the problem happens when you have the MARK rule above in a user-defined chain that has more then one jump leading to it or does it also happen in other cases? --
Mar 25, 10:07 am 2009
Patrick McHardy Mar 25, 10:25 am 2009
Patrick McHardy Mar 25, 10:27 am 2009
Patrick McHardy
Re: [patch 3/6] netfilter: limit the length of the helper name
This appears to be an off-by-one. A strlen of exactly NF_CT_HELPER_NAME_LEN - 1 would be fine, right? No need to resend, just let me know whether I should change it. --
Mar 25, 10:32 am 2009
Francis Dupont
Re: netfilter spurious ELOOP
=> I triggered the bug with a real world example: - first add a rule with a MARK target using a set mark with the first/sign bit set to one. This target is coded with this mark put at the same place than the verdict field of standard targets. (note this should be triggered by a lot of targets but I got it with MARK) - try to add another rule (with -A or -I but this works too with restore, the idea is to get a replace ioctl with an illegal value in a verdict position). - if you are ...
Mar 25, 10:37 am 2009
Holger Eitzenberger
Re: [patch 3/6] netfilter: limit the length of the helper name
Yes please, feel free to change it :). /holger --
Mar 25, 10:41 am 2009
Jiri Pirko
Re: [PATCH] bonding: allow bond in mode balance-alb to w ...
Yes this fail_over_mac is en exception. In fact I was playing with fail_over_mac bonding interface in bridge and I have no luck to force a problem with two NICs. However with 3 NICs I've managed it to the state of 100% packet loss. I'm going --
Mar 25, 10:44 am 2009
Patrick McHardy Mar 25, 10:44 am 2009
Patrick McHardy
Re: [patch 4/6] ctnetlink: allocate right-sized ctnetlink skb
This one clashes with Florian's changes to get rid of nf_ct_l4proto_find_get(). I've pushed out the patches I've already applied, please rediff the remaining ones against my current tree. Thanks. --
Mar 25, 10:46 am 2009
Joakim Tjernlund
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
Does the line(in ucc_geth_tx()) look OK to you: if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) break; Sure does look fishy to me. --
Mar 25, 10:51 am 2009
Eric Dumazet
[PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_conn structs
Hi Patrick Here is the patch I had the time to test this time... No problem so far on my machine. I did a UDP flood stress. Thank you [PATCH] conntrack: use SLAB_DESTROY_BY_RCU and get rid of call_rcu() Use "hlist_nulls" infrastructure we added in 2.6.29 for RCUification of UDP & TCP. This permits an easy conversion from call_rcu() based hash lists to a SLAB_DESTROY_BY_RCU one. Avoiding call_rcu() delay at nf_conn freeing time has numerous gains. First, it doesnt fill RCU queues ...
Mar 25, 10:53 am 2009
Patrick McHardy
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
Don't we need to make sure the entry is not reused while dumping This should be "1" I think since it wants a hlist_nulls hash. --
Mar 25, 11:05 am 2009
Patrick McHardy
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
OK I just realized my mistake, please ignore :) --
Mar 25, 11:06 am 2009
Patrick McHardy
Re: netfilter spurious ELOOP
I'm not a service center, sorry :) Feel free to create an entry in the netfilter bugzilla, I'll mark it resolved once the patch is Thanks, that answers my question. I'll apply your patch and send it to -stable once its in the mainline kernel. --
Mar 25, 11:12 am 2009
Eric Dumazet
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
Ah yes, I forgot that for UDP/TCP I had to change locking on this part. Because messing with reference count was crazy... But in UDP/TCP we have different spinlock for each chain, so hold time was small enough. So I guess that with central conntrack lock, we need to take references on entries while dumping them. --
Mar 25, 11:15 am 2009
Jarek Poplawski
Re: [RFC] net: release dst entry in dev_queue_xmit()
Actually, since David has dumped requeuing there is no reinserting; this last one "requeued" skb is buffered at the top in q->gso_skb and waiting for better times. Jarek P. --
Mar 25, 11:22 am 2009
Patrick McHardy Mar 25, 11:24 am 2009
Patrick McHardy
Re: netfilter spurious ELOOP
The same bug was also present in ip6_tables and arp_tables. This is the patch I've committed:
Mar 25, 11:38 am 2009
Eric Dumazet
Re: [RFC] net: release dst entry in dev_queue_xmit()
Yes indeed, this is what I thought too, thanks Jarek. I tested following patch today on my machine, but obviously could not try all possible quirks :) [PATCH] net: release dst entry in dev_hard_start_xmit() One point of contention in high network loads is the dst_release() performed when a transmited skb is freed. This is because NIC tx completion calls skb free long after original call to dev_queue_xmit(skb). CPU cache is cold and the atomic op in dst_release() stalls. On SMP, this ...
Mar 25, 11:41 am 2009
Eric Dumazet
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
Here is take 2 of the patch with proper ref counting on dumping. Thank you [PATCH] conntrack: use SLAB_DESTROY_BY_RCU and get rid of call_rcu() Use "hlist_nulls" infrastructure we added in 2.6.29 for RCUification of UDP & TCP. This permits an easy conversion from call_rcu() based hash lists to a SLAB_DESTROY_BY_RCU one. Avoiding call_rcu() delay at nf_conn freeing time has numerous gains. First, it doesnt fill RCU queues (up to 10000 elements per cpu). This reduces OOM possibility, ...
Mar 25, 11:53 am 2009
Patrick McHardy
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
Can we assume the next pointer still points to the next entry in the same chain after the refcount dropped to zero? --
Mar 25, 12:00 pm 2009
Eric Dumazet
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
We are looking chain N. If we cannot atomic_inc() refcount, we got some deleted entry. If we could atomic_inc, we can meet an entry that just moved to another chain X When hitting its end, we continue the search to the N+1 chain so we only skip the end of previous chain (N). We can 'forget' some entries, we can print several time one given entry. We could solve this by : 1) Checking hash value : if not one expected -> Going back to head of chain N, (potentially re-printing already ...
Mar 25, 12:17 pm 2009
Jarek Poplawski
Re: [RFC] net: release dst entry in dev_queue_xmit()
Alas I'm a bit concerned with virtual devs, e.g. now I'm looking at xmits in macvlan and pppoe. Maybe this patch should exclude them? --
Mar 25, 12:18 pm 2009
Eric Dumazet
Re: [RFC] net: release dst entry in dev_queue_xmit()
Yes, MACVLAN :) its macvlan_start_xmit() function calls dev_queue_xmit(skb) again, so we go back to packet schedulers and classifiers, they might need dst again :( Only other potential problem I found was in drivers/net/appletalk/ipddp.c static int ipddp_xmit(struct sk_buff *skb, struct net_device *dev) { __be32 paddr = ((struct rtable*)skb->dst)->rt_gateway; Not sure this driver is still supported, or if this paddr can be found elsewhere... __sk_dst_get(skb->sk) ??? --
Mar 25, 12:40 pm 2009
Patrick McHardy
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
I think double entries are not a problem, as you say, there are already other cases where this can happen. But I think we should try our best that every entry present at the start and still present at the end of a dump is also contained in the dump, otherwise the guantees seem to weak to still be useful. Thats true. But its a very rare operation, so I think its mainly a documentation issue. --
Mar 25, 12:41 pm 2009
Jarek Poplawski
Re: [RFC] net: release dst entry in dev_queue_xmit()
I guess you've considered the loopback too... Jarek P. --
Mar 25, 12:54 pm 2009
Eric Dumazet
Re: [PATCH] conntrack: use SLAB_DESTROY_BY_RCU for nf_co ...
If your concern is to not forget entries, and we are allowed to print some entries several times, then we can just check the final "nulls" value, and if we find a different value than expected for chain N, go back to begining of chain N. No need to check hash value (this could help not print several time same entry, we dont care that much) + while (is_a_nulls(head)) { + if (likely(get_nulls_value(head) == st->bucket)) { + if (++st->bucket >= ...
Mar 25, 12:58 pm 2009
Patrick McHardy Mar 25, 1:10 pm 2009
Chris Friesen
Re: Network Device Naming mechanism and policy
What about things like USB network adapters where the topology is not fixed? Presumably we would want to use some sort of unique identifier, and the MAC comes to mind. Of course, then you run into the problem of how to deal with duplicate MACs. Chris --
Mar 25, 1:22 pm 2009
Eric Dumazet
Re: [RFC] net: release dst entry in dev_queue_xmit()
I had for the first patch (carefuly avoiding loopback being not responsive) : I was releasing dst only if enqueue() was called. You are right, loopback doesnt work anymore with last patch, and I have no idea why... Do you know why ? Thank you --
Mar 25, 1:28 pm 2009
Holger Eitzenberger
[patch 0/3] ctnetlink: allocation improvements
Hi Patrick, this is a resend of the last three patches send last week, which are now rebased against commit af9d32ad6718b9a of nf-net-next-2.6. I have changed the first patch of this series to use RCU, which you complained about after my initial post. Other than that this series is unchanged. I'll send another patch shortly which adresses the points Pablo made last week. Many thanks! /holger --
Mar 25, 1:34 pm 2009
Holger Eitzenberger
[patch 1/3] ctnetlink: allocate right-sized ctnetlink skb
Try to allocate a Netlink skb roughly the size of the actual message, with the help from the l3 and l4 protocol helpers. This is all to prevent a reallocation in netlink_trim() later. The overhead of allocating the right-sized skb is rather small, with ctnetlink_alloc_skb() actually being inlined away on my x86_64 box. The size of the per-proto space is determined at registration time of the protocol helper. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: ...
Mar 25, 1:34 pm 2009
Holger Eitzenberger
[patch 2/3] netfilter: add generic function to get len o ...
Usefull for all protocols which do not add additional data, such as GRE or UDPlite. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: nf-next-2.6/include/net/netfilter/nf_conntrack_l4proto.h =================================================================== --- nf-next-2.6.orig/include/net/netfilter/nf_conntrack_l4proto.h +++ nf-next-2.6/include/net/netfilter/nf_conntrack_l4proto.h @@ -113,6 +113,7 @@ extern int nf_ct_port_tuple_to_nlattr(st const struct ...
Mar 25, 1:34 pm 2009
Holger Eitzenberger
[patch 3/3] netfilter: calculate per-protocol nlattr size
Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: nf-next-2.6/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c =================================================================== --- nf-next-2.6.orig/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c +++ nf-next-2.6/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c @@ -328,6 +328,11 @@ static int ipv4_nlattr_to_tuple(struct n return 0; } + +static int ipv4_nlattr_tuple_size(void) +{ + return nla_policy_len(ipv4_nla_policy, ...
Mar 25, 1:34 pm 2009
Patrick McHardy Mar 25, 1:51 pm 2009
Patrick McHardy Mar 25, 1:53 pm 2009
Patrick McHardy
Re: [patch 3/3] netfilter: calculate per-protocol nlattr size
Holger Eitzenberger wrote: Also applied, thanks Holger. --
Mar 25, 1:54 pm 2009
Florian Fainelli
Re: [PATCH] net: Add support for the OpenCores 10/100 Mb ...
Hello Thierry, Sure my concern was more about the original authors somehow claiming copyright I like the idea of defining ratios but for now let's just stick to what you proposed and we can later agree on getting more parameters being passed to the driver using platform_data I am not sure yet how I will tune these parameters on my design. -- Best regards, Florian Fainelli Email : florian@openwrt.org http://openwrt.org ------------------------------- --
Mar 25, 2:00 pm 2009
Jarek Poplawski
Re: [RFC] net: release dst entry in dev_queue_xmit()
Hmm.. isn't this test for dst == NULL in ip_rcv_finish expected to be negative for loopback source? Jarek P. --
Mar 25, 2:12 pm 2009
Patrick McHardy
Re: [RFC] net: release dst entry in dev_queue_xmit()
ip_route_input() doesn't accept loopback addresses, so loopback packets already need to have a dst_entry attached. --
Mar 25, 2:20 pm 2009
Holger Eitzenberger
[patch 0/1] ctnetlink: allocation improvements
Hi Patrick, the following patch against latest nf-net-next-2.6 tries to address the concerns raised by Pablo about the inacurate computation of the ctnetlink skb. I simply try to properly #ifdef the NLAs where possible. Please check. Thanks. /holger Ah, I still owe you a performance comparison! ;) --
Mar 25, 2:25 pm 2009
Holger Eitzenberger
[patch 1/1] ctnetlink: compute generic part of event mor ...
On a box with most of the optional Netfilter switches turned off some of the NLAs are never send, e. g. secmark, mark or the conntrack byte/packet counters. As a worst case scenario this may possibly still lead to ctnetlink skbs being reallocated in netlink_trim() later, loosing all the nice effects from the previous patches. I try to solve that (at least partly) by correctly #ifdef'ing the NLAs in the computation. Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org> Index: ...
Mar 25, 2:25 pm 2009
David Miller
Re: igbvf: add new driver to support 82576 virtual functions
From: Alexander Duyck <alexander.h.duyck@intel.com> Yes, that was the problem. I thought it was dead obvious from the build failure message. What else could a lack of visible vmalloc() declaration mean? :-/ --
Mar 25, 2:34 pm 2009
David Miller
Re: [PATCH] net/bridge: use the maximum hard_header_len ...
From: Li Yang <leoli@freescale.com> You're going to need it for other paths. There are other kinds of tunnels et al. that eat that headroom space on you. --
Mar 25, 2:35 pm 2009
David Miller
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
From: Joakim Tjernlund <joakim.tjernlund@transmode.se> The weight is not for the sake of your device, it's for the sake of fairness with others. Please just use 64, like every other driver does. I'm not applying this. --
Mar 25, 2:39 pm 2009
David Miller
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
From: Eric Dumazet <dada1@cosmosbay.com> He should leave howmany alone for TX work and use a weight value of 64 just like most other drivers in the tree do. Due to the abuse and random ignorant fiddling of the weight value, I am going to make it something the core rather than drivers choose. --
Mar 25, 2:40 pm 2009
David Miller
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> You're not supposed to "drain the whole queue in one go", that is not the goal of the weight value. The goal of the weight value is that it is low enough such that other devices also scheduled for NAPI on the current processor can get some fair time to process packets too. --
Mar 25, 2:42 pm 2009
David Miller
Re: [PATCH] gianfar: reallocate skb when headroom is not ...
From: Stephen Hemminger <shemminger@vyatta.com> headroom is always writable and usable by the driver, this is the exact same code sequence we use in drivers/net/niu.c for this purpose: len = sizeof(struct tx_pkt_hdr) + 15; if (skb_headroom(skb) < len) { struct sk_buff *skb_new; skb_new = skb_realloc_headroom(skb, len); if (!skb_new) { rp->tx_errors++; goto out_drop; } kfree_skb(skb); skb = skb_new; otherwise the code we just came from wouldn't be able to push ...
Mar 25, 2:49 pm 2009
Jeff Kirsher
[net-next PATCH v3] igbvf: add new driver to support 825 ...
From: Alexander Duyck <alexander.h.duyck@intel.com> This adds an igbvf driver to handle virtual functions provided by the igb driver when SR-IOV has been enabled. A virtual function is a lightweight pci-e function that supports a single queue and shares resources with the 82576 physical function contained within the igb driver. To spawn virtual functions from the igb driver all that is needed is to issue a echo X > /sys/class/ethY/num_vfs. X can be a value between 0 and 7, 0 will disable ...
Mar 25, 2:52 pm 2009
Joakim Tjernlund
Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI ...
Good, I had a hard time finding info how one should use it anyway. --
Mar 25, 2:55 pm 2009
Jeff Kirsher
Re: [net-next PATCH v3] igbvf: add new driver to support ...
On Wed, Mar 25, 2009 at 2:52 PM, Jeff Kirsher into drivers/net/igbvf/ethtool.c. We verified that this fixes the compilation issues on PPC. -- Cheers, Jeff --
Mar 25, 3:00 pm 2009
Stephen Hemminger
Re: [net-next PATCH v3] igbvf: add new driver to support ...
On Wed, 25 Mar 2009 14:52:48 -0700 Please don't use sysfs for this. Instead build a proper rtnl_link netlink interface (see macvlan). Intel doesn't invent unique hardware, other vendors will do the same thing (or follow your lead), so doing it right the first time for these kind of devices makes sense. --
Mar 25, 3:03 pm 2009
Alexander Duyck
Re: [net-next PATCH v3] igbvf: add new driver to support ...
The sysfs part of this is already in net-next as it isn't part of the igbvf driver it is part of igb. It was added in over a month ago: http://patchwork.ozlabs.org/patch/23471/ I will see what we can do to make use of a netlink interface. I'm honestly not even sure if it will work well for this kind of setup since the VF driver won't even be running on the same OS in most cases. For now the sysfs code in igb is actually quite minimal, and the main goal was to keep the interface as ...
Mar 25, 3:33 pm 2009
Adam Richter
Re: 2.6.29 forcedeth hang W/O NAPI enabled
I am experiencing what is probably the same forcedeth ethernet hang with FORCEDETH_NAPI disabled as reported by Berkley Shands. I want to add the following additional data (items 2-7 basically just confirm what one would expect): 1) I can narrow where the problem was introduced. The problem does not occur for me in 2.6.29-rc8-git6, the last git snapshot before 2.6.29. There are no changes to forcedeth.c between these versions. 2) The amount of time it takes to reproduce ...
Mar 25, 4:24 pm 2009
Ramkrishna Vepa
RE: [net-2.6 PATCH 7/10] Neterion: New driver: Main entr ...
Stephen, [Ram] Agreed. The reason we have some of these options is due to customer feedback who want the interface to come up on a boot with a configuration that is different from the driver default. This may be a feature that we could add to ethtool, by giving an option to change [Ram] We have an ethtool option already for this parameter but needed the configuration to persist over a boot as noted above. Do you have a [Ram] Here's a proposal/wish list. Please let me know what you feel ...
Mar 25, 4:26 pm 2009
Ramkrishna Vepa
RE: [net-2.6 PATCH 7/10] Neterion: New driver: Main entr ...
[Ram] I should have described this option better! This option is used in the Xen and other virtual environments to learn the mac address of the interface on guest OS and then programme the receive steering logic to steer the received packets to respective VF. This is to avoid having the nic in promiscuous mode for obvious reasons. Ram --
Mar 25, 4:47 pm 2009
David Miller
Re: [patch 0/6] s390: qeth fixes for 2.6.30
From: Frank Blaschka <blaschka@linux.vnet.ibm.com> I keep meaning to get back to a project I was working on that would make generic the by-hand TSO that drivers such as drivers/net/sfc/ are doing. Just like this EDDP code seems to have been doing, they claim to be TSO capable as a device but it is all done in software. The hope is to write a generic framework, and skb_dma_map() and skb_dma_unmap() were created as initial infrastructure for that. Anyways, if I ever complete that project, ...
Mar 25, 4:47 pm 2009
David Miller
Re: [net-next PATCH v3] igbvf: add new driver to support ...
From: Alexander Duyck <alexander.h.duyck@intel.com> I have to agree with Stephen that the way to create new links of virtual and similar devices is to use rtnl_link. We have very good infrastructure for this, and if I understand things correctly iproute2 might even work with an igb using rtnl_link with zero modifications to the tool sources. Please fix this up, it's a very reasonable request for such a large new piece of driver infrastructure. And since this is a new driver, you have no ...
Mar 25, 4:58 pm 2009
previous daytodaynext day
March 24, 2009March 25, 2009March 26, 2009