[patch 0/6] s390: qeth fixes for 2.6.30

Previous thread: [patch 6/6] [PATCH] qeth: fix wait_event_timeout handling by frank.blaschka on Tuesday, March 24, 2009 - 11:57 pm. (1 message)

Next thread: [patch 3/6] [PATCH] qeth: remove EDDP by frank.blaschka on Tuesday, March 24, 2009 - 11:57 pm. (1 message)
From: frank.blaschka
Date: Tuesday, March 24, 2009 - 11:57 pm

Hi Dave,

here are a couple of qeth fixes for 2.6.30

shortlog:
Kay Sievers (1)
qeth: struct device - replace bus_id with dev_name(), dev_set_name()

Klaus-Dieter Wacker (1)
qeth: unregister MAC addresses during recovery

Ursula Braun (1)
qeth: check for completion of a running recovery

Heiko Carstens(1)
qeth: fix wait_event_timeout handling

Frank Blaschka (2)
qeth: add statistics for tx csum
qeth: remove EDDP

Thanks,
        Frank
--

From: David Miller
Date: Wednesday, March 25, 2009 - 12:08 am

From: frank.blaschka@de.ibm.com

Any particular reason you wait until right when the
merge window opens to send me stuff?

I said on netdev that I wanted to empty my patchwork
queue then submit the tree to Linus.

So then you send me more stuff on top of that? :-/






Your EDDP was slow because the implementation was incredibly
sub-optimal.  %90 of the code is doing copies and fiddling
with SKB internals.
--

From: Frank Blaschka
Date: Wednesday, March 25, 2009 - 1:25 am

Sorry, this was by accident. Next time I will send the patches

I did not wrote the EDDP code but this was my impression too. Thanks for
confirming my study. Also the filling of the hardware buffers was not
efficient and passing more buffers to the hw was expensive too.



--

From: David Miller
Date: Wednesday, March 25, 2009 - 4:47 pm

From: Frank Blaschka <blaschka@linux.vnet.ibm.com>

I keep meaning to get back to a project I was working on that
would make generic the by-hand TSO that drivers such as
drivers/net/sfc/ are doing.

Just like this EDDP code seems to have been doing, they claim
to be TSO capable as a device but it is all done in software.

The hope is to write a generic framework, and skb_dma_map() and
skb_dma_unmap() were created as initial infrastructure for that.

Anyways, if I ever complete that project, drivers like qeth
could try to make use of it and do some perf tests.
--

Previous thread: [patch 6/6] [PATCH] qeth: fix wait_event_timeout handling by frank.blaschka on Tuesday, March 24, 2009 - 11:57 pm. (1 message)

Next thread: [patch 3/6] [PATCH] qeth: remove EDDP by frank.blaschka on Tuesday, March 24, 2009 - 11:57 pm. (1 message)