login
Search
| From | Subject | Date |
|---|---|---|
| Michael Tokarev | Re: Allow group ownership of TUN/TAP devices.
[Again, resurrecting an old thread...
lkml added -- this is a policy issue, so to say]
It's a bit worse than that. I.e., there's exactly 2 problems here.
First, currently tun driver only checks primary gid and not any
supplementary gids (this is what my one-line patch addressed).
And second, if both gid and uid is specified for the given tun
device, BOTH should match. I.e, I can be "owner"(*) of the device
in question, but if my current gid does not match, I still can't
use it. This ...
| Mar 24, 11:10 am 2009 |
| Yinghai Lu | Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb
it works too.
YH
--
| Mar 24, 3:35 pm 2009 |
| Bernhard Schmidt | Re: [Bugme-new] [Bug 12877] New: tg3: eth0 transit timed ...
On 23.03.2009 19:18, Matt Carlson wrote:
Just to make sure I didn't confuse you, the "watchdog" I was talking
about here is a shellscript like this, executed every minute
---
/bin/ping -q -c 5 <defaultgw> > /dev/null
RC=$?
if [ ${RC} -ne 0 ]; then
rmmod tg3; sleep 5; modprobe tg3; sleep 5; ifup --force eth0
fi
---
The tg3 watchdog (tg3: eth0: transmit timed out, resetting) did not
appear at all in this circle, so I guess the checkscript killed the
module before.
Yes, the NIC ...
| Mar 23, 5:35 pm 2009 |
| Francois Romieu | Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt()
Karsten Wiese <fzu@wemgehoertderstaat.de> :
Thanks.
I'll wrap it up without the change to R8169_MSG_DEFAULT:
- it can be set through ethtool and a module option
- the current default is not a clear nuisance
--
Ueimor
--
| Mar 24, 1:18 pm 2009 |
| Karsten Wiese | Mar 23, 5:38 pm 2009 | |
| Karsten Wiese | Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt()
patch below helps.
Thanks,
Karsten
--------------------->
[PATCH] r8169: Reset IntrStatus after chip rest
On a MSI MS-6702E mainboard, when in rtl8169_init_one() for the first time
after BIOS has run, IntrStatus reads 5 after chip has been reset.
IntrStatus should equal 0 there, so patch changes IntrStatus reset to happen
after chip reset instead of before.
R8169_MSG_DEFAULT is changed to include NETIF_MSG_INTR, because without
an important error message from rtl8169_interrupt() isn't ...
| Mar 24, 6:54 am 2009 |
| Alexander Beregalov | Re: next-20090318: sunhme does not transmit packets
Hi David
2.6.29 also does not work.
The guilty patch should be between 2.6.29-rc8 and final 2.6.29
even more narrow - 59fcbdd..v2.6.29
I can try to bisect.
--
| Mar 24, 4:32 am 2009 |
| David Miller | Re: next-20090318: sunhme does not transmit packets
From: Alexander Beregalov <a.beregalov@gmail.com>
I bet it is the problem we are discussing here:
http://marc.info/?l=linux-kernel&m=123789980524715&w=2
Herbert has posted two patches to try and fix this issue,
you can try the second one to see if it solves your bug
too.
--
| Mar 24, 1:23 pm 2009 |
| Alexander Beregalov | Re: next-20090318: sunhme does not transmit packets
e4a389a9b5c892446b5de2038bdc0cca8703c615 is first bad commit
commit e4a389a9b5c892446b5de2038bdc0cca8703c615
Author: Roel Kluin <roel.kluin@gmail.com>
Date: Wed Mar 18 23:12:13 2009 -0700
net: kfree(napi->skb) => kfree_skb
--
| Mar 24, 8:46 am 2009 |
| Alexander Beregalov | Re: next-20090318: sunhme does not transmit packets
No, it is wrong, sorry.
I will do more tests tomorrow.
--
| Mar 24, 8:50 am 2009 |
| Rick Jones | Re: [PATCH] bnx2: Use request_firmware()
So? Perhaps I'm just experiencing distro pain which may not continue to exist or
which may not matter to netdev, but when one is installing to a system that uses
a core NIC which has firmware cast-out into "non-free" siberia, life is "fun"
enough making sure one has the one firmware file let alone N of them. If I now
have to make sure I have all N firmware files, and they are to be updated
separately, either that means I have to find N packages, or the distros are going
to package them ...
| Mar 23, 6:26 pm 2009 |
| Michael Chan | Re: [PATCH] bnx2: Use request_firmware()
Looking at the git history, about 3 out of 7 times, bnx2_fw.h was
partially updated. About 2 out of 8 times bnx2_fw2.h was partially
updated. The next planned update for net-next is a partial update.
Either way will work. Using separate files will reduce the amount
of patch churn during partial updates. That's the advantage.
--
| Mar 24, 8:27 am 2009 |
| Rick Jones | Re: [PATCH] bnx2: Use request_firmware()
Is that really necessary? It is enough "fun" finding just the one firmware file
as it is.
rick jones
--
| Mar 23, 5:14 pm 2009 |
| Bastian Blank | Re: [PATCH] bnx2: Use request_firmware()
What is the advantage of this? I always saw updates to more than one
firmware at once in the past. The question is not: is it possible, but:
it is necessary.
Bastian
--
Our way is peace.
-- Septimus, the Son Worshiper, "Bread and Circuses",
stardate 4040.7.
--
| Mar 24, 12:42 am 2009 |
| Michael Chan | Re: [PATCH] bnx2: Use request_firmware()
If all the firmware sections are in the same file, much of the firmware
file will be duplicated in a new file when we update just one section.
--
| Mar 23, 6:11 pm 2009 |
| Michael Chan | Re: [PATCH] bnx2: Use request_firmware()
I think we can assume that distros will package firmware files (make
firmware_install) properly and not require users to install these
firmware files on their own.
--
| Mar 23, 6:44 pm 2009 |
| Ben Hutchings | Re: [PATCH] bnx2: Use request_firmware()
[...]
If you're referring to Debian, that is exactly what Bastian and I are
working on. Sourceless firmware is considered non-free, but it can
still be packaged, as the bnx2 firmware already has been. We've also
had some discussions with David Woodhouse about semi-automatically
packaging all of the firmware that's now in the firmware subdirectory
and is clearly licensed.
Ben.
| Mar 23, 9:27 pm 2009 |
| Jarek Poplawski | Re: [PATCH] netconsole: fix BUG during net device "upping"
And from any function called anywhere on another cpu while driver's
->open() is running.
BTW, I've had a look at this and it seems the main problem is
netif_tx_stopped() isn't handled properly by the driver(s).
Jarek P.
--
| Mar 24, 1:22 am 2009 |
| Jeff Kirsher | Re: [PATCH] e1000: fix loss of multicast packets
Yes, I have it in my queue. It should be in the next series of fixes
I will be sending out.
--
Cheers,
Jeff
--
| Mar 23, 7:53 pm 2009 |
| Jeff Kirsher | Re: [PATCH] e1000: fix loss of multicast packets
We also have a patch for e1000e as well. :)
--
Cheers,
Jeff
--
| Mar 24, 3:50 pm 2009 |
| Dave Boutcher | Re: [PATCH] e1000: fix loss of multicast packets
On Mon, Mar 23, 2009 at 9:53 PM, Jeff Kirsher
At the risk of seeming demanding, an e1000e version as well? That's
actually where the problem first showed up.
Thanks,
--
Dave B
--
| Mar 24, 4:26 am 2009 |
| David Miller | Re: [PATCH] netfilter: fix unaligned memory access in tcp_sack
From: Patrick McHardy <kaber@trash.net>
Pulled, thanks Patrick.
--
| Mar 24, 4:39 pm 2009 |
| Joakim Tjernlund | Re: [PATCH] ucc_geth: Convert to net_device_ops
Yep, getting tiered ...
Hopefully I will have something more coming your way the next few days.
--
| Mar 24, 4:35 pm 2009 |
| Joakim Tjernlund | Re: [PATCH] ucc_geth: Convert to net_device_ops
Same here, getting tiered. Should have seen that. Here goes,
attatched as well as explained earlier.
Jocke
From 651fcd7d1ba494f2e2f20da51196b1b3dccdcd68 Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Fri, 20 Mar 2009 21:09:14 +0100
Subject: [PATCH] ucc_geth: Convert to net_device_ops
---
drivers/net/ucc_geth.c | 24 +++++++++++++++---------
1 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ucc_geth.c ...
| Mar 24, 4:08 pm 2009 |
| David Miller | Re: [PATCH] ucc_geth: Convert to net_device_ops
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
I'll apply this, thanks.
Please provide a proper "Signed-off-by:" line with future
patch submissions, thanks.
--
| Mar 24, 4:29 pm 2009 |
| David Miller | Re: [PATCH] ucc_geth: Convert to net_device_ops
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Missing ".ndo_set_mac_address = eth_set_mac_address," and
also ".ndo_change_mtu = eth_change_mtu".
Also please inline your patches so that people can quote them in
replies.
--
| Mar 24, 2:22 pm 2009 |
| Joakim Tjernlund | Re: [PATCH] ucc_geth: Convert to net_device_ops
OK, here is a new version. The #if 0 ..#endif has been removed.
Jocke
| Mar 24, 3:37 am 2009 |
| David Miller | Re: [PATCH] ucc_geth: Convert to net_device_ops
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
See ether_setup() which is called indirectly via alloc_etherdev().
Yawn...
--
| Mar 24, 3:49 pm 2009 |
| Joakim Tjernlund | Re: [PATCH] ucc_geth: Convert to net_device_ops
I don't follow. Are these mandatory now? They were not in the old
I know, but my mail system is screwing up WS ATM so I can't. Working
on it though.
--
| Mar 24, 3:45 pm 2009 |
| Patrick McHardy | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
Applied, thanks everyone.
--
| Mar 24, 6:28 am 2009 |
| Patrick McHardy | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
I'm not sure I understand the rules correctly, but we'd still
have to wait for the grace period before an object can be reused,
no?
--
| Mar 24, 6:38 am 2009 |
| Eric Dumazet | Re: ucc_geth: nf_conntrack: table full, dropping packet.
I dont understand how your ping can use so many conntrack entries...
Then, as I said yesterday, I believe you have a RCU delay, because of
a misbehaving driver or something...
grep RCU .config
grep CONFIG_SMP .config
You could change qhimark from 10000 to 1000 in kernel/rcuclassic.c (line 80)
as a workaround. It should force a quiescent state after 1000 freed conntracks.
--
| Mar 24, 2:12 am 2009 |
| Eric Dumazet | [PATCH] netfilter: Use hlist_add_head_rcu() in nf_conntr ...
While working on this stuff, I found one suspect use of hlist_add_head()
Its not a hot path, I believe following patch would make sure nothing
wrong happens.
If a chain contains element A and B, then we might build a new table
with a new chain containing B and A (in this reverse order), and
a cpu could see A->next = B (new pointer), B->next = A (old pointer)
Thanks
[PATCH] netfilter: Use hlist_add_head_rcu() in nf_conntrack_set_hashsize()
Using hlist_add_head() in ...
| Mar 24, 12:54 pm 2009 |
| Joakim Tjernlund | Re: ucc_geth: nf_conntrack: table full, dropping packet.
grep RCU .config
# RCU Subsystem
CONFIG_CLASSIC_RCU=y
# CONFIG_TREE_RCU is not set
# CONFIG_PREEMPT_RCU is not set
# CONFIG_TREE_RCU_TRACE is not set
# CONFIG_PREEMPT_RCU_TRACE is not set
# CONFIG_RCU_TORTURE_TEST is not set
grep CONFIG_SMP .config
conntracks.
right, doing this almost killed all conntrack messages, had to stress it
pretty
hard before I saw handful "nf_conntrack: table full, dropping packet"
RCU is not my cup of tea, do you have any ideas were to look?
Jocke
--
| Mar 24, 3:55 am 2009 |
| Joakim Tjernlund | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
The patch fixes the problem and the system feels a bit more responsive
too, thanks.
I guess I should probably do both 1) and 3) as my board is pretty slow
too.
Been trying to figure out a good value for NAPI weigth too. Currently my
HW RX and TX queues are 16 pkgs deep and weigth is 16 too. If I move TX
processing
to NAPI context AND increase weigth to 32, the system is a lot more
responsive during
ping flooding. Does weigth 32 make sense when the HW TX and RX queues are
16?
...
| Mar 24, 6:20 am 2009 |
| Eric Dumazet | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
No we dont have to, but we must do additionnal checks after getting
a reference on object found on lookup.
(We must re-check the keys used during search)
This re-check is not very expensive since everything is hot in cpu cache.
Check Documentation/RCU/rculist_nulls.txt for some documentation.
1) Lookup algo
--------------
rcu_read_lock()
begin:
obj = lockless_lookup(key);
if (obj) {
if (!try_get_ref(obj)) // might fail for free objects
goto begin;
/*
* Because a writer ...
| Mar 24, 6:47 am 2009 |
| Joakim Tjernlund | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
Eric Dumazet <dada1@cosmosbay.com> wrote on 24/03/2009 14:29:29:
I mean this call in ucc_geth:
netif_napi_add(dev, &ugeth->napi, ucc_geth_poll, UCC_GETH_DEV_WEIGHT);
UCC_GETH_DEV_WEIGHT is 16
Noticed that rcuclassic.c has a
module_param(qhimark, int, 0);
But I can't figure out hot to set this qhimark from the cmdline.
rcuclassic.c is not a module(I don't use modules at all)
Jocke
Jocke
--
| Mar 24, 6:41 am 2009 |
| Maxime Bizon | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
On Tue, 2009-03-24 at 13:07 +0100, Eric Dumazet wrote:
Your patch fixes the problem on my board too (embedded mips router
250Mhz), thanks.
Yet I'm concerned about what you said concerning RAM usage. I have a
very small amount on memory left on my board (less than 4M), and I tuned
ip route cache size and nf_conntrack_max to make sure I won't go OOM.
With your patch, does it mean 10000 conntrack entries can be allocated
while nf_conntrack_max is say only 2048 ?
Regards,
-- ...
| Mar 24, 8:17 am 2009 |
| Joakim Tjernlund | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
Just add "rcuclassic.qhimark=2048" to your cmdline.
Jocke
--
| Mar 24, 11:29 am 2009 |
| Eric Dumazet | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
I forgot to say this is what we do for 'struct file' freeing as well. We
decrement nr_files in file_free(), not in file_free_rcu()
static inline void file_free_rcu(struct rcu_head *head)
{
struct file *f = container_of(head, struct file, f_u.fu_rcuhead);
put_cred(f->f_cred);
kmem_cache_free(filp_cachep, f);
}
static inline void file_free(struct file *f)
{
percpu_counter_dec(&nr_files); <<<< HERE >>>>
file_check_state(f);
...
| Mar 24, 5:25 am 2009 |
| Patrick McHardy | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
While temporarily exceeding the limit by up to 10000 entries is
quite a lot, I guess the important thing is that it can't grow
unbounded, so I think this patch is fine.
--
| Mar 24, 5:43 am 2009 |
| Eric Dumazet | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
If you only have one NIC, I dont understand why changing weight should make
a difference. Are you referring to dev_weight or netdev_budget ?
# cat /proc/sys/net/core/dev_weight
64
# cat /proc/sys/net/core/netdev_budget
300
--
| Mar 24, 6:29 am 2009 |
| Eric Dumazet | [PATCH] conntrack: Reduce conntrack count in nf_conntrac ...
In a stress situation, you feed more deleted conntracks to call_rcu() than
the blimit (10 real freeing per RCU softirq invocation).
So with default qhimark being 10000, this means about 10000 conntracks
can sit in RCU (per CPU) before being really freed.
Only when hitting 10000, RCU enters a special mode to free all queued items, instead
of a small batch of 10
To solve your problem we can :
1) reduce qhimark from 10000 to 1000 (for example)
Probably should be done to reduce some ...
| Mar 24, 5:07 am 2009 |
| Eric Dumazet | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
Maybe we could use SLAB_DESTROY_BY_RCU thing and no more call_rcu() queueing
problem. That would better use CPU caches as well...
--
| Mar 24, 6:32 am 2009 |
| Joakim Tjernlund | Re: ucc_geth: nf_conntrack: table full, dropping packet.
skbuff does not differ much, but others do
Before ping:
During ping:
This feels more like the freeing of conntrack objects are delayed and
builds up when ping flooding.
Don't have "conntrack -E" for my embedded board so that will have to wait
a bit longer.
Jocke
--
| Mar 24, 1:22 am 2009 |
| Eric Dumazet | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
Well... yes, RCU can have this 'interesting' OOM property.
For small machines, you really want to lower RCU parameters, because
as you said, we also push route cache entries in RCU queue, my patch
being applied or not (But using call_rcu_bh(), so we have lower latencies
I think)
We are working on a SLAB_DESTROY_BY_RCU implementation so that
conntrack wont use call_rcu() anymore, give us a couple of days :)
Paul, could we have /sys knobs to be able to tune qhimark, blimit & qlowmark ...
| Mar 24, 8:27 am 2009 |
| Patrick McHardy | Re: [PATCH] conntrack: Reduce conntrack count in nf_conn ...
Temporarily under worst-case circumstances, yes. Eric is already working
on his proposed improvement though :)
--
| Mar 24, 8:21 am 2009 |
| David Miller | Re: [PATCH] be2net: cleanup rx/tx rate calculations
From: Sathya Perla <sathya.perla@gmail.com>
Your email client corrupted the patch, breaking up long lines
with newlines.
I fixed it up, but I will not do so next time and instead I
will kick the patch back to you or simply ignore the submission.
So please get this fixed.
Thanks.
--
| Mar 24, 4:40 pm 2009 |
| David Miller | Re: [PATCH] netlink: add NETLINK_NO_ENOBUFS socket flag
From: Pablo Neira Ayuso <pablo@netfilter.org>
Applied, thanks Pablo.
--
| Mar 24, 4:38 pm 2009 |
| Tilman Schmidt | Re: [PATCH 2.6.27/28-stable] bas_gigaset: correctly allo ...
Thanks. Please do so.
Regards,
Tilman
--=20
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite)
| Mar 24, 1:54 am 2009 |
| Grant Likely | Re: FW: [PATCH v2 13/13] net: add Xilinx ll_temac device ...
(adding netdev and linuxppc mailing lists to the CC: list)
It really shouldn't be much work at all. It is on my todo list, but
any help would be appreciated.
Although I'm also thinking about going a step farther and factoring
out the LL code into a separate driver entirely.
>> +
| Mar 23, 6:15 pm 2009 |
| Richard Zhao | Re: [PATCH 2/3] ARM: mxc: add mx31pdk Lan9217 support
Hi Sascha,
ok, I will remove the ifdefs.
Thanks
--
| Mar 24, 1:59 am 2009 |
| Sascha Hauer | Re: [PATCH 2/3] ARM: mxc: add mx31pdk Lan9217 support
IMO it is not worth to clutter the code with ifdefs just to save some
static struct resource smsc911x_resources[] = {
{
.start = LAN9217_BASE_ADDR,
.end = LAN9217_BASE_ADDR + 0x100,
.flags = IORESOURCE_MEM,
},{
.start = LAN9217_IRQ,
.end = LAN9217_IRQ,
.flags = IORESOURCE_IRQ,
},
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, ...
| Mar 24, 12:58 am 2009 |
| Richard Zhao | [PATCH 2/3] ARM: mxc: add mx31pdk Lan9217 support
Signed-off-by: Richard Zhao <linuxzsc@gmail.com>
diff --git a/arch/arm/mach-mx3/mx31pdk.c b/arch/arm/mach-mx3/mx31pdk.c
index aa7e3c5..45cef70 100644
--- a/arch/arm/mach-mx3/mx31pdk.c
+++ b/arch/arm/mach-mx3/mx31pdk.c
@@ -32,6 +32,8 @@
#include <mach/board-mx31pdk.h>
#include <mach/imx-uart.h>
#include <mach/iomux-mx3.h>
+#include <linux/platform_device.h>
+#include <linux/smsc911x.h>
#include "devices.h"
#include "3stack-debug.h"
@@ -57,6 +59,43 @@ static inline void ...
| Mar 23, 11:44 pm 2009 |
| Richard Zhao | Re: [PATCH 3/3] smsc911x: add flag SMSC911X_USE_INTERPHY
Hi Sascha,
Sorry I didn't check linux-next. Do I need always to create mxc
patches based on linux-nex?
And I don't know why the smsc911x patch commited on Feb 1 on
linux-next still not be merged to mainline?
Thanks
Richard
--
| Mar 24, 1:36 am 2009 |
| Richard Zhao | [PATCH 3/3] smsc911x: add flag SMSC911X_USE_INTERPHY
mx31pdk board don't have external PHY, but it wrongly pull up MDIO.
So, add flag SMSC911X_USE_INTERPHY to force using internal PHY.
Signed-off-by: Richard Zhao <linuxzsc@gmail.com>
diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index d1590ac..60f7b74 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -831,10 +831,12 @@ static int __devinit smsc911x_mii_init(struct
platform_device *pdev,
case 0x01150000:
case 0x117A0000:
case 0x115A0000:
- /* External ...
| Mar 23, 11:47 pm 2009 |
| David Miller | Re: [PATCH 3/3] smsc911x: add flag SMSC911X_USE_INTERPHY
From: Richard Zhao <linuxzsc@gmail.com>
Because it was not a critical regression fix, so it goes
to net-next-2.6 until the merge window opens up.
--
| Mar 24, 2:18 am 2009 |
| Sascha Hauer | Re: [PATCH 3/3] smsc911x: add flag SMSC911X_USE_INTERPHY
Have a look at Documentation/development-process in the Kernel sources.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
| Mar 24, 1:52 am 2009 |
| Sascha Hauer | Re: [PATCH 3/3] smsc911x: add flag SMSC911X_USE_INTERPHY
Hi Richard,
This patch is outdated. Linux-next already contains a
SMSC911X_FORCE_INTERNAL_PHY for exactly this reason.
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
| Mar 24, 12:51 am 2009 |
| Andrey Panin | Mar 24, 4:13 am 2009 | |
| Florian Fainelli | Re: [PATCH] net: Add support for the OpenCores 10/100 Mb ...
Hi Thierry,
I am glad someone updated and submitted this driver, excellent work !. Few
I think there are some other authors like Simon Srot and Tensilica, unless you
did wrote this completely from scratch and did not look at the uClincu
open_eth driver at all ?
Why do you need these declarations ? Are not your functions properly ordered
That's what uClinux driver calls SRAM right ?
Please use netdev_ops.
What about allowing platform configuration of the RX/TX buffers size ...
| Mar 24, 3:32 am 2009 |
| David Miller | Re: [PATCH] net: Add support for the OpenCores 10/100 Mb ...
From: Andrey Panin <pazke@donpac.ru>
Agreed, this stuff must be fixed.
You could use skb_copy_and_csum_dev() directly into your buffer, then
pad out the end of the buffer with a memset() call, if necessary.
Actually, no you can't...
You should not be using memcpy() to store things into I/O memory.
That's what memcpy_io() is for.
I think because of all of these special padding cases and the use
of I/O memory instead of DMA, there is no real gain by using
skb_copy_and_csum_dev() in this ...
| Mar 24, 4:36 pm 2009 |
| Thierry Reding | [PATCH] net: Add support for the OpenCores 10/100 Mbps E ...
This patch adds a platform device driver that supports the OpenCores 10/100
Mbps Ethernet MAC.
The driver expects three resources: one IORESOURCE_MEM resource defines the
memory region for the core's memory-mapped registers while a second
IORESOURCE_MEM resource defines the network packet buffer space. The third
resource, of type IORESOURCE_IRQ, associates an interrupt with the driver.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
drivers/net/Kconfig | 7 +
...
| Mar 24, 3:18 am 2009 |
| Andrey Panin | Mar 24, 5:01 am 2009 | |
| David Miller | Re: [PATCH] macb: fix warning "warning: unused variable ...
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Applied, thanks.
--
| Mar 24, 4:30 pm 2009 |
| Haavard Skinnemoen | [PATCH] macb: fix warning "warning: unused variable `dev' "
From: vibisreenivasan <vibi_sreenivasan@cms.com>
Removed unused variable dev
Signed-off-by: vibi sreenivasan <vibi_sreenivasan@cms.com>
Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
---
drivers/net/macb.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index f6c4936..180f9c9 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -513,7 +513,6 @@ static int macb_rx(struct macb *bp, int budget)
...
| Mar 24, 3:26 am 2009 |
| David Miller | Re: [PATCH] myri10ge: update firmware headers to 1.4.41
From: Brice Goglin <brice@myri.com>
I'll apply this, thanks.
--
| Mar 24, 4:31 pm 2009 |
| Brice Goglin | [PATCH] myri10ge: update firmware headers to 1.4.41
Update myri10ge firmware headers to firmware version 1.4.41.
Signed-off-by: Brice Goglin <brice@myri.com>
--- net-next-2.6/drivers/net/myri10ge/myri10ge_mcp_gen_header.h 2009-01-22 08:05:56.000000000 +0100
+++ linux-tmp/drivers/net/myri10ge/myri10ge_mcp_gen_header.h 2009-03-24 10:50:10.000000000 +0100
@@ -9,6 +9,7 @@
#define MCP_TYPE_ETH 0x45544820 /* "ETH " */
#define MCP_TYPE_MCP0 0x4d435030 /* "MCP0" */
#define MCP_TYPE_DFLT 0x20202020 /* " " */
+#define MCP_TYPE_ETHZ 0x4554485a /* ...
| Mar 24, 3:01 am 2009 |
| Marco Berizzi | network traffic stop with 2.6.29 after ftp put
Hi Folks,
Just finished compiling linux 2.6.29 on
Slackware 12.2
Linux 2.6.29 stop sending/receiving any
kind of packets (ipv4 on 3c59x) after less
then 20MB of ftp/mput.
Running tcpdump on the eth0 doesn't catch
any traffic. I only see the arp requests.
Hopefully I can reproduce the problem :-)
Any king of feedback are welcome.
If you need ssh/telnet access to this box
just ask.
This is my .config & dmesg
#
# Automatically generated make config: don't edit
# Linux kernel version: ...
| Mar 24, 3:41 am 2009 |
| Eric Dumazet | Re: network traffic stop with 2.6.29 after ftp put
Could you please send us :
iptables -nvL
netstat -s
cat /proc/slabinfo
--
| Mar 24, 4:22 am 2009 |
| Marco Berizzi | Re: network traffic stop with 2.6.29 after ftp put
me again.
Linux doesn't respond even to 127.0.0.1 :-((
root@Calimero:~# ping 172.16.1.247
PING 172.16.1.247 (172.16.1.247) 56(84) bytes of data.
^C
--- 172.16.1.247 ping statistics ---
4 packets transmitted, 0 received, 100% packet loss, time 3010ms
root@Calimero:~# ping 127.0.0.1
PING 127.0.0.1 (127.0.0.1) 56(84) bytes of data.
^C
--- 127.0.0.1 ping statistics ---
8 packets transmitted, 0 received, 100% packet loss, time 7023ms
root@Calimero:~# ifconfig
eth0 Link ...
| Mar 24, 4:01 am 2009 |
| Marco Berizzi | Re: network traffic stop with 2.6.29 after ftp put
just an update: this bug is not related to
ftp: it appears to me that after some
traffic (imap, http) linux stop receiving
there isn't any iptables rules
(there isn't even the iptables package
Ip:
4808 total packets received
28 with invalid addresses
0 forwarded
0 incoming packets discarded
4685 incoming packets delivered
1226 requests sent out
Icmp:
0 ICMP messages received
0 input ICMP message failed.
ICMP input histogram:
68 ICMP messages ...
| Mar 24, 4:30 am 2009 |
| Eric Dumazet | Re: network traffic stop with 2.6.29 after ftp put
Thanks Marco
You probably have the problem Ingo reported on lkml, please try Herbert fix :
http://marc.info/?l=linux-kernel&m=123790184128396&w=2
net: Fix netpoll lockup in legacy receive path
When I fixed the GRO crash in the legacy receive path I used
napi_complete to replace __napi_complete. Unfortunately they're
not the same when NETPOLL is enabled, which may result in us
not calling __napi_complete at all.
While this is fishy in itself, let's make the obvious fix right
now of ...
| Mar 24, 7:02 am 2009 |
| Ursula Braun | [patch 1/9] [PATCH] Use kthread instead of kernel_thread
From: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Lcs uses low-level kernel_thread implementation.
All drivers should use <linux/kthread.h> API instead.
Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/lcs.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
--- linux-2.6/drivers/s390/net/lcs.c 2009-03-04 ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 0/9] s390: lcs / ctcm / claw / netiucv patches fo ...
Dave,
here are a couple of drivers/s390/net-patches for 2.6.29 :
1/9: lcs: exploit <linux/kthread.h> - Klaus-Dieter Wacker
2/9: lcs: hard_start_xmit return codes - Klaus-Dieter Wacker
3/9: netiucv: hard_start_xmit return codes - Ursula Braun
4/9: claw: hard_start_xmit return codes - Ursula Braun
5/9: ctcm: hard_start_xmit return codes - Ursula Braun
6/9: ctcm: avoid wraparound in length of incoming data - Roel Kluin
7/9: ctcm: minor ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 2/9] [PATCH] lcs: invalid return codes from hard_ ...
From: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Lcs hard_start_xmit routine issued return codes other than
defined for this interface. Now lcs returns only either
NETDEV_TX_OK or NETDEV_TX_BUSY.
Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/lcs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
--- ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 6/9] [PATCH] ctcm: avoid wraparound in length of ...
From: Roel Kluin <roel.kluin@gmail.com>
Since the receive code should tolerate any incoming garbage, it
should be protected against a potential wraparound when manipulating
length values within incoming data.
block_len is unsigned, so a too large subtraction will cause a
wraparound.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/ctcm_fsms.c | 5 ++---
drivers/s390/net/ctcm_main.c | 3 ++-
2 files ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 5/9] [PATCH] ctcm: invalid return code from hard_ ...
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warning by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/ctcm_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/ctcm_main.c linux-2.6-patched/drivers/s390/net/ctcm_main.c
--- linux-2.6/drivers/s390/net/ctcm_main.c 2009-03-04 15:58:03.000000000 +0100
+++ ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 3/9] [PATCH] netiucv: invalid return code from ha ...
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warning by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/netiucv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/drivers/s390/net/netiucv.c linux-2.6-patched/drivers/s390/net/netiucv.c
--- linux-2.6/drivers/s390/net/netiucv.c 2009-03-04 15:58:03.000000000 +0100
+++ ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 4/9] [PATCH] claw: invalid return codes from hard ...
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warnings by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 2 ++
1 file changed, 2 insertions(+)
diff -urpN linux-2.6/drivers/s390/net/claw.c linux-2.6-patched/drivers/s390/net/claw.c
--- linux-2.6/drivers/s390/net/claw.c 2008-12-25 00:26:37.000000000 +0100
+++ ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 9/9] [PATCH] claw: fix minor findings from code a ...
From: Andrew H. Richter <richtera@us.ibm.com>
This patch fixes two problems in the claw driver identified by
static code analysis:
o Change in case differentiation of received sense codes
o Use correct data length in claw hard_start_xmit routine
Signed-off-by: Andrew H. Richter <richtera@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 44 ++++++++++++++++++++------------------------
1 file changed, 20 insertions(+), 24 ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 7/9] [PATCH] ctcm: fix minor findings from code a ...
From: Joel A. Fowler <fowlerja@us.ibm.com>
From: Ursula Braun <ursula.braun@de.ibm.com>
This patch fixes problems in the ctcm driver identified by
static code analysis:
o remove an unnecessary always true condition in ctcm_unpack_skb
o remove duplicate assignment in ctc_mpc_alloc_channel
o remove an unnecessary always true condition in ctcmpc_send_sweep_resp
o remove duplicate initialization in ctcmpc_unpack_skb
o shorten if condition in mpc_action_go_inop
o remove INOP event if mpc group is ...
| Mar 24, 5:29 am 2009 |
| Ursula Braun | [patch 8/9] [PATCH] kmsg: convert claw printk messages t ...
From: Andy Richter <richtera@us.ibm.com>
Signed-off-by: Andy Richter <richtera@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 428 +++++++++++++++++++++++++-----------------------
1 file changed, 231 insertions(+), 197 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/claw.c linux-2.6-patched/drivers/s390/net/claw.c
--- linux-2.6/drivers/s390/net/claw.c 2009-03-19 11:16:39.000000000 +0100
+++ ...
| Mar 24, 5:29 am 2009 |
| Pablo Neira Ayuso | [ANNOUNCE]: Release of iptables-1.4.3.1
The netfilter coreteam presents:
iptables version 1.4.3.1
the iptables release for the 2.6.29 kernel. This version includes a
compilation fix and a couple of minor fixes:
- compilation error fix from Peter Volkov
- documentation update from Jan Engelhardt
- cleanup error reporting by myself.
Check out the Changelog for more details.
Remember that this release (and 1.4.3) starts enforcing the deprecation
of NAT filtering that was added in 1.4.2-rc1, filtering rules in the ...
| Mar 24, 6:08 am 2009 |
| Ingo Molnar | Re: Revert "gro: Fix legacy path napi_complete crash", ( ...
(netdev Cc:-ed)
Note, the .config is randconfig derived. There was a stage of the
tests when about every ~5-10th randconfig was failing, so i dont
think it's a rare config combo that triggers this. (but there were
other stages where 30 randconfig in a row went fine so it's hard to
tell.)
In the worst case the hang needed 2 million packets to trigger -
that's why i set the limit in the tests to 6 million packets.
Ingo
--
| Mar 24, 6:12 am 2009 |
| David Miller | Re: [PATCH] ucc_geth: Fix build breakage caused by a merge
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied, thanks Anton.
--
| Mar 24, 12:07 pm 2009 |
| Anton Vorontsov | [PATCH] ucc_geth: Fix build breakage caused by a merge
This patch fixes following build error:
CC ucc_geth.o
ucc_geth.c: In function 'ucc_geth_probe':
ucc_geth.c:3644: error: implicit declaration of function 'uec_mdio_bus_name'
make[2]: *** [ucc_geth.o] Error 1
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
Thanks for heads up, there is indeed a small issue.
drivers/net/ucc_geth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index ...
| Mar 24, 8:37 am 2009 |
| Kumar Gala | make sure ucc_geth.c fixed-link support still works in n ...
Anton, Andy
Can you take a look at the recent net-next tree and make sure that the
merge between the fsl_pq_mdio.c support and the patch that went into
2.6.29 to fix fixed-link support in ucc_geth.c is correct and still
works.
See commits:
Merge branch master... (8be7cdccacfbfc707e7370cad9bb168defed636f)
ucc_geth: Fix merge error. (039a6f6a39d2aa30ee53afdb213ea6dd4482928b)
- k
--
| Mar 24, 6:15 am 2009 |
| Ursula Braun | [patch 1/9] [PATCH] Use kthread instead of kernel_thread
From: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Lcs uses low-level kernel_thread implementation.
All drivers should use <linux/kthread.h> API instead.
Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/lcs.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
--- linux-2.6/drivers/s390/net/lcs.c 2009-03-04 ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 2/9] [PATCH] lcs: invalid return codes from hard_ ...
From: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Lcs hard_start_xmit routine issued return codes other than
defined for this interface. Now lcs returns only either
NETDEV_TX_OK or NETDEV_TX_BUSY.
Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/lcs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
--- ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 0/9] [RESEND] s390: lcs / ctcm / claw / netiucv p ...
Dave,
sorry for the resend; I detected compiler and checkpatch warnings in
patch 8, which are now removed.
Here are a couple of drivers/s390/net-patches for 2.6.29 :
1/9: lcs: exploit <linux/kthread.h> - Klaus-Dieter Wacker
2/9: lcs: hard_start_xmit return codes - Klaus-Dieter Wacker
3/9: netiucv: hard_start_xmit return codes - Ursula Braun
4/9: claw: hard_start_xmit return codes - Ursula Braun
5/9: ctcm: hard_start_xmit return codes - Ursula ...
| Mar 24, 6:27 am 2009 |
| David Miller | Re: [patch 0/9] [RESEND] s390: lcs / ctcm / claw / netiu ...
From: Ursula Braun <ursula.braun@de.ibm.com>
As I mentioned net-next-2.6 already has the kmsg patch #8, I
added the rest.
Thanks.
--
| Mar 24, 3:29 pm 2009 |
| Ursula Braun | [patch 5/9] [PATCH] ctcm: invalid return code from hard_ ...
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warning by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/ctcm_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/net/ctcm_main.c linux-2.6-patched/drivers/s390/net/ctcm_main.c
--- linux-2.6/drivers/s390/net/ctcm_main.c 2009-03-04 15:58:03.000000000 +0100
+++ ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 6/9] [PATCH] ctcm: avoid wraparound in length of ...
From: Roel Kluin <roel.kluin@gmail.com>
Since the receive code should tolerate any incoming garbage, it
should be protected against a potential wraparound when manipulating
length values within incoming data.
block_len is unsigned, so a too large subtraction will cause a
wraparound.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/ctcm_fsms.c | 5 ++---
drivers/s390/net/ctcm_main.c | 3 ++-
2 files ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 9/9] [PATCH] claw: fix minor findings from code a ...
From: Andrew H. Richter <richtera@us.ibm.com>
This patch fixes two problems in the claw driver identified by
static code analysis:
o Change in case differentiation of received sense codes
o Use correct data length in claw hard_start_xmit routine
Signed-off-by: Andrew H. Richter <richtera@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 44 ++++++++++++++++++++------------------------
1 file changed, 20 insertions(+), 24 ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 4/9] [PATCH] claw: invalid return codes from hard ...
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warnings by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 2 ++
1 file changed, 2 insertions(+)
diff -urpN linux-2.6/drivers/s390/net/claw.c linux-2.6-patched/drivers/s390/net/claw.c
--- linux-2.6/drivers/s390/net/claw.c 2008-12-25 00:26:37.000000000 +0100
+++ ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 7/9] [PATCH] ctcm: fix minor findings from code a ...
From: Joel A. Fowler <fowlerja@us.ibm.com>
From: Ursula Braun <ursula.braun@de.ibm.com>
This patch fixes problems in the ctcm driver identified by
static code analysis:
o remove an unnecessary always true condition in ctcm_unpack_skb
o remove duplicate assignment in ctc_mpc_alloc_channel
o remove an unnecessary always true condition in ctcmpc_send_sweep_resp
o remove duplicate initialization in ctcmpc_unpack_skb
o shorten if condition in mpc_action_go_inop
o remove INOP event if mpc group is ...
| Mar 24, 6:27 am 2009 |
| David Miller | Re: [patch 8/9] [PATCH] kmsg: convert claw printk messag ...
From: Ursula Braun <ursula.braun@de.ibm.com>
This patch was already added to net-next-2.6 on January 20th:
commit 4811fcb79cee80c683237cfd15ca214e1d78c548
Author: Andy Richter <richtera@us.ibm.com>
Date: Tue Jan 20 06:14:33 2009 +0000
kmsg: convert claw printk messages
claw printks are converted to dev_xxx and pr_xxx macros.
Signed-off-by: Andy Richter <richtera@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. ...
| Mar 24, 3:28 pm 2009 |
| Ursula Braun | [patch 8/9] [PATCH] kmsg: convert claw printk messages t ...
From: Andy Richter <richtera@us.ibm.com>
Signed-off-by: Andy Richter <richtera@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/claw.c | 429 +++++++++++++++++++++++++-----------------------
1 file changed, 232 insertions(+), 197 deletions(-)
Index: linux-2.6-uschi/drivers/s390/net/claw.c
===================================================================
--- linux-2.6-uschi.orig/drivers/s390/net/claw.c
+++ ...
| Mar 24, 6:27 am 2009 |
| Ursula Braun | [patch 3/9] [PATCH] netiucv: invalid return code from ha ...
From: Ursula Braun <ursula.braun@de.ibm.com>
Avoid kernel warning by using the correct hard_start_xmit return
code NETDEV_TX_BUSY for skb requeuing.
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---
drivers/s390/net/netiucv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/drivers/s390/net/netiucv.c linux-2.6-patched/drivers/s390/net/netiucv.c
--- linux-2.6/drivers/s390/net/netiucv.c 2009-03-04 15:58:03.000000000 +0100
+++ ...
| Mar 24, 6:27 am 2009 |
| Patrick McHardy | netfilter 10/41: xt_physdev fixes
commit 4f1c3b7e7ee4d841c8af3a074dc361d6a7a77803
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Wed Feb 18 19:11:39 2009 +0100
netfilter: xt_physdev fixes
1) physdev_mt() incorrectly assumes nulldevname[] is aligned on an int
2) It also uses word comparisons, while it could use long word ones.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/xt_physdev.c ...
| Mar 24, 7:03 am 2009 |
| David Miller | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
From: Jan Engelhardt <jengelh@medozas.de>
Agreed.
--
| Mar 24, 2:25 pm 2009 |
| Jan Engelhardt | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
You are right; we would have to calculate the prefix length of the
mask first. (And I think we can assume that there will not be any 1s
Very well.
--
| Mar 24, 2:52 pm 2009 |
| Jan Engelhardt | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
Allow me some skepticism, but the code looks pretty much like a
--
| Mar 24, 2:17 pm 2009 |
| David Miller | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
From: Patrick McHardy <kaber@trash.net>
I think we can at least give some help for the platforms which
require alignment.
We can, for example, assume 16-bit alignment and thus loop
over u16's
--
| Mar 24, 1:29 pm 2009 |
| Eric Dumazet | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
Right. How about this incremental patch ?
Thanks
[PATCH] arp_tables: ifname_compare() can assume 16bit alignment
Arches without efficient unaligned access can still perform a loop
assuming 16bit alignment in ifname_compare()
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 64a7c6c..84b9c17 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -76,6 +76,7 @@ static ...
| Mar 24, 2:06 pm 2009 |
| Eric Dumazet | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
memcmp() is fine, but how is it solving the masking problem we have ?
Also in the case of arp_tables, _a is long word aligned, while _b and _mask are not.
memcmp() in this case is slower, (and dont handle mask thing)
If you look various ifname_compare(), we have two different implementations.
So yes, a factorization is possible for three ip_tables.c, ip6_tables.c and xt_physdev.c
--
| Mar 24, 2:39 pm 2009 |
| David Miller | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
From: Jan Engelhardt <jengelh@medozas.de>
memcmp() can't make any assumptions about alignment.
Whereas we _know_ this thing is exactly 16-bit aligned.
All of the optimized memcmp() implementations look for
32-bit alignment and punt to byte at a time comparison
loops if things are not aligned enough.
--
| Mar 24, 2:18 pm 2009 |
| Patrick McHardy | netfilter 07/41: arp_tables: unfold two critical loops i ...
commit ddc214c43a923e89741e04da2f10e3037a64e222
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Wed Feb 18 17:47:50 2009 +0100
netfilter: arp_tables: unfold two critical loops in arp_packet_match()
x86 and powerpc can perform long word accesses in an efficient maner.
We can use this to unroll two loops in arp_packet_match(), to
perform arithmetic on long words instead of bytes. This is a win
on x86_64 for example.
Signed-off-by: Eric Dumazet ...
| Mar 24, 7:03 am 2009 |
| David Miller | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
From: Eric Dumazet <dada1@cosmosbay.com>
Looks great, applied, thanks Eric!
--
| Mar 24, 2:16 pm 2009 |
| Jan Engelhardt | Re: netfilter 07/41: arp_tables: unfold two critical loo ...
Yes, I seem to remember glibc doing something like
if ((addr & 0x03) != 0) {
// process single bytes (increment addr as you go)
// until addr & 0x03 == 0.
}
/* optimized loop here. also increases addr */
if ((addr & 0x03) != 0)
// still bytes left after loop - process on a per-byte basis
Is the cost of testing for non-4-divisibility expensive enough
to warrant not usnig memcmp?
Irrespective of all that, I think putting the interface comparison
code should be ...
| Mar 24, 2:23 pm 2009 |
| Patrick McHardy | netfilter 12/41: xt_physdev: unfold two loops in physdev_mt()
commit eacc17fb64f03b6c268aaf6cea320100d19d8af5
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu Feb 19 11:17:17 2009 +0100
netfilter: xt_physdev: unfold two loops in physdev_mt()
xt_physdev netfilter module can use an ifname_compare() helper
so that two loops are unfolded.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c
index ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 30/41: auto-load ip6_queue module when socket opened
commit 26c3b6780618f09abb5f7e03b09b13dbb8e8aa24
Author: Scott James Remnant <scott@canonical.com>
Date: Mon Mar 16 15:30:14 2009 +0100
netfilter: auto-load ip6_queue module when socket opened
The ip6_queue module is missing the net-pf-16-proto-13 alias that would
cause it to be auto-loaded when a socket of that type is opened. This
patch adds the alias.
Signed-off-by: Scott James Remnant <scott@canonical.com>
Signed-off-by: Tim Gardner ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 18/41: ip_tables: unfold two critical loops in ...
commit 08361aa807ae5e5007cd226ca9e34287512de737
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Fri Feb 20 11:03:33 2009 +0100
netfilter: ip_tables: unfold two critical loops in ip_packet_match()
While doing oprofile tests I noticed two loops are not properly unrolled by gcc
Using a hand coded unrolled loop provides nice speedup : ipt_do_table
credited of 2.52 % of cpu instead of 3.29 % in tbench.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 36/41: ctnetlink: remove remaining module refc ...
commit cd91566e4bdbcb8841385e4b2eacc8d0c29c9208
Author: Florian Westphal <fw@strlen.de>
Date: Wed Mar 18 17:28:37 2009 +0100
netfilter: ctnetlink: remove remaining module refcounting
Convert the remaining refcount users.
As pointed out by Patrick McHardy, the protocols can be accessed safely using RCU.
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/nf_conntrack_netlink.c ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 38/41: ctnetlink: fix rcu context imbalance
commit 0f5b3e85a3716efebb0150ebb7c6d022e2bf17d7
Author: Patrick McHardy <kaber@trash.net>
Date: Wed Mar 18 17:36:40 2009 +0100
netfilter: ctnetlink: fix rcu context imbalance
Introduced by 7ec47496 (netfilter: ctnetlink: cleanup master conntrack assignation):
net/netfilter/nf_conntrack_netlink.c:1275:2: warning: context imbalance in 'ctnetlink_create_conntrack' - different lock contexts for basic block
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 41/41: nf_conntrack: Reduce conntrack count in ...
commit 1d45209d89e647e9f27e4afa1f47338df73bc112
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue Mar 24 14:26:50 2009 +0100
netfilter: nf_conntrack: Reduce conntrack count in nf_conntrack_free()
We use RCU to defer freeing of conntrack structures. In DOS situation, RCU might
accumulate about 10.000 elements per CPU in its internal queues. To get accurate
conntrack counts (at the expense of slightly more RAM used), we might consider
conntrack counter not taking ...
| Mar 24, 7:04 am 2009 |
| Patrick McHardy | net 33/41: sysctl_net - use net_eq to compare nets
commit 81a1d3c31e3517f9939b3e04d21cf4a6b0997419
Author: Cyrill Gorcunov <gorcunov@openvz.org>
Date: Mon Mar 16 16:23:30 2009 +0100
net: sysctl_net - use net_eq to compare nets
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/sysctl_net.c b/net/sysctl_net.c
index 972201c..0b15d72 100644
--- a/net/sysctl_net.c
+++ b/net/sysctl_net.c
@@ -61,7 +61,7 ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 21/41: xt_hashlimit fix
commit 28337ff5438a640afa713d874d076e3a8a9150da
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue Feb 24 15:30:29 2009 +0100
netfilter: xt_hashlimit fix
Commit 784544739a25c30637397ace5489eeb6e15d7d49
(netfilter: iptables: lock free counters) broke xt_hashlimit netfilter module :
This module was storing a pointer inside its xt_hashlimit_info, and this pointer
is not relocated when we temporarly switch tables (iptables -L).
This hack is not not ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 39/41: sysctl support of logger choice
commit 176252746ebbc8db97e304345af1f2563c7dc139
Author: Eric Leblond <eric@inl.fr>
Date: Mon Mar 23 13:16:53 2009 +0100
netfilter: sysctl support of logger choice
This patchs adds support of modification of the used logger via sysctl.
It can be used to change the logger to module that can not use the bind
operation (ipt_LOG and ipt_ULOG). For this purpose, it creates a
directory /proc/sys/net/netfilter/nf_log which contains a file
per-protocol. The content of ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 09/41: Combine ipt_ttl and ip6t_hl source
commit cfac5ef7b92a2d504563989ecd0beb563920444b
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Wed Feb 18 18:39:31 2009 +0100
netfilter: Combine ipt_ttl and ip6t_hl source
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index 3ad9f43..40ad41f 100644
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -92,15 +92,6 @@ config ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 22/41: use a linked list of loggers
commit ca735b3aaa945626ba65a3e51145bfe4ecd9e222
Author: Eric Leblond <eric@inl.fr>
Date: Mon Mar 16 14:54:21 2009 +0100
netfilter: use a linked list of loggers
This patch modifies nf_log to use a linked list of loggers for each
protocol. This list of loggers is read and write protected with a
mutex.
This patch separates registration and binding. To be used as
logging module, a module has to register calling nf_log_register()
and to bind to a protocol ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 32/41: xtables: avoid pointer to self
commit acc738fec03bdaa5b77340c32a82fbfedaaabef0
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Mon Mar 16 15:35:29 2009 +0100
netfilter: xtables: avoid pointer to self
Commit 784544739a25c30637397ace5489eeb6e15d7d49 (netfilter: iptables:
lock free counters) broke a number of modules whose rule data referenced
itself. A reallocation would not reestablish the correct references, so
it is best to use a separate struct that does not fall under RCU.
...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | nefilter 40/41: nfnetlink: add nfnetlink_set_err and use ...
commit dd5b6ce6fd465eab90357711c8e8124dc3a31ff0
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon Mar 23 13:21:06 2009 +0100
nefilter: nfnetlink: add nfnetlink_set_err and use it in ctnetlink
This patch adds nfnetlink_set_err() to propagate the error to netlink
broadcast listener in case of memory allocation errors in the
message building.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy ...
| Mar 24, 7:04 am 2009 |
| Patrick McHardy | net 34/41: netfilter conntrack - add per-net functionali ...
commit 1546000fe8db0d3f47b0ef1dd487ec23fbd95313
Author: Cyrill Gorcunov <gorcunov@openvz.org>
Date: Mon Mar 16 16:30:49 2009 +0100
net: netfilter conntrack - add per-net functionality for DCCP protocol
Module specific data moved into per-net site and being allocated/freed
during net namespace creation/deletion.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr>
Signed-off-by: Patrick McHardy ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 35/41: xtables: add cluster match
commit 0269ea4937343536ec7e85649932bc8c9686ea78
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon Mar 16 17:10:36 2009 +0100
netfilter: xtables: add cluster match
This patch adds the iptables cluster match. This match can be used
to deploy gateway and back-end load-sharing clusters. The cluster
can be composed of 32 nodes maximum (although I have only tested
this with two nodes, so I cannot tell what is the real scalability
limit of this solution in ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 11/41: xtables: add backward-compat options
commit 4323362e49bd10b8ff3fe5cf183fdd52662ff4a3
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Thu Feb 19 11:16:03 2009 +0100
netfilter: xtables: add backward-compat options
Concern has been expressed about the changing Kconfig options.
Provide the old options that forward-select.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 37/41: remove nf_ct_l4proto_find_get/nf_ct_l4p ...
commit 711d60a9e7f88e394ccca10f5fc83f95f0cea5b1
Author: Florian Westphal <fw@strlen.de>
Date: Wed Mar 18 17:30:50 2009 +0100
netfilter: remove nf_ct_l4proto_find_get/nf_ct_l4proto_put
users have been moved to __nf_ct_l4proto_find.
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/include/net/netfilter/nf_conntrack_l4proto.h b/include/net/netfilter/nf_conntrack_l4proto.h
index 16ab604..b01070b 100644
--- ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 31/41: auto-load ip_queue module when socket opened
commit 95ba434f898c3cb5c7457dce265bf0ab72ba8ce9
Author: Scott James Remnant <scott@canonical.com>
Date: Mon Mar 16 15:31:10 2009 +0100
netfilter: auto-load ip_queue module when socket opened
The ip_queue module is missing the net-pf-16-proto-3 alias that would
causae it to be auto-loaded when a socket of that type is opened. This
patch adds the alias.
Signed-off-by: Scott James Remnant <scott@canonical.com>
Signed-off-by: Tim Gardner ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 23/41: print the list of register loggers
commit c7a913cd5535554d6f5d5e1f5ef46c4307cf2afc
Author: Eric Leblond <eric@inl.fr>
Date: Mon Mar 16 14:55:27 2009 +0100
netfilter: print the list of register loggers
This patch modifies the proc output to add display of registered
loggers. The content of /proc/net/netfilter/nf_log is modified. Instead
of displaying a protocol per line with format:
proto:logger
it now displays:
proto:logger (comma_separated_list_of_loggers)
NONE is used as keyword if ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 28/41: ctnetlink: cleanup conntrack update pre ...
commit e098360f159b3358f085543eb6dc2eb500d6667c
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon Mar 16 15:27:22 2009 +0100
netfilter: ctnetlink: cleanup conntrack update preliminary checkings
This patch moves the preliminary checkings that must be fulfilled
to update a conntrack, which are the following:
* NAT manglings cannot be updated
* Changing the master conntrack is not allowed.
This patch is a cleanup.
Signed-off-by: ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 26/41: conntrack: increase drop stats if seque ...
commit 1db7a748dfd50d7615913730763c024444900030
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon Mar 16 15:18:50 2009 +0100
netfilter: conntrack: increase drop stats if sequence adjustment fails
This patch increases the statistics of packets drop if the sequence
adjustment fails in ipv4_confirm().
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 27/41: ctnetlink: cleanup master conntrack ass ...
commit 7ec4749675bf33ea639bbcca8a5365ccc5091a6a
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon Mar 16 15:25:46 2009 +0100
netfilter: ctnetlink: cleanup master conntrack assignation
This patch moves the assignation of the master conntrack to
ctnetlink_create_conntrack(), which is where it really belongs.
This patch is a cleanup.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 20/41: install missing headers
commit d060ffc1840e37100628f520e66600c5ae483b44
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Tue Feb 24 15:23:58 2009 +0100
netfilter: install missing headers
iptables imports headers from (the unifdefed headers of a)
kernel tree, but some headers happened to not be installed.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/include/linux/netfilter/Kbuild ...
| Mar 24, 7:03 am 2009 |
| Jan Engelhardt | Re: netfilter 25/41: Kconfig spelling fixes (trivial)
Please add this patch as a followup commit.
parent 1d45209d89e647e9f27e4afa1f47338df73bc112 (v2.6.29-rc5-881-g1d45209)
commit 85982fcfd17fbb1000302e253f82edd88efa180c
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Tue Mar 24 15:18:17 2009 +0100
netfilter: trivial Kconfig spelling fixes
Supplements commit 67c0d57930ff9a24c6c34abee1b01f7716a9b0e2.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
net/ipv6/netfilter/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 ...
| Mar 24, 7:20 am 2009 |
| David Miller | Re: netfilter 25/41: Kconfig spelling fixes (trivial)
From: Jan Engelhardt <jengelh@medozas.de>
Applied.
--
| Mar 24, 1:35 pm 2009 |
| Patrick McHardy | netfilter 25/41: Kconfig spelling fixes (trivial)
commit 67c0d57930ff9a24c6c34abee1b01f7716a9b0e2
Author: Stephen Hemminger <sheminger@vyatta.com>
Date: Mon Mar 16 15:17:23 2009 +0100
netfilter: Kconfig spelling fixes (trivial)
Signed-off-by: Stephen Hemminger <sheminger@vyatta.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index f8d6180..1833bdb 100644
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -31,7 +31,7 @@ config ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 15/41: nf_conntrack: table max size should hol ...
commit e478075c6f07a383c378fb400edc1a7407a941b0
Author: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Fri Feb 20 10:47:09 2009 +0100
netfilter: nf_conntrack: table max size should hold at least table size
Table size is defined as unsigned, wheres the table maximum size is
defined as a signed integer. The calculation of max is 8 or 4,
multiplied the table size. Therefore the max value is aligned to
unsigned.
Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 29/41: ctnetlink: move event reporting for new ...
commit f0a3c0869f3b0ef93d9df044e9a41e40086d4c97
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon Mar 16 15:28:09 2009 +0100
netfilter: ctnetlink: move event reporting for new entries outside the lock
This patch moves the event reporting outside the lock section. With
this patch, the creation and update of entries is homogeneous from
the event reporting perspective. Moreover, as the event reporting is
done outside the lock section, the netlink broadcast ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 16/41: fix hardcoded size assumptions
commit af07d241dc76f0a52c7ff04df3a3970020fe6157
Author: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Fri Feb 20 10:48:06 2009 +0100
netfilter: fix hardcoded size assumptions
get_random_bytes() is sometimes called with a hard coded size assumption
of an integer. This could not be true for next centuries. This patch
replace it with a compile time statement.
Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
Signed-off-by: Patrick McHardy ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 01/41: change generic l4 protocol number
commit fe2a7ce4de07472ace0cdf460a41f462a4621687
Author: Christoph Paasch <christoph.paasch@student.uclouvain.be>
Date: Wed Feb 18 16:28:35 2009 +0100
netfilter: change generic l4 protocol number
0 is used by Hop-by-hop header and so this may cause confusion.
255 is stated as 'Reserved' by IANA.
Signed-off-by: Christoph Paasch <christoph.paasch@student.uclouvain.be>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 19/41: nf_conntrack: account packets drop by t ...
commit 7d1e04598e5e92527840b6889fb75b4b30fdd33b
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue Feb 24 14:48:01 2009 +0100
netfilter: nf_conntrack: account packets drop by tcp_packet()
Since tcp_packet() may return -NF_DROP in two situations, the
packet-drop stats must be increased.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/nf_conntrack_core.c ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 24/41: remove IPvX specific parts from nf_conn ...
commit 9d2493f88f846b391a15a736efc7f4b97d6c4046
Author: Christoph Paasch <christoph.paasch@gmail.com>
Date: Mon Mar 16 15:15:35 2009 +0100
netfilter: remove IPvX specific parts from nf_conntrack_l4proto.h
Moving the structure definitions to the corresponding IPvX specific header files.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/include/net/netfilter/nf_conntrack_l4proto.h b/include/net/netfilter/nf_conntrack_l4proto.h
index debdaf7..16ab604 ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 06/41: log invalid new icmpv6 packet with nf_l ...
commit 55df4ac0c927c7f1f84e6d75532f0ca45d391e64
Author: Eric Leblond <eric@inl.fr>
Date: Wed Feb 18 16:30:56 2009 +0100
netfilter: log invalid new icmpv6 packet with nf_log_packet()
This patch adds a logging message for invalid new icmpv6 packet.
Signed-off-by: Eric Leblond <eric@inl.fr>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
index ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 05/41: ebtables: remove unneeded initializations
commit 842bff366b536787b88c07cbf2416e2cb26cae67
Author: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed Feb 18 16:30:38 2009 +0100
netfilter: ebtables: remove unneeded initializations
The initialization of the lock element is not needed
since the lock is always initialized in ebt_register_table.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/bridge/netfilter/ebtable_broute.c ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 13/41: ip6_tables: unfold two loops in ip6_pac ...
commit 323dbf96382f057d035afce0237f08e18571ac1d
Author: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu Feb 19 11:18:23 2009 +0100
netfilter: ip6_tables: unfold two loops in ip6_packet_match()
ip6_tables netfilter module can use an ifname_compare() helper
so that two loops are unfolded.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/ipv6/netfilter/ip6_tables.c ...
| Mar 24, 7:03 am 2009 |
| David Miller | Re: netfilter 00/41: Netfilter update for 2.6.30
From: Patrick McHardy <kaber@trash.net>
I'm going to pull this all in, thanks Patrick.
I'll reply to a few patches for which I'd like to see some
followup discussion and change.
Thanks.
--
| Mar 24, 1:26 pm 2009 |
| Patrick McHardy | netfilter 17/41: x_tables: add LED trigger target
commit 268cb38e1802db560c73167e643f14a3dcb4b07c
Author: Adam Nielsen <a.nielsen@shikadi.net>
Date: Fri Feb 20 10:55:14 2009 +0100
netfilter: x_tables: add LED trigger target
Kernel module providing implementation of LED netfilter target. Each
instance of the target appears as a led-trigger device, which can be
associated with one or more LEDs in /sys/class/leds/
Signed-off-by: Adam Nielsen <a.nielsen@shikadi.net>
Acked-by: Richard Purdie ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 03/41: x_tables: change elements in x_tables
commit 4a2f965ca5a4e2593744bf75425d85e0e8ff814a
Author: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed Feb 18 16:29:44 2009 +0100
netfilter: x_tables: change elements in x_tables
Change to proper type on private pointer rather than anonymous void.
Keep active elements on same cache line.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/include/linux/netfilter/x_tables.h ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 04/41: x_tables: remove unneeded initializations
commit 9c8222b9e71b690c8388bb0ebe5c3e5a1469e884
Author: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed Feb 18 16:30:20 2009 +0100
netfilter: x_tables: remove unneeded initializations
Later patches change the locking on xt_table and the initialization of
the lock element is not needed since the lock is always initialized in
xt_table_register anyway.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Patrick McHardy ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 02/41: remove unneeded goto
commit fecea3a389c89de9afae2eda74fad894d5677229
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Wed Feb 18 16:29:08 2009 +0100
netfilter: remove unneeded goto
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index a90ac83..5bb3473 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -174,7 +174,6 @@ next_hook:
outdev, &elem, okfn, ...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 14/41: iptables: lock free counters
commit 784544739a25c30637397ace5489eeb6e15d7d49
Author: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri Feb 20 10:35:32 2009 +0100
netfilter: iptables: lock free counters
The reader/writer lock in ip_tables is acquired in the critical path of
processing packets and is one of the reasons just loading iptables can cause
a 20% performance loss. The rwlock serves two functions:
1) it prevents changes to table state (xt_replace) while table is in use.
...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 08/41: Combine ipt_TTL and ip6t_HL source
commit 563d36eb3fb22dd04da9aa6f12e1b9ba0ac115f3
Author: Jan Engelhardt <jengelh@medozas.de>
Date: Wed Feb 18 18:38:40 2009 +0100
netfilter: Combine ipt_TTL and ip6t_HL source
Suggested by: James King <t.james.king@gmail.com>
Similarly to commit c9fd49680954714473d6cbd2546d6ff120f96840, merge
TTL and HL. Since HL does not depend on any IPv6-specific function,
no new module dependencies would arise.
With slight adjustments to the Kconfig help text.
...
| Mar 24, 7:03 am 2009 |
| Patrick McHardy | netfilter 00/41: Netfilter update for 2.6.30
Hi Dave,
the following patches contain (the major part of) my netfilter updates for 2.6.30.
Besides the usual small fixes and cleanups, there is:
- a new LED trigger target by Adam Nielsen
- device name match optimizations for *tables from Eric Dumazet
- Conversion of *tables to use RCU for rulesets and counters from Stephen
and Eric
- unification of the TTL/HL targets and ttl/hl matches from Jan Engelhardt
- a new "cluster" match from Pablo to transparently distribute traffic ...
| Mar 24, 7:03 am 2009 |
| Marco Berizzi | Re: network traffic stop with 2.6.29 after ftp put
yes this patch fix the problem.
Thanks Eric and thanks Herbert.
--
| Mar 24, 8:41 am 2009 |
| david | Re: Network Device Naming mechanism and policy
I have seen systems (I think they were Sun boxes) where the _machine_ had
a MAC address, and it used that same MAC on all interfaces.
this is convienient for some things, but not for others.
what's unique and reproducable is the discovery order
David Lang
--
| Mar 24, 11:51 am 2009 |
| Kay Sievers | Re: Network Device Naming mechanism and policy
This is handled in most cases. Virtual interfaces claiming a
configured name and created before the "hardware" interface are not
How? The kernel assignes the names and the configured names may
conflict. So you possibly can not rename a device to the target name
when it's name is already taken. I don't see how to avoid this.
Thanks,
Kay
--
| Mar 24, 9:28 am 2009 |
| Alan Cox | Re: Network Device Naming mechanism and policy
Not in the case of things like USB...
--
| Mar 24, 2:02 pm 2009 |
| Scott James Remnant | Re: Network Device Naming mechanism and policy
Not to mention that All The World Is Not x86
Scott
--=20
Scott James Remnant
scott@ubuntu.com
| Mar 24, 11:20 am 2009 |
| Patrick McHardy | Re: Network Device Naming mechanism and policy
I don't remember the exact circumstances, but I've seen it quite a few
Sure, you can't rename it when the name is taken. But what udev
apparently does when renaming a device is:
- rename eth0 to eth0_rename
- rename eth0_rename to eth2
- rename returns -EEXISTS: udev keeps eth0_rename
What it could do is:
- rename eth0 to eth2
- rename returns -EEXISTS: device at least still has a proper name
Alternatively it should unroll the rename and hope that the
old name is still free. But I ...
| Mar 24, 9:38 am 2009 |
| Patrick McHardy | Re: Network Device Naming mechanism and policy
I would classify this as a bug, especially the fact that udev doesn't
undo a failed rename, so you end up with ethX_rename. Virtual devices
using the same MAC address trigger this reliably unless you add
exceptions to the udev rules.
You state that it only operates on one device at a time. If that is
correct, I'm not sure why the _rename suffix is used at all instead
of simply trying to assign the final name, which would avoid this
problem.
--
| Mar 24, 9:21 am 2009 |
| Patrick McHardy | Re: Network Device Naming mechanism and policy
Sometimes (I was referring to virtual devices) there may not be
I agree that udev can't do anything useful in that case. I would
prefer it it wouldn't even try though instead of messing with the
names and leaving a bunch of _rename devices around. Sure, I can
add a rule to disable it, but that shouldn't be necessary.
Generally, I'm wondering whether it should touch virtual network
devices at all since the MAC addresses are often not persistent,
sometimes not unique and the name might have ...
| Mar 24, 10:04 am 2009 |
| Matt Domsch | Re: Network Device Naming mechanism and policy
actually biosdevname handles this already, using eth_pccard_X.Y where
we would obviously need a solution. eth_usb_{something} perhaps.
--
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
--
| Mar 24, 10:52 am 2009 |
| Karl O. Pinc | Re: Network Device Naming mechanism and policy
My thoughts on the subject; from someone who is not
particularly qualified to have opinions.
Reading over your post, I searched for a single sentence describing
the problem you're trying to solve. What I came up with was
this:
Perhaps a little magic in the udev rule that creates the
z70_persistent-net-rules file would solve the basic problem.
It could sort the nics by mac address when creating the
names. It need only run when the z70 file does not exist.
I presume this would produce ...
| Mar 24, 9:42 am 2009 |
| David Miller | Re: Network Device Naming mechanism and policy
From: Matt Domsch <Matt_Domsch@dell.com>
I learned a long time ago that eth0 et al. have zero meaning.
If the system firmware folks gave us topology information with respect
to these things, we could export something that tools such as
NetworkManager, iproute2, etc. could use.
For example, if we were told that PCI device "domain:bus:dev:fn" has
string label "Onboard Ethernet 0" then we could present that to the
user.
Changing how the actual network device name is determined is going ...
| Mar 24, 3:57 pm 2009 |
| david | Re: Network Device Naming mechanism and policy
I dispute this statement.
I have several hundred servers that have the on-motherboard NICs as the
last ones.
anyone who's been making the assumption you describe will have been
running into problems for many years.
not everyone uses udev. I compile the nessasary drivers into the kernel
this approach causes serious problems in a few cases, including
1. a NIC goes bad and you replace it. now all the configs change
2. you reinstall a box and it's interface names ...
| Mar 24, 11:49 am 2009 |
| Matt Domsch | Re: Network Device Naming mechanism and policy
nearly all dell systems running linux in the world were not
factory-installed with that os. this isn't something i can simply
patch in our factories. it needs to be fixed as far upstream as
well, there is no "mac address sort" anywhere. (nor is that really a
It's not a BIOS problem. BIOS can inform the OS of what it thinks
about hardware location, names, etc. And our PowerEdge (9G and newer)
servers do - using SMBIOS 2.6 standard features we added (types 9, 10,
and 41) to the ...
| Mar 24, 10:45 am 2009 |
| Matt Domsch | Network Device Naming mechanism and policy
You may recall http://lkml.org/lkml/2006/9/29/268, wherein I described
network device enumeration and naming challenges, and several possible
fixes. Of these, Fix #1 (fix the PCI device list to be sorted
breadth-first) has been implemented in the kernel, and Fix #3 (system
board routing rules) have been implemented on Dell PowerEdge 10G and
11G servers (11G begin selling RSN).
However, these have not been completely satisfactory. In particular,
it keeps getting harder and harder to route ...
| Mar 24, 8:46 am 2009 |
| Matt Domsch | Re: Network Device Naming mechanism and policy
I agree it's not a valid assumption.
People seem to want two things with names:
1) that devices be named deterministically
2) that the determinism doesn't change on a per-platform or
per-configuration-of-a-platform basis.
This tends to mean they want the onboard devices named first, then the
add-in devices named. But not necessarily. I would hope to have a
deterministic naming method that would work for most people by
Right. These cases are only deterministic because they start ...
| Mar 24, 12:22 pm 2009 |
| Scott James Remnant | Re: Network Device Naming mechanism and policy
Also bear in mind that a module completing init() does not necessarily
mean that the interfaces have been created. If the driver requires
firmware, it will call out to userspace, and may not register the
interface until well afterwards.
One could even construct a pathological case where only a virtual device
was registered, and userspace was required to add logical interfaces
Well, the obvious fix to this is to make sure the names are always
Actually udev handles this by using a temporary ...
| Mar 24, 10:02 am 2009 |
| Alan Cox | Re: Network Device Naming mechanism and policy
> If the MAC address isn't a UUID for the device, then *what* is?
MAC is technically per system if desired (eg old Sun boxes) and that is
quite valid by IEE802.3. In that case you need MAC + topology.
If you are running DECnet your system runs on assigned MAC addresses so
you also have to be careful to use the EPROM MAC (if one exists which is
I'd argue the fumdamental problem is that I can do this
ln -s /dev/sda /dev/thebigdiskunderthefridge
but cannot ln -s /dev/eth0 ...
| Mar 24, 10:00 am 2009 |
| Bill Nottingham | Re: Network Device Naming mechanism and policy
Right, but having biosdevname chase each new bus that comes along
sounds iffy. I'd prefer /dev/net/by-name symlinks, if at all
possible. But that's a lot of code that I'm not prepared to write.
Bill
--
| Mar 24, 11:12 am 2009 |
| Greg KH | Re: Network Device Naming mechanism and policy
Or even PCI.
/me pats his laptop that reassigns PCI device ids randomly every 3rd or so boot.
--
| Mar 24, 4:14 pm 2009 |
| Dan Williams | Re: Network Device Naming mechanism and policy
Any particular reason the MAC addresses are the same? This came up a
while ago with the 'dnet' device in the thread "Dave DNET ethernet
controller".
If the MAC address isn't a UUID for the device, then *what* is?
If there isn't one, then certainly udev can't be blamed for getting
ordering or names wrong, because there's nothing to use to actually
match up the device to a name, uniquely. Note that combinations
including bus IDs or device positions in the bus don't work for any type
of ...
| Mar 24, 9:40 am 2009 |
| Mr. Berkley Shands | 2.6.29 forcedeth hang W/O NAPI enabled
Another new kernel, another interesting lock up. Centos 5.2, X86_84 on
an opteron 8GB 4 cores (275 X 2).
If CONFIG_FORCEDETH_NAPI is not enabled, then within 60 seconds of the
console login prompt
appearing, the network becomes unresponsive. packets are seen to appear
according to ifconfig eth0
and with ethtool -S eth0, but they go nowhere. NFS stops, ping stops,
logins stop, ldap stops.
My network is class B, netmask 255.255.0.0, and the department router is
directly connected
under ...
| Mar 24, 8:28 am 2009 |
| Ingo Molnar | Re: BUG in 2.6.29 final: broken network connection
Nonsense. 303c6a0 "gro: Fix legacy path napi_complete crash" was an
obvious looking bug fix for a real crash that was reported, against
a commit that went upstream in 2.6.29-rc1.
It was a fix for a serious regression and i'd have applied it too,
and would have pushed it to Linus.
Furthermore, even on affected systems it took certain configs and
certain conditions for the bug to trigger under high load. So there
was no real good way to find this bug quickly.
Such kind of bugs can ...
| Mar 24, 12:42 pm 2009 |
| Josh Stone | [PATCH] Add dependent headers to trace/skb.h
The tracing header needs to include definitions for the macros used and
the types referenced. This lets automated tracing tools like SystemTap
make use of the tracepoint without any specific knowledge of its
meaning (leaving that to the user).
Signed-off-by: Josh Stone <jistone@redhat.com>
CC: Neil Horman <nhorman@tuxdriver.com>
---
include/trace/skb.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/trace/skb.h b/include/trace/skb.h
index ...
| Mar 24, 12:44 pm 2009 |
| Geert Uytterhoeven | [PATCH] drivers/net/dnet.c needs <linux/io.h>
On m68k:
| drivers/net/dnet.c: In function 'dnet_readw_mac':
| drivers/net/dnet.c:36: error: implicit declaration of function 'writel'
| drivers/net/dnet.c:43: error: implicit declaration of function 'readl'
| drivers/net/dnet.c: In function 'dnet_probe':
| drivers/net/dnet.c:873: error: implicit declaration of function 'ioremap'
| drivers/net/dnet.c:873: warning: assignment makes pointer from integer without a cast
| drivers/net/dnet.c:939: error: implicit declaration of function ...
| Mar 24, 12:43 pm 2009 |
| David Miller | Re: [PATCH] drivers/net/dnet.c needs <linux/io.h>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thanks!
--
| Mar 24, 1:19 pm 2009 |
| janetmbeku787865 | Lieber Freund!!!
Lieber Freund!!!
Ich vermute das diese E-Mail eine Überraschung für Sie sein wird, aber es ist wahr.Ich bin bei einer routinen Überprüfung in meiner Bank (Standard Bank von Süd Afrika) wo ich arbeite, auf einem Konto gestoßen, was nicht in anspruch genommen worden ist, wo derzeit $12,500,000 (zwölfmillionenfünfhundert US Dollar) gutgeschrieben sind.
Dieses Konto gehörte Herrn Manfred Becker, der ein Kunde in unsere Bank war, der leider verstorben ist. Herr Becker war ein gebürtiger Deutscher.Damit ...
| Mar 24, 1:23 pm 2009 |
| Andrew Lutomirski | e1000e incorrectly reports a carrier until I plug in and ...
This is on a Lenovo x200s, and I have this bug on both 2.6.29 and
2.6.28.8. I haven't tried any other kernels on this machine.
When I boot the system without an ethernet cable plugged in, ip link
does not show NO-CARRIER until I've plugged in and unplugged my
ethernet cable. Oddly enough, ethtool shows the correct status the
whole time. This confuses me and NetworkManager.
dmesg says:
[ 2.338427] 0000:00:19.0: eth0: (PCI Express:2.5GB/s:Width x1)
xx:xx:xx:xx:xx:xx
[ 2.338489] ...
| Mar 24, 1:30 pm 2009 |
| David Miller | Re: net: Add dependent headers to trace/skb.h
Applied, thanks.
--
| Mar 24, 2:25 pm 2009 |
| Ingo Molnar | Re: BUG in 2.6.29 final: broken network connection
You got it exactly right.
This world is ruled by probabilities, and generally everything is
possible - even a bug slipping into a .0 release that you could
trigger personally, even though -rc1 through -rc8 worked just fine
for you.
Such things happened before, and they can happen again. Yes, it can
hit you - and it did hit me too and i'm not complaining.
We still try our best to reduce the probabilities. We cannot,
however, unfortunately, bring them down to zero. The fix looked ...
| Mar 24, 2:45 pm 2009 |
| Stephen Hemminger | [ANNOUNCE] iproute2 v2.6.29
Trying to stay on top of things (for a change).
New version of iproute2 utilities that includes bug fixes and
support for all the new features in kernel 2.6.29.
http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29.tar.bz2
Denys Fedoryschenko (1):
Fix memory leak in local options
Jamal Hadi Salim (1):
Breakage noticed when debian upgraded to xtables (iptables > 1.4.1)
Patrick McHardy (1):
iproute: add DRR support
Stephen Hemminger (7):
...
| Mar 24, 3:34 pm 2009 |
| David Miller | Re: [ANNOUNCE] iproute2 v2.6.29
From: Stephen Hemminger <shemminger@vyatta.com>
Some build failures here:
gcc -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib/\" -c -o link_gre.o link_gre.c
In file included from link_gre.c:15:
../include/linux/if_tunnel.h:33: error: field ‘iph’ has incomplete type
link_gre.c: In function ‘gre_parse_opt’:
link_gre.c:136: warning: implicit declaration of function ‘__constant_htons’
I seem to remember messing with the kernel headers in ...
| Mar 24, 3:38 pm 2009 |
| Stephen Hemminger | Re: [ANNOUNCE] iproute2 v2.6.29
On Tue, 24 Mar 2009 15:38:22 -0700 (PDT)
Thanks including <linux/ip.h> fixed that.
http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29-1.tar.bz2
--
| Mar 24, 3:48 pm 2009 |
| Ramkrishna Vepa | RE: The Plan
Dave,
We were planning to resubmit the new vxge driver later today to net-2.6.
Can we proceed with this plan of action?
Thanks,
--
| Mar 24, 3:43 pm 2009 |
| David Miller | Re: The Plan
From: "Ramkrishna Vepa" <Ramkrishna.Vepa@neterion.com>
It's a new driver, so sure.
--
| Mar 24, 3:48 pm 2009 |
| David Miller | The Plan
Everything in net-2.6 right now, as well as the final fix
we come up with for the GRO issue will get sucked into
net-next-2.6 as well as queued up for -stable.
Everything in patchwork right now will either be merged
into net-next-2.6 or tossed.
I'll likely send my pull request to Linus tomorrow.
Once that goes in, both net-2.6 and net-next-2.6 will become
fresh clones of Linus's tree.
--
| Mar 24, 3:35 pm 2009 |
| Siemens News Center | Siemens Award Notification
Your email ID has been awarded 750,000,00 GBP in our recent Siemens draw 2009,Contact this office via: sosiemens3@gmail.com
Name:....................
Country:.................
Sex:.....................
Age: .....................
Address:...................
--
| Mar 24, 4:08 pm 2009 |
| Siemens News Center | Siemens Award Notification
Your email ID has been awarded 750,000,00 GBP in our recent Siemens draw 2009,Contact this office via: sosiemens3@gmail.com
Name:....................
Country:.................
Sex:.....................
Age: .....................
Address:...................
--
| Mar 24, 4:08 pm 2009 |
| David Miller | Re: netfilter spurious ELOOP
From: Francis Dupont <Francis.Dupont@fdupont.fr>
Date: Wed, 25 Mar 2009 00:02:05 +0100
--
| Mar 24, 4:28 pm 2009 |
| previous day | today | next day |
|---|---|---|
| March 23, 2009 | March 24, 2009 | March 25, 2009 |
