Home » Mailing list archives » linux-netdev » 2009 » March » 24

[patch 9/9] [PATCH] claw: fix minor findings from code analysis tool

Previous thread: [patch 4/9] [PATCH] claw: invalid return codes from hard_start_xmit by Ursula Braun on Tuesday, March 24, 2009 - 5:29 am. (1 message)

Next thread: [patch 7/9] [PATCH] ctcm: fix minor findings from code analysis tool by Ursula Braun on Tuesday, March 24, 2009 - 5:29 am. (1 message)
[view original message]
From: Ursula Braun
Subject: [patch 9/9] [PATCH] claw: fix minor findings from code analysis tool
Date: Tuesday, March 24, 2009 - 5:29 am

From: Andrew H. Richter <richtera@us.ibm.com>

This patch fixes two problems in the claw driver identified by
static code analysis:
o Change in case differentiation of received sense codes
o Use correct data length in claw hard_start_xmit routine

Signed-off-by: Andrew H. Richter <richtera@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
---

 drivers/s390/net/claw.c |   44 ++++++++++++++++++++------------------------
 1 file changed, 20 insertions(+), 24 deletions(-)

diff -urpN linux-2.6/drivers/s390/net/claw.c linux-2.6-patched/drivers/s390/net/claw.c
--- linux-2.6/drivers/s390/net/claw.c	2009-03-19 11:16:40.000000000 +0100
+++ linux-2.6-patched/drivers/s390/net/claw.c	2009-03-19 11:16:40.000000000 +0100
@@ -1033,7 +1033,7 @@ static int
 pages_to_order_of_mag(int num_of_pages)
 {
 	int	order_of_mag=1;		/* assume 2 pages */
-	int	nump=2;
+	int	nump;
 
 	CLAW_DBF_TEXT_(5, trace, "pages%d", num_of_pages);
 	if (num_of_pages == 1)   {return 0; }  /* magnitude of 0 = 1 page */
@@ -1187,37 +1187,31 @@ ccw_check_unit_check(struct chbk * p_ch,
 	dev_warn(dev, "The communication peer of %s disconnected\n",
 		ndev->name);
 
-        if (sense & 0x40) {
-                if (sense & 0x01) {
+	if (sense & 0x40) {
+		if (sense & 0x01) {
 			dev_warn(dev, "The remote channel adapter for"
 				" %s has been reset\n",
 				ndev->name);
-                }
-        }
-        else if (sense & 0x20) {
-                if (sense & 0x04) {
+		}
+	} else if (sense & 0x20) {
+		if (sense & 0x04) {
 			dev_warn(dev, "A data streaming timeout occurred"
 				" for %s\n",
 				ndev->name);
-                }
-                else  {
-			dev_warn(dev, "A data transfer parity error occurred"
-				" for %s\n",
-				ndev->name);
-                }
-        }
-        else if (sense & 0x10) {
-                if (sense & 0x20) {
+		} else if (sense & 0x10) {
 			dev_warn(dev, "The remote channel adapter for %s"
 				" is faulty\n",
 				ndev->name);
-            ...
[ message continues ]
Previous thread: [patch 4/9] [PATCH] claw: invalid return codes from hard_start_xmit by Ursula Braun on Tuesday, March 24, 2009 - 5:29 am. (1 message)

Next thread: [patch 7/9] [PATCH] ctcm: fix minor findings from code analysis tool by Ursula Braun on Tuesday, March 24, 2009 - 5:29 am. (1 message)